Skip to contentSkip to conversation

davinci_cpdma: make cpdma_chan_split_pool static

PATCH Applied Ben Dooks (Codethink) 2 participants 2 messages Oct 15, 2019 – Oct 16, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 davinci_cpdma: make cpdma_chan_split_pool static

The cpdma_chan_split_pool() function is not used outside of the driver, so make it static to avoid the following sparse warning:

drivers/net/ethernet/ti/davinci_cpdma.c:725:5: warning: symbol 'cpdma_chan_split_pool' was not declared. Should it be static?

---
Cc: Grygorii Strashko <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ti/davinci_cpdma.c +1 -1
index a65edd2770e6..37ba708ac781 100644
@@ -722,7 +722,7 @@ static void cpdma_chan_set_descs(struct cpdma_ctlr *ctlr,
  * cpdma_chan_split_pool - Splits ctrl pool between all channels.
  * Has to be called under ctlr lock
  */
-int cpdma_chan_split_pool(struct cpdma_ctlr *ctlr)
+static int cpdma_chan_split_pool(struct cpdma_ctlr *ctlr)
 {
 	int tx_per_ch_desc = 0, rx_per_ch_desc = 0;
 	int free_rx_num = 0, free_tx_num = 0;
Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw

From: "Ben Dooks (Codethink)" <[email protected]>
Date: Tue, 15 Oct 2019 17:15:58 +0100

Quoted 7 lines

The cpdma_chan_split_pool() function is not used outside of the driver, so make it static to avoid the following sparse warning:

drivers/net/ethernet/ti/davinci_cpdma.c:725:5: warning: symbol 'cpdma_chan_split_pool' was not declared. Should it be static?

Applied, thanks.