scan: Address uninitialized scalars reported by coverity

PATCH In review Tim Kourt 2 participants 2 messages Oct 15, 2019 – Oct 16, 2019

Share & tools

Tim Kourt

author

2019-10-15 17:40 UTC #0 lore raw

PATCH 1/1 scan: Address uninitialized scalars reported by coverity

---
 src/scan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

src/scan.c +2 -2

index 790232bb..ec964893 100644
@@ -1360,9 +1360,9 @@ static void scan_notify(struct l_genl_msg *msg, void *user_data)
 	const void *data;
 	uint8_t cmd;
 	uint64_t uninitialized_var(attr_wdev_id);
-	bool have_wdev_id;
+	bool have_wdev_id = false;
 	uint32_t uninitialized_var(attr_wiphy);
-	bool have_wiphy;
+	bool have_wiphy = false;
 	struct scan_context *sc;
 	bool active_scan = false;

Signature · 1 line

2.13.6

Denis Kenzior

2019-10-16 21:35 UTC #1 lore raw

Hi Tim,

Quoted 3 lines · Tim Kourt

---
  src/scan.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

I fixed this slightly differently, see commit 269377c92f96a7e127694fd0f659262463426edf. Please review.

Regards,
-Denis