Skip to contentSkip to conversation

staging: meson: add space to fix check warning

PATCH In review Jules Irenge 2 participants 2 messages Oct 15, 2019 – Oct 16, 2019

Subsystems (4)
Media (V4L/DVB) Staging Arm/Amlogic Meson SoC support Meson video decoder driver for Amlogic SoCs
lore
Share & tools
lore

Jules Irenge

author
#0 lore raw

PATCH 1/1 staging: meson: add space to fix check warning

Fix "alignment should mactch open parenthesis" check. Issue detected by checkpatch tool

Signed-off-by Jules Irenge <[email protected]>
---
 drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/meson/vdec/codec_mpeg12.c +1 -1
index 48869cc3d973..21e93a13356c 100644
@@ -81,7 +81,7 @@ static int codec_mpeg12_start(struct amvdec_session *sess)
 	}
 
 	ret = amvdec_set_canvases(sess, (u32[]){ AV_SCRATCH_0, 0 },
-					(u32[]){ 8, 0 });
+				  (u32[]){ 8, 0 });
 	if (ret)
 		goto free_workspace;
Signature · 1 line
2.21.0
#1 lore raw
Quoted 13 lines · Jules Irenge

Fix "alignment should mactch open parenthesis" check. Issue detected by checkpatch tool

Signed-off-by Jules Irenge <[email protected]>
---
 drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/meson/vdec/codec_mpeg12.c +0 -0
index 48869cc3d973..21e93a13356c 100644

drivers/staging/media/meson/vdec/codec_mpeg12.c static int codec_mpeg12_start(struct amvdec_session *sess) · line 84

Quoted 4 lines
drivers/staging/media/meson/vdec/codec_mpeg12.c +0 -1
@@ -81,7 +81,7 @@ static int codec_mpeg12_start(struct amvdec_session *sess)
 	}
 
 	ret = amvdec_set_canvases(sess, (u32[]){ AV_SCRATCH_0, 0 },
-					(u32[]){ 8, 0 });

This is clearly intended to be aligned with the (u32[]) prefix for readability.

So this is one checkpatch issue where I prefer to keep the original.

Regards,

Hans

Quoted 5 lines
drivers/staging/media/meson/vdec/codec_mpeg12.c +1 -0
+				  (u32[]){ 8, 0 });
 	if (ret)
 		goto free_workspace;