rcu: rcu_segcblist.c make undeclared items static
PATCH 1/1 rcu: rcu_segcblist.c make undeclared items static
The following are not used outside the unit they are declared in, so make them static to avoid the following sparse warnings:
kernel/rcu/rcu_segcblist.c:91:6: warning: symbol 'rcu_segcblist_set_len' was not declared. Should it be static? kernel/rcu/rcu_segcblist.c:107:6: warning: symbol 'rcu_segcblist_add_len' was not declared. Should it be static? kernel/rcu/rcu_segcblist.c:137:6: warning: symbol 'rcu_segcblist_xchg_len' was not declared. Should it be static?
---
Cc: "Paul E. McKenney" <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Lai Jiangshan <[email protected]>
Cc: Joel Fernandes <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- kernel/rcu/rcu_segcblist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/rcu/rcu_segcblist.c +3 -3
@@ -88,7 +88,7 @@ struct rcu_head *rcu_cblist_dequeue(struct rcu_cblist *rclp) }/* Set the length of an rcu_segcblist structure. */ -void rcu_segcblist_set_len (struct rcu_segcblist *rsclp,long v) +static void rcu_segcblist_set_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU atomic_long_set (&rsclp->len, v);
@@ -104,7 +104,7 @@ void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)* This increase is fully ordered with respect to the callers accesses * both before and after. */ -void rcu_segcblist_add_len (struct rcu_segcblist *rsclp,long v) +static void rcu_segcblist_add_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU smp_mb__before_atomic ();/* Up to the caller! */
@@ -134,7 +134,7 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp)* with the actual number of callbacks on the structure. This exchange is * fully ordered with respect to the callers accesses both before and after. */ -long rcu_segcblist_xchg_len (struct rcu_segcblist *rsclp,long v) +static long rcu_segcblist_xchg_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU return atomic_long_xchg (&rsclp->len, v);
Signature · 1 line
2.23.0
Paul E. McKenney
maintainerQuoted 9 lines · Ben Dooks
The following are not used outside the unit they are declared in, so make them static to avoid the following sparse warnings:
kernel/rcu/rcu_segcblist.c:91:6: warning: symbol 'rcu_segcblist_set_len' was not declared. Should it be static?kernel/rcu/rcu_segcblist.c:107:6: warning: symbol 'rcu_segcblist_add_len' was not declared. Should it be static?kernel/rcu/rcu_segcblist.c:137:6: warning: symbol 'rcu_segcblist_xchg_len' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>
Good catch, but commit 292d1bb2 ("rcu: Several rcu_segcblist functions can be static") beat you to it by a month or two. This commit is still in -rcu, but will be part of my pull request in a couple of weeks.
See -rcu branch "dev":
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Thanx, Paul
Quoted 47 lines
---
Cc: "Paul E. McKenney" <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Lai Jiangshan <[email protected]>
Cc: Joel Fernandes <[email protected]>
Cc: [email protected]
Cc: [email protected]--- kernel/rcu/rcu_segcblist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/rcu/rcu_segcblist.c +3
-3@@ -88,7 +88,7 @@ struct rcu_head *rcu_cblist_dequeue(struct rcu_cblist *rclp) }/* Set the length of an rcu_segcblist structure. */ -void rcu_segcblist_set_len (struct rcu_segcblist *rsclp,long v) +static void rcu_segcblist_set_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU atomic_long_set (&rsclp->len, v);@@ -104,7 +104,7 @@ void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v)* This increase is fully ordered with respect to the callers accesses * both before and after. */ -void rcu_segcblist_add_len (struct rcu_segcblist *rsclp,long v) +static void rcu_segcblist_add_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU smp_mb__before_atomic ();/* Up to the caller! */ @@ -134,7 +134,7 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp)* with the actual number of callbacks on the structure. This exchange is * fully ordered with respect to the callers accesses both before and after. */ -long rcu_segcblist_xchg_len (struct rcu_segcblist *rsclp,long v) +static long rcu_segcblist_xchg_len (struct rcu_segcblist *rsclp,long v) {#ifdef CONFIG_RCU_NOCB_CPU return atomic_long_xchg (&rsclp->len, v);Signature · 1 line
2.23.0