rcu: move rcu_{expedited,normal} definitions into rcupdate.h
PATCH 1/1 rcu: move rcu_{expedited,normal} definitions into rcupdate.h
Move the rcu_{expedited,normal} definitions into rcupdate.h to make sure they are in sync, and avoid the following warning from sparse:
kernel/ksysfs.c:150:5: warning: symbol 'rcu_expedited' was not declared. Should it be static? kernel/ksysfs.c:167:5: warning: symbol 'rcu_normal' was not declared. Should it be static?
---
Cc: "Paul E. McKenney" <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Lai Jiangshan <[email protected]>
Cc: Joel Fernandes <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- include/linux/rcupdate.h | 4 ++++ kernel/rcu/update.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-)
include/linux/rcupdate.h +4 -0
@@ -894,4 +894,8 @@ rcu_head_after_call_rcu(struct rcu_head *rhp, rcu_callback_t f) return false; } +/* kernel/ksysfs.c definitions */ +extern int rcu_expedited; +extern int rcu_normal; +#endif /* __LINUX_RCUPDATE_H */
kernel/rcu/update.c +0 -2
@@ -51,9 +51,7 @@#define MODULE_PARAM_PREFIX "rcupdate."#ifndef CONFIG_TINY_RCU -extern int rcu_expedited;/* from sysctl */ module_param (rcu_expedited, int,0 ); -extern int rcu_normal;/* from sysctl */ module_param (rcu_normal, int,0 );static int rcu_normal_after_boot;module_param (rcu_normal_after_boot, int,0 );
Signature · 1 line
2.23.0
Paul E. McKenney
maintainerQuoted 8 lines · Ben Dooks
Move the rcu_{expedited,normal} definitions into
rcupdate.hto make sure they are in sync, and avoid the following warning from sparse:
kernel/ksysfs.c:150:5: warning: symbol 'rcu_expedited' was not declared. Should it be static?kernel/ksysfs.c:167:5: warning: symbol 'rcu_normal' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>
Good point, queued for review and testing, thank you!
Thanx, Paul
Quoted 44 lines
---
Cc: "Paul E. McKenney" <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Lai Jiangshan <[email protected]>
Cc: Joel Fernandes <[email protected]>
Cc: [email protected]
Cc: [email protected]--- include/linux/rcupdate.h | 4 ++++ kernel/rcu/update.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-)include/linux/rcupdate.h +4
-0@@ -894,4 +894,8 @@ rcu_head_after_call_rcu(struct rcu_head *rhp, rcu_callback_t f) return false; } +/* kernel/ksysfs.c definitions */ +extern int rcu_expedited; +extern int rcu_normal; +#endif /* __LINUX_RCUPDATE_H */ kernel/rcu/update.c +0
-2@@ -51,9 +51,7 @@#define MODULE_PARAM_PREFIX "rcupdate."#ifndef CONFIG_TINY_RCU -extern int rcu_expedited;/* from sysctl */ module_param (rcu_expedited, int,0 ); -extern int rcu_normal;/* from sysctl */ module_param (rcu_normal, int,0 );static int rcu_normal_after_boot;module_param (rcu_normal_after_boot, int,0 );Signature · 1 line
2.23.0