bus: moxtet: declare moxtet_bus_type
PATCH 1/1 bus: moxtet: declare moxtet_bus_type
The moxtet_bus_type object is exported from the bus driver, but not declared. Add a declaration for use and to silence the following warning:
drivers/bus/moxtet.c:105:17: warning: symbol 'moxtet_bus_type' was not declared. Should it be static?
---
Cc: Marek Behun <[email protected]>
Cc: [email protected]
--- include/linux/moxtet.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/moxtet.h +2 -0
@@ -94,6 +94,8 @@ struct moxtet_device {unsigned int idx; }; +extern struct bus_type moxtet_bus_type; +extern int moxtet_device_read (struct device *dev);extern int moxtet_device_write (struct device *dev,u8 val);extern int moxtet_device_written (struct device *dev);
Signature · 1 line
2.23.0
Quoted 3 lines · Ben Dooks
The
moxtet_bus_typeobject is exported from the bus driver, but not declared. Add a declaration for use and to silence the following warning:
The symbol can be marked static instead.
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Ben Dooks
The
moxtet_bus_typeobject is exported from the bus driver, but not declared. Add a declaration for use and to silence the following warning:The symbol can be marked static instead.
Then it would have to be un-exported as it's listed as EXPORT_SYMBOL_GPL(moxtet_bus_type);
Signature · 4 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
Quoted 10 lines · Ben Dooks
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Ben Dooks
The
moxtet_bus_typeobject is exported from the bus driver, but not declared. Add a declaration for use and to silence the following warning:The symbol can be marked static instead.
Then it would have to be un-exported as it's listed as
EXPORT_SYMBOL_GPL(moxtet_bus_type);
Yes, once you mark it static you should also remove the export.