net: stmmac: fix argument to stmmac_pcs_ctrl_ane()
Subsystems (4)
PATCH 1/1 net: stmmac: fix argument to stmmac_pcs_ctrl_ane()
The stmmac_pcs_ctrl_ane() expects a register address as argument 1, but for some reason the mac_device_info is being passed.
Fix the warning (and possible bug) from sparse:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] <asn:2> *ioaddrdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got struct mac_device_info *hw
---
Cc: Giuseppe Cavallaro <[email protected]>
Cc: Alexandre Torgue <[email protected]>
Cc: Jose Abreu <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -1
@@ -2610,7 +2610,7 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) }if (priv->hw->pcs) -stmmac_pcs_ctrl_ane (priv, priv->hw,1 , priv->hw->ps,0 ); +stmmac_pcs_ctrl_ane (priv, priv->ioaddr,1 , priv->hw->ps,0 );/* set TX and RX rings length */ stmmac_set_rings_length (priv);
Signature · 7 lines
2.23.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 9 lines · Ben Dooks (Codethink)
The
stmmac_pcs_ctrl_ane()expects a register address as argument 1, but for some reason themac_device_infois being passed.Fix the warning (and possible bug) from sparse:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] <asn:2> *ioaddrdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got structmac_device_info*hw
apologies, looks like I reposted this by accident.
Signature · 4 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
David Miller
maintainerFrom: "Ben Dooks (Codethink)" <[email protected]>
Date: Wed, 16 Oct 2019 09:22:05 +0100
Quoted 11 lines
The
stmmac_pcs_ctrl_ane()expects a register address as argument 1, but for some reason themac_device_infois being passed.Fix the warning (and possible bug) from sparse:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] <asn:2> *ioaddrdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got structmac_device_info*hwSigned-off-by Ben Dooks <[email protected]>
I'm still reviewing this but FYI you did not have to send this twice.
Always check:
https://patchwork.ozlabs.org/project/netdev/list/
to see what state your patch submission is in.
Quoted 9 lines · David Miller
From: "Ben Dooks (Codethink)" <[email protected]>
Date: Wed, 16 Oct 2019 09:22:05 +0100Quoted 6 lines
The
stmmac_pcs_ctrl_ane()expects a register address as argument 1, but for some reason themac_device_infois being passed.Fix the warning (and possible bug) from sparse:
Quoted 8 lines
Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] <asn:2> *ioaddrdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got structmac_device_info*hwSigned-off-by Ben Dooks <[email protected]>I'm still reviewing this but FYI you did not have to send this twice.
Yes, I accidentally sent the wrong patch out (already apologised on the re-send as I noticed it about 10 minutes after sending).
Signature · 4 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
From: "Ben Dooks (Codethink)" <[email protected]>
Date: Wed, 16 Oct 2019 09:22:05 +0100
Quoted 11 lines
The
stmmac_pcs_ctrl_ane()expects a register address as argument 1, but for some reason themac_device_infois being passed.Fix the warning (and possible bug) from sparse:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] <asn:2> *ioaddrdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got structmac_device_info*hwSigned-off-by Ben Dooks <[email protected]>
Applied, thanks.