Skip to contentSkip to conversation

ipmi: bt-bmc: use devm_platform_ioremap_resource() to simplify code

PATCH In review YueHaibing 3 participants 4 messages Oct 16, 2019 IPMI

lore
Share & tools
lore

YueHaibing

author
#0 lore raw

PATCH 1/1 ipmi: bt-bmc: use devm_platform_ioremap_resource() to simplify code

Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle.

---
 drivers/char/ipmi/bt-bmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/char/ipmi/bt-bmc.c +1 -3
index 40b9927..d36aeac 100644
@@ -444,15 +444,13 @@ static int bt_bmc_probe(struct platform_device *pdev)
 
 	bt_bmc->map = syscon_node_to_regmap(pdev->dev.parent->of_node);
 	if (IS_ERR(bt_bmc->map)) {
-		struct resource *res;
 		void __iomem *base;
 
 		/*
 		 * Assume it's not the MFD-based devicetree description, in
 		 * which case generate a regmap ourselves
 		 */
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		base = devm_ioremap_resource(&pdev->dev, res);
+		base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(base))
 			return PTR_ERR(base);
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · YueHaibing

Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle.

Adding the module author and others. I can't see a reason to not do this.

-corey

Quoted 31 lines
---
 drivers/char/ipmi/bt-bmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/char/ipmi/bt-bmc.c +1 -3
index 40b9927..d36aeac 100644
@@ -444,15 +444,13 @@ static int bt_bmc_probe(struct platform_device *pdev)
 
 	bt_bmc->map = syscon_node_to_regmap(pdev->dev.parent->of_node);
 	if (IS_ERR(bt_bmc->map)) {
-		struct resource *res;
 		void __iomem *base;
 
 		/*
 		 * Assume it's not the MFD-based devicetree description, in
 		 * which case generate a regmap ourselves
 		 */
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		base = devm_ioremap_resource(&pdev->dev, res);
+		base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(base))
 			return PTR_ERR(base);
 
Signature · 1 line
2.7.4
Reviewed-by
#2 lore raw
Quoted 6 lines · Corey Minyard
Quoted 2 lines · YueHaibing

Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle.

Adding the module author and others. I can't see a reason to not do this.

yes. Looks good to me.

Thanks,

C.

Quoted 33 lines

-corey

Quoted 31 lines
---
 drivers/char/ipmi/bt-bmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/char/ipmi/bt-bmc.c +1 -3
index 40b9927..d36aeac 100644
@@ -444,15 +444,13 @@ static int bt_bmc_probe(struct platform_device *pdev)
 
 	bt_bmc->map = syscon_node_to_regmap(pdev->dev.parent->of_node);
 	if (IS_ERR(bt_bmc->map)) {
-		struct resource *res;
 		void __iomem *base;
 
 		/*
 		 * Assume it's not the MFD-based devicetree description, in
 		 * which case generate a regmap ourselves
 		 */
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		base = devm_ioremap_resource(&pdev->dev, res);
+		base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(base))
 			return PTR_ERR(base);
 
Signature · 1 line
2.7.4
#3 lore raw
Quoted 11 lines · Cédric Le Goater
Quoted 6 lines · Corey Minyard
Quoted 2 lines · YueHaibing

Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle.

Adding the module author and others. I can't see a reason to not do this.

yes. Looks good to me.

Queued for next merge window, unless someone protests.

-corey

Quoted 39 lines

Thanks,

C.

Quoted 33 lines

-corey

Quoted 31 lines
---
 drivers/char/ipmi/bt-bmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/char/ipmi/bt-bmc.c +1 -3
index 40b9927..d36aeac 100644
@@ -444,15 +444,13 @@ static int bt_bmc_probe(struct platform_device *pdev)
 
 	bt_bmc->map = syscon_node_to_regmap(pdev->dev.parent->of_node);
 	if (IS_ERR(bt_bmc->map)) {
-		struct resource *res;
 		void __iomem *base;
 
 		/*
 		 * Assume it's not the MFD-based devicetree description, in
 		 * which case generate a regmap ourselves
 		 */
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		base = devm_ioremap_resource(&pdev->dev, res);
+		base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(base))
 			return PTR_ERR(base);
 
Signature · 1 line
2.7.4