Skip to contentSkip to conversation

Mobiveil legacy IRQ binding erroneous interrupt-map

DISCUSSION Lorenzo Pieralisi 3 participants 3 messages Oct 16, 2019 – Oct 29, 2019 PCI

lore
Share & tools
lore
#0 lore raw

Hi Hou, Karthikeyan,

I have just noticed the mobiveil interrupt-map DT bindings example is wrong:

This:

interrupt-map = <0 0 0 0 &pci_express 0>,

		<0 0 0 1 &pci_express 1>,
		<0 0 0 2 &pci_express 2>,
		<0 0 0 3 &pci_express 3>;

should be:

interrupt-map = <0 0 0 1 &pci_express 0>,

		<0 0 0 2 &pci_express 1>,
		<0 0 0 3 &pci_express 2>,
		<0 0 0 4 &pci_express 3>;

Legacy IRQs Interrupt pins map this way:

{{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}

(as read from Interrupt pin register in the config space header) (ie refer to PCI local bus specification 3.0), please fix it as soon as possible.

Lorenzo

#1 lore raw

Hi Lorenzo,

The Mobiveil INTx controller is not used on NXP's platform, so I cannot verify this feature.

Karthikeyan, please have a look on this issue.

Thanks,
Zhiqiang

Quoted 34 lines

-----Original Message-----
From: Lorenzo Pieralisi <[email protected]>
Sent: 2019年10月16日 18:32
To: Z.q. Hou <[email protected]>; Karthikeyan Mitran <[email protected]>
Cc: [email protected]
Subject: Mobiveil legacy IRQ binding erroneous interrupt-map

Hi Hou, Karthikeyan,

I have just noticed the mobiveil interrupt-map DT bindings example is wrong:

This:

interrupt-map = <0 0 0 0 &pci_express 0>,

		<0 0 0 1 &pci_express 1>,
		<0 0 0 2 &pci_express 2>,
		<0 0 0 3 &pci_express 3>;

should be:

interrupt-map = <0 0 0 1 &pci_express 0>,

		<0 0 0 2 &pci_express 1>,
		<0 0 0 3 &pci_express 2>,
		<0 0 0 4 &pci_express 3>;

Legacy IRQs Interrupt pins map this way:

{{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}

(as read from Interrupt pin register in the config space header) (ie refer to PCI local bus specification 3.0), please fix it as soon as possible.

Lorenzo

#2 lore raw

Hi Lorenzo, Zhiqiang,
Thanks, will check and fix.

Quoted 44 lines · Z.q. Hou

Hi Lorenzo,

The Mobiveil INTx controller is not used on NXP's platform, so I cannot verify this feature.

Karthikeyan, please have a look on this issue.

Thanks,
Zhiqiang

Quoted 34 lines

-----Original Message-----
From: Lorenzo Pieralisi <[email protected]>
Sent: 2019年10月16日 18:32
To: Z.q. Hou <[email protected]>; Karthikeyan Mitran <[email protected]>
Cc: [email protected]
Subject: Mobiveil legacy IRQ binding erroneous interrupt-map

Hi Hou, Karthikeyan,

I have just noticed the mobiveil interrupt-map DT bindings example is wrong:

This:

interrupt-map = <0 0 0 0 &pci_express 0>,

              <0 0 0 1 &pci_express 1>,
              <0 0 0 2 &pci_express 2>,
              <0 0 0 3 &pci_express 3>;

should be:

interrupt-map = <0 0 0 1 &pci_express 0>,

              <0 0 0 2 &pci_express 1>,
              <0 0 0 3 &pci_express 2>,
              <0 0 0 4 &pci_express 3>;

Legacy IRQs Interrupt pins map this way:

{{1, INTA}, {2, INTB}, {3,INTC}, {4,INTD}}

(as read from Interrupt pin register in the config space header) (ie refer to PCI local bus specification 3.0), please fix it as soon as possible.

Lorenzo

Signature · 11 lines
Thanks,
Regards,
Karthikeyan Mitran

-- 
Mobiveil INC., CONFIDENTIALITY NOTICE: This e-mail message, including any 
attachments, is for the sole use of the intended recipient(s) and may 
contain proprietary confidential or privileged information or otherwise be 
protected by law. Any unauthorized review, use, disclosure or distribution 
is prohibited. If you are not the intended recipient, please notify the 
sender and destroy all copies and the original message.