drm/panel: simple: Add Logic PD Type 28 display support
Subsystems (4)
PATCH v5 1/3 drm/panel: simple: Add Logic PD Type 28 display support
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
---
V5: No Change V4: No Change V3: No Change V2: No Change
drivers/gpu/drm/panel/panel-simple.c +37 -0
@@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock =9000 , + .hdisplay =480 , + .hsync_start =480 +3 , + .hsync_end =480 +3 +42 , + .htotal =480 +3 +42 +2 , + + .vdisplay =272 , + .vsync_start =272 +2 , + .vsync_end =272 +2 +11 , + .vtotal =272 +2 +11 +3 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =105 , + .height =67 , + }, + .delay = { + .prepare =200 , + .enable =200 , + .unprepare =200 , + .disable =200 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE , +}; +static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes =1 ,
@@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,
Signature · 1 line
2.17.1
PATCH v5 2/3 dt-bindings: Add Logic PD Type 28 display panel
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +42 -0
@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: logicpd,type28 + + power-supply: true + enable-gpios: true + backlight: true + port: true + +required: + - compatible + +additionalProperties: false + +examples: + - | + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 0>; + backlight = <&backlight>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; + +...
Signature · 1 line
2.17.1
Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
Hi Adam,
Thank you for the patch.
Quoted 31 lines · Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by Adam Ford <[email protected]>---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for bindingDocumentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +15
-0@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties:
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml line 25
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +10
-0+ compatible: + const: logicpd,type28 + + power-supply: true + enable-gpios: true + backlight: true + port: true + +required: + - compatible
Should the port be required too ? Apart from that,
Quoted 17 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +17
-0+ +additionalProperties: false + +examples: + - | + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 0>; + backlight = <&backlight>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; + +...
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
Quoted 41 lines · Laurent Pinchart
Hi Adam,
Thank you for the patch.
Quoted 35 lines · Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by Adam Ford <[email protected]>---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for bindingDocumentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +19
-0@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: logicpd,type28 + + power-supply: true
Quoted 8 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml line 25
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +6
-0+ enable-gpios: true + backlight: true + port: true + +required: + - compatibleShould the port be required too ? Apart from that,
I supposed that's true, but I used ampire,am-480272h3tmqw-t01h.yaml as the example, and it doesn't list it as a required item.
Is there anything else I need to address? I feel like I'm trying to hit a moving target.
adam
Quoted 24 lines
Reviewed-by Laurent Pinchart <[email protected]>Quoted 7 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +7
-0+ +additionalProperties: false + +examples: + - | + lcd0: display { + compatible = "logicpd,type28";Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml line 42
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +10
-0+ enable-gpios = <&gpio5 27 0>; + backlight = <&backlight>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; + +...--
Regards,Laurent Pinchart
Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
Quoted 52 lines · Adam Ford
Quoted 41 lines · Laurent Pinchart
Hi Adam,
Thank you for the patch.
Quoted 35 lines · Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by Adam Ford <[email protected]>---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for bindingDocumentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +19
-0@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: logicpd,type28 + + power-supply: trueQuoted 8 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml line 25
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +6
-0+ enable-gpios: true + backlight: true + port: true + +required: + - compatibleShould the port be required too ? Apart from that,
Quoted 4 lines
I supposed that's true, but I used ampire,am-480272h3tmqw-t01h.yaml as the example, and it doesn't list it as a required item.
Is there anything else I need to address? I feel like I'm trying to hit a moving target.
'port' can be omitted because the panel can be a child node of the display controller instead. That's decided by the display controller binding, not the panel binding.
Rob
Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
Quoted 59 lines · Rob Herring
Quoted 52 lines · Adam Ford
Quoted 41 lines · Laurent Pinchart
Hi Adam,
Thank you for the patch.
Quoted 35 lines · Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by Adam Ford <[email protected]>---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for bindingDocumentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +19
-0@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: logicpd,type28 + + power-supply: trueQuoted 8 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml line 25
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file +6
-0+ enable-gpios: true + backlight: true + port: true + +required: + - compatibleShould the port be required too ? Apart from that,
Quoted 4 lines
I supposed that's true, but I used ampire,am-480272h3tmqw-t01h.yaml as the example, and it doesn't list it as a required item.
Is there anything else I need to address? I feel like I'm trying to hit a moving target.
Quoted 5 lines
'port' can be omitted because the panel can be a child node of the display controller instead. That's decided by the display controller binding, not the panel binding.
Reviewed-by Rob Herring <[email protected]>
Thank you. Sorry it took a while to get there.
adam
Quoted 2 lines
Rob
Sam Ravnborg
AppliedRe: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
In reply to Adam FordHi Adam.
Quoted 10 lines · Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display.
Signed-off-by Adam Ford <[email protected]>---
V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1 V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding
Applied to drm-misc-next.
It was applied before the driver changes so we had bindings for the driver changes when applied.
Sam
PATCH v5 3/3 ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel
In reply to Adam FordWith the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28"
---
V5: No Change V4: No Change V3: No change V2: Remove legacy 'label' from binding
arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +2 -18
@@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH V5 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel
Quoted 6 lines · Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28"
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
Quoted 7 lines
Signed-off-by Adam Ford <[email protected]>Acked-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No change V2: Remove legacy 'label' from binding
I'm picking this patch into omap-for-v5.5/dt thanks.
Regards,
Tony
Quoted 32 lines
arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +2
-18@@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };Signature · 1 line
2.17.1
Quoted 9 lines · Adam Ford
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
Will this be able to make it into linux-next for the 5.5 merge window?
I believe Tony has picked up the device tree portion in his omap
tree, but I haven't seen any notifications on this series on whether or not it's being applied. I also don't know which tree I need to look if it's already been applied.
This fixes a regression introduced a while ago where the driver I was using for the display was removed.
thank you,
adam
Quoted 66 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No Change V2: No Changedrivers/gpu/drm/panel/panel-simple.c +37
-1@@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock =9000 , + .hdisplay =480 , + .hsync_start =480 +3 , + .hsync_end =480 +3 +42 , + .htotal =480 +3 +42 +2 , + + .vdisplay =272 , + .vsync_start =272 +2 , + .vsync_end =272 +2 +11 , + .vtotal =272 +2 +11 +3 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =105 , + .height =67 , + }, + .delay = { + .prepare =200 , + .enable =200 , + .unprepare =200 , + .disable =200 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE , +}; +static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes =1 ,@@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, --2.17.1
Quoted 10 lines · Adam Ford
Quoted 8 lines · Adam Ford
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
Quoted 8 lines
Will this be able to make it into linux-next for the 5.5 merge window? I believe Tony has picked up the device tree portion in his omap tree, but I haven't seen any notifications on this series on whether or not it's being applied. I also don't know which tree I need to look if it's already been applied.
This fixes a regression introduced a while ago where the driver I was using for the display was removed.
Sam, would you be able to pick this up ?
Quoted 63 lines
Quoted 63 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No Change V2: No Changedrivers/gpu/drm/panel/panel-simple.c +37
-0@@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock =9000 , + .hdisplay =480 , + .hsync_start =480 +3 , + .hsync_end =480 +3 +42 , + .htotal =480 +3 +42 +2 , + + .vdisplay =272 , + .vsync_start =272 +2 , + .vsync_end =272 +2 +11 , + .vtotal =272 +2 +11 +3 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =105 , + .height =67 , + }, + .delay = { + .prepare =200 , + .enable =200 , + .unprepare =200 , + .disable =200 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE , +}; +static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes =1 ,@@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 18 lines · Laurent Pinchart
Quoted 16 lines · Adam Ford
Quoted 8 lines · Adam Ford
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")Will this be able to make it into linux-next for the 5.5 merge window? I believe Tony has picked up the device tree portion in his omap tree, but I haven't seen any notifications on this series on whether or not it's being applied. I also don't know which tree I need to look if it's already been applied.
Quoted 4 lines
Quoted 2 lines
This fixes a regression introduced a while ago where the driver I was using for the display was removed.
Sam, would you be able to pick this up ?
Gentle nudge with the merge window approaching.
Thank you,
adam
Quoted 68 lines
Quoted 56 lines
Quoted 56 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No Change V2: No Changedrivers/gpu/drm/panel/panel-simple.c +34
-0@@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock =9000 , + .hdisplay =480 , + .hsync_start =480 +3 , + .hsync_end =480 +3 +42 , + .htotal =480 +3 +42 +2 , + + .vdisplay =272 , + .vsync_start =272 +2 , + .vsync_end =272 +2 +11 , + .vtotal =272 +2 +11 +3 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =105 , + .height =67 , + }, + .delay = { + .prepare =200 , + .enable =200 , + .unprepare =200 , + .disable =200 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE , +}; +static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes =1 ,@@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { }, {Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 3329
Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0.compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,--
Regards,
Quoted 1 line
Laurent Pinchart
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 21 lines · Adam Ford
Quoted 18 lines · Laurent Pinchart
Quoted 16 lines · Adam Ford
Quoted 8 lines · Adam Ford
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")Will this be able to make it into linux-next for the 5.5 merge window? I believe Tony has picked up the device tree portion in his omap tree, but I haven't seen any notifications on this series on whether or not it's being applied. I also don't know which tree I need to look if it's already been applied.
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
This fixes a regression introduced a while ago where the driver I was using for the display was removed.
Sam, would you be able to pick this up ?
Sam,
Quoted 1 line
Gentle nudge with the merge window approaching.
Is it too late for 5.5? :-(
adam
Quoted 74 lines
Thank you,
adam
Quoted 69 lines
Quoted 56 lines
Quoted 56 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No Change V2: No Changedrivers/gpu/drm/panel/panel-simple.c +34
-0@@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock =9000 , + .hdisplay =480 , + .hsync_start =480 +3 , + .hsync_end =480 +3 +42 , + .htotal =480 +3 +42 +2 , + + .vdisplay =272 , + .vsync_start =272 +2 , + .vsync_end =272 +2 +11 , + .vtotal =272 +2 +11 +3 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =105 , + .height =67 , + }, + .delay = { + .prepare =200 , + .enable =200 , + .unprepare =200 , + .disable =200 , + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE , +}; +static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes =1 ,@@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = { }, {Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 3329
Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c +3
-0.compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,--
Regards,Laurent Pinchart
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg
AppliedHi Adam.
Quoted 8 lines · Adam Ford
Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used.
Fixes 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
Quoted 7 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>---
V5: No Change V4: No Change V3: No Change V2: No Change
Applied to drm-misc-next.
Sorry for the delay - has been absent for a while.
Sam