Skip to contentSkip to conversation

package/gst1-plugins-good: fix xlib dependencies

PATCH New Fabrice Fontaine 2 participants 2 messages Oct 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gst1-plugins-good: fix xlib dependencies

xlib_libXfixes and xlib_libXdamage must be added to dependencies

Fixes:
- http://autobuild.buildroot.org/results/efc1052807f94b1013cc8c13bdd790a01ed7255d

---
 .../gst1-plugins-good/gst1-plugins-good.mk          | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +9 -4
index a8dae1b7bb..e11f9c213e 100644
@@ -366,10 +366,15 @@ endif
 
 ifeq ($(BR2_PACKAGE_XORG7),y)
 GST1_PLUGINS_GOOD_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXv
-GST1_PLUGINS_GOOD_CONF_OPTS += \
-	-Dximagesrc=enabled \
-	$(if $(BR2_PACKAGE_XLIB_LIBXFIXES),-Dximagesrc-xfixes=enabled) \
-	$(if $(BR2_PACKAGE_XLIB_LIBXDAMAGE),-Dximagesrc-xdamage=enabled)
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dximagesrc=enabled
+ifeq ($(BR2_PACKAGE_XLIB_LIBXFIXES),y)
+GST1_PLUGINS_GOOD_DEPENDENCIES += xlib_libXfixes
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dximagesrc-xfixes=enabled
+endif
+ifeq ($(BR2_PACKAGE_XLIB_LIBXDAMAGE),y)
+GST1_PLUGINS_GOOD_DEPENDENCIES += xlib_libXdamage
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dximagesrc-xdamage=enabled
+endif
 else
 GST1_PLUGINS_GOOD_CONF_OPTS += \
 	-Dximagesrc=disabled \
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/gst1-plugins-good: fix xlib dependencies

Quoted 9 lines · On Wed, 16 Oct 2019 18:55:12 +0200 Fabrice Fontaine…

xlib_libXfixes and xlib_libXdamage must be added to dependencies

Fixes:
- http://autobuild.buildroot.org/results/efc1052807f94b1013cc8c13bdd790a01ed7255d

---
 .../gst1-plugins-good/gst1-plugins-good.mk          | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com