Skip to contentSkip to conversation

package/libopenssl: set no-asm for static builds

PATCH New Fabrice Fontaine 2 participants 3 messages Oct 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libopenssl: set no-asm for static builds

Use no-asm when building statically with a generic architecture such as gcc, see https://github.com/openssl/openssl/issues/9839

This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by
https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491

Fixes:
- http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Set no-asm with all static builds and not only x86_64

 package/libopenssl/libopenssl.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/libopenssl/libopenssl.mk +3 -1
index 4a430bcb4d..f631a38abb 100644
@@ -55,7 +55,9 @@ endif
 
 ifeq ($(BR2_STATIC_LIBS),y)
 # Use "gcc" minimalistic target to disable DSO
-LIBOPENSSL_TARGET_ARCH = gcc
+# no-asm is needed with generic architectures such as gcc, see
+# https://github.com/openssl/openssl/issues/9839
+LIBOPENSSL_TARGET_ARCH = gcc no-asm
 else
 # Some architectures are optimized in OpenSSL
 # Doesn't work for thumb-only (Cortex-M?)
Signature · 1 line
2.23.0
#1 lore raw

PATCH v2 1/1 package/libopenssl: set no-asm for static builds

Quoted 11 lines · On Wed, 16 Oct 2019 19:10:26 +0200 Fabrice Fontaine…

Use no-asm when building statically with a generic architecture such as gcc, see https://github.com/openssl/openssl/issues/9839

This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by
https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491

Fixes:
- http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185

I am still confused, because the github issue says that no-asm should be used whenever linux-generic{32,64} is used, not just for static linking scenarios. Am I missing something ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/libopenssl: set no-asm for static builds

Le mer. 16 oct. 2019 ? 21:07, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 11 lines
Quoted 7 lines · On Wed, 16 Oct 2019 19:10:26 +0200 Fabrice Fontaine…

Use no-asm when building statically with a generic architecture such as gcc, see

This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by
https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491

Quoted 8 lines
Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185

I am still confused, because the github issue says that no-asm should be used whenever linux-generic{32,64} is used, not just for static linking scenarios. Am I missing something ?

Indeed, I missed that we're setting linux-generic32 by default. I'll set no-asm for this one. The other architectures such as linux-x86_64 are not generic.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice