fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h
Subsystems (2)
PATCH 1/1 fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h
Move fsnotify_mark_connector_cachep to fsnotify.h to properly share it with the user in mark.c and avoid the following warning from sparse:
fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?
---
Cc: Jan Kara <[email protected]>
Cc: Amir Goldstein <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- fs/notify/fsnotify.c | 2 -- fs/notify/fsnotify.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)
fs/notify/fsnotify.c +0 -2
@@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is, }EXPORT_SYMBOL_GPL (fsnotify); -extern struct kmem_cache *fsnotify_mark_connector_cachep; -static __init int fsnotify_init (void ) {int ret;
fs/notify/fsnotify.h +2 -0
@@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);extern struct fsnotify_event_holder *fsnotify_alloc_event_holder (void );extern void fsnotify_destroy_event_holder (struct fsnotify_event_holder *holder); +extern struct kmem_cache *fsnotify_mark_connector_cachep; +#endif /* __FS_NOTIFY_FSNOTIFY_H_ */
Signature · 1 line
2.23.0
Jan Kara
maintainerQuoted 7 lines · Ben Dooks
Move
fsnotify_mark_connector_cacheptofsnotify.hto properly share it with the user inmark.cand avoid the following warning from sparse:
fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>
OK, fair enough. Applied. Thanks for the patch.
Honza
Quoted 37 lines
---
Cc: Jan Kara <[email protected]>
Cc: Amir Goldstein <[email protected]>
Cc: [email protected]
Cc: [email protected]--- fs/notify/fsnotify.c | 2 -- fs/notify/fsnotify.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)fs/notify/fsnotify.c +0
-2@@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is, }EXPORT_SYMBOL_GPL (fsnotify); -extern struct kmem_cache *fsnotify_mark_connector_cachep; -static __init int fsnotify_init (void ) {int ret;fs/notify/fsnotify.h +2
-0@@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);extern struct fsnotify_event_holder *fsnotify_alloc_event_holder (void );extern void fsnotify_destroy_event_holder (struct fsnotify_event_holder *holder); +extern struct kmem_cache *fsnotify_mark_connector_cachep; +#endif /* __FS_NOTIFY_FSNOTIFY_H_ */ Signature · 1 line
2.23.0
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR