Skip to contentSkip to conversation

fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h

PATCH In review Ben Dooks 2 participants 2 messages Oct 15, 2019 – Oct 17, 2019

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h

Move fsnotify_mark_connector_cachep to fsnotify.h to properly share it with the user in mark.c and avoid the following warning from sparse:

fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?

---
Cc: Jan Kara <[email protected]>
Cc: Amir Goldstein <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/notify/fsnotify.c | 2 --
 fs/notify/fsnotify.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/notify/fsnotify.c +0 -2
index 2ecef6155fc0..3e77b728a22b 100644
@@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is,
 }
 EXPORT_SYMBOL_GPL(fsnotify);
 
-extern struct kmem_cache *fsnotify_mark_connector_cachep;
-
 static __init int fsnotify_init(void)
 {
 	int ret;
fs/notify/fsnotify.h +2 -0
index f3462828a0e2..ff2063ec6b0f 100644
@@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
 extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
 extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
 
+extern struct kmem_cache *fsnotify_mark_connector_cachep;
+
 #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
Signature · 1 line
2.23.0
maintainer
#1 lore raw
Quoted 7 lines · Ben Dooks

Move fsnotify_mark_connector_cachep to fsnotify.h to properly share it with the user in mark.c and avoid the following warning from sparse:

fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was not declared. Should it be static?

OK, fair enough. Applied. Thanks for the patch.

Honza

Quoted 37 lines

---
Cc: Jan Kara <[email protected]>
Cc: Amir Goldstein <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/notify/fsnotify.c | 2 --
 fs/notify/fsnotify.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/notify/fsnotify.c +0 -2
index 2ecef6155fc0..3e77b728a22b 100644
@@ -381,8 +381,6 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is,
 }
 EXPORT_SYMBOL_GPL(fsnotify);
 
-extern struct kmem_cache *fsnotify_mark_connector_cachep;
-
 static __init int fsnotify_init(void)
 {
 	int ret;
fs/notify/fsnotify.h +2 -0
index f3462828a0e2..ff2063ec6b0f 100644
@@ -65,4 +65,6 @@ extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
 extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
 extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
 
+extern struct kmem_cache *fsnotify_mark_connector_cachep;
+
 #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
Signature · 1 line
2.23.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR