Skip to contentSkip to conversation

setxattr03: define _GNU_SOURCE to fix build on musl

PATCH New Petr Vorel 3 participants 4 messages Oct 16, 2019 – Oct 17, 2019

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 setxattr03: define _GNU_SOURCE to fix build on musl

From: Petr Vorel <[email protected]>

musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
NOTE: glibc and others define it in <sys/types.h>

---
 testcases/kernel/syscalls/setxattr/setxattr03.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/syscalls/setxattr/setxattr03.c +1 -0
index bb511d5ba..58ee0f880 100644
@@ -13,6 +13,7 @@
  *    -1 and set errno to EPERM
  */
 
+#define _GNU_SOURCE
 #include "config.h"
 #include <sys/ioctl.h>
 #include <sys/types.h>
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 setxattr03: define _GNU_SOURCE to fix build on musl

Hi!

Quoted 2 lines

musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
NOTE: glibc and others define it in <sys/types.h>

I would say that this is obvious enough to go in without a review, acked nevertheless.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 setxattr03: define _GNU_SOURCE to fix build on musl

Hi Cyril, Jan,

Quoted 6 lines

Hi!

Quoted 2 lines

musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
NOTE: glibc and others define it in <sys/types.h>

I would say that this is obvious enough to go in without a review, acked nevertheless.

Thanks for review, pushed.
Sorry for taking your time with obvious fix, next time I'll push it.

Kind regards,
Petr