Skip to contentSkip to conversation

mmp: include common.h for mmp_timer_init

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmp: include common.h for mmp_timer_init

The arch/arm/mach-mmp/time.c should include the common.h header for the declaration of mmp_timer_init.

This fixes the following sparse warning:

arch/arm/mach-mmp/time.c:184:13: warning: symbol 'mmp_timer_init' was not declared. Should it be static?

---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-mmp/time.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-mmp/time.c +1 -0
index 483df32583be..0706d8f667de 100644
@@ -35,6 +35,7 @@
 #include "irqs.h"
 #include "cputype.h"
 #include "clock.h"
+#include "common.h"
 
 #define TIMERS_VIRT_BASE	TIMERS1_VIRT_BASE
 
Signature · 7 lines
2.23.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ben Dooks (Codethink)

The arch/arm/mach-mmp/time.c should include the common.h header for the declaration of mmp_timer_init.

This fixes the following sparse warning:

arch/arm/mach-mmp/time.c:184:13: warning: symbol 'mmp_timer_init' was not declared. Should it be static?

Thank you.

Quoted 12 lines

---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-mmp/time.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-mmp/time.c +0 -0
index 483df32583be..0706d8f667de 100644

arch/arm/mach-mmp/time.c line 41

Quoted 7 lines
arch/arm/mach-mmp/time.c +1 -0
@@ -35,6 +35,7 @@
 #include "irqs.h"
 #include "cputype.h"
 #include "clock.h"
+#include "common.h"
 
 #define TIMERS_VIRT_BASE	TIMERS1_VIRT_BASE
 

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel