Skip to contentSkip to conversation

mmp: move declaration of mmp_dt_init_timer to common.h

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmp: move declaration of mmp_dt_init_timer to common.h

The mmp_dt_init_timer() is shared by several files in the mmp directory, so move the declaration to common.h to remove the following sparse warning:

arch/arm/mach-mmp/time.c:204:13: warning: symbol 'mmp_dt_init_timer' was not declared. Should it be static?

---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-mmp/common.h  | 1 +
 arch/arm/mach-mmp/mmp-dt.c  | 2 --
 arch/arm/mach-mmp/mmp2-dt.c | 2 --
 3 files changed, 1 insertion(+), 4 deletions(-)
arch/arm/mach-mmp/common.h +1 -0
index 483b8b6d3005..5bb6dcf0a8c1 100644
@@ -3,6 +3,7 @@
 #define ARRAY_AND_SIZE(x)	(x), ARRAY_SIZE(x)
 
 extern void mmp_timer_init(int irq, unsigned long rate);
+extern void __init mmp_dt_init_timer(void);
 
 extern void __init mmp_map_io(void);
 extern void mmp_restart(enum reboot_mode, const char *);
arch/arm/mach-mmp/mmp-dt.c +0 -2
index 35559792d5cc..e205cdaf19bf 100644
@@ -15,8 +15,6 @@
 
 #include "common.h"
 
-extern void __init mmp_dt_init_timer(void);
-
 static const char *const pxa168_dt_board_compat[] __initconst = {
 	"mrvl,pxa168-aspenite",
 	NULL,
arch/arm/mach-mmp/mmp2-dt.c +0 -2
index 305a9daba6d6..ea63203b8810 100644
@@ -16,8 +16,6 @@
 
 #include "common.h"
 
-extern void __init mmp_dt_init_timer(void);
-
 static void __init mmp_init_time(void)
 {
 #ifdef CONFIG_CACHE_TAUROS2
Signature · 7 lines
2.23.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 5 lines · Ben Dooks (Codethink)

The mmp_dt_init_timer() is shared by several files in the mmp directory, so move the declaration to common.h to remove the following sparse warning:

arch/arm/mach-mmp/time.c:204:13: warning: symbol 'mmp_dt_init_timer' was not declared. Should it be static?

Thanks for the patch.

However, I have a patch in the queue that gets rid of that symbol altogether instead:

https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git/commit/?h=mmp-soc-for-v5.5-2&id=1732050f48a384fbe101b8586ed42caf874816eb

Lubo

Quoted 41 lines

---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-mmp/common.h  | 1 +
 arch/arm/mach-mmp/mmp-dt.c  | 2 --
 arch/arm/mach-mmp/mmp2-dt.c | 2 --
 3 files changed, 1 insertion(+), 4 deletions(-)
arch/arm/mach-mmp/common.h +1 -0
index 483b8b6d3005..5bb6dcf0a8c1 100644
@@ -3,6 +3,7 @@
 #define ARRAY_AND_SIZE(x)	(x), ARRAY_SIZE(x)
 
 extern void mmp_timer_init(int irq, unsigned long rate);
+extern void __init mmp_dt_init_timer(void);
 
 extern void __init mmp_map_io(void);
 extern void mmp_restart(enum reboot_mode, const char *);
arch/arm/mach-mmp/mmp-dt.c +0 -2
index 35559792d5cc..e205cdaf19bf 100644
@@ -15,8 +15,6 @@
 
 #include "common.h"
 
-extern void __init mmp_dt_init_timer(void);
-
 static const char *const pxa168_dt_board_compat[] __initconst = {
 	"mrvl,pxa168-aspenite",
 	NULL,
arch/arm/mach-mmp/mmp2-dt.c +0 -0
index 305a9daba6d6..ea63203b8810 100644

arch/arm/mach-mmp/mmp2-dt.c line 21

Quoted 8 lines
arch/arm/mach-mmp/mmp2-dt.c +0 -2
@@ -16,8 +16,6 @@
 
 #include "common.h"
 
-extern void __init mmp_dt_init_timer(void);
-
 static void __init mmp_init_time(void)
 {
 #ifdef CONFIG_CACHE_TAUROS2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel