mmp: move declaration of mmp_dt_init_timer to common.h
Subsystems (3)
PATCH 1/1 mmp: move declaration of mmp_dt_init_timer to common.h
The mmp_dt_init_timer() is shared by several files in the mmp directory, so move the declaration to common.h to remove the following sparse warning:
arch/arm/mach-mmp/time.c:204:13: warning: symbol 'mmp_dt_init_timer' was not declared. Should it be static?
---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]
--- arch/arm/mach-mmp/common.h | 1 + arch/arm/mach-mmp/mmp-dt.c | 2 -- arch/arm/mach-mmp/mmp2-dt.c | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-)
arch/arm/mach-mmp/common.h +1 -0
@@ -3,6 +3,7 @@#define ARRAY_AND_SIZE (x) (x), ARRAY_SIZE(x)extern void mmp_timer_init (int irq,unsigned long rate); +extern void __init mmp_dt_init_timer (void );extern void __init mmp_map_io (void );extern void mmp_restart (enum reboot_mode ,const char *);
arch/arm/mach-mmp/mmp-dt.c +0 -2
@@ -15,8 +15,6 @@#include "common.h" -extern void __init mmp_dt_init_timer (void ); -static const char *const pxa168_dt_board_compat[]__initconst = {"mrvl,pxa168-aspenite" ,NULL ,
arch/arm/mach-mmp/mmp2-dt.c +0 -2
@@ -16,8 +16,6 @@#include "common.h" -extern void __init mmp_dt_init_timer (void ); -static void __init mmp_init_time (void ) {#ifdef CONFIG_CACHE_TAUROS2
Signature · 7 lines
2.23.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Lubomir Rintel
reviewerQuoted 5 lines · Ben Dooks (Codethink)
The
mmp_dt_init_timer()is shared by several files in the mmp directory, so move the declaration tocommon.hto remove the following sparse warning:
arch/arm/mach-mmp/time.c:204:13: warning: symbol 'mmp_dt_init_timer' was not declared. Should it be static?
Thanks for the patch.
However, I have a patch in the queue that gets rid of that symbol altogether instead:
Lubo
Quoted 41 lines
Signed-off-by Ben Dooks <[email protected]>---
Cc: Lubomir Rintel <[email protected]>
Cc: [email protected]--- arch/arm/mach-mmp/common.h | 1 + arch/arm/mach-mmp/mmp-dt.c | 2 -- arch/arm/mach-mmp/mmp2-dt.c | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-)arch/arm/mach-mmp/common.h +1
-0@@ -3,6 +3,7 @@#define ARRAY_AND_SIZE (x) (x), ARRAY_SIZE(x)extern void mmp_timer_init (int irq,unsigned long rate); +extern void __init mmp_dt_init_timer (void );extern void __init mmp_map_io (void );extern void mmp_restart (enum reboot_mode ,const char *);arch/arm/mach-mmp/mmp-dt.c +0
-2@@ -15,8 +15,6 @@#include "common.h" -extern void __init mmp_dt_init_timer (void ); -static const char *const pxa168_dt_board_compat[]__initconst = {"mrvl,pxa168-aspenite" ,NULL ,arch/arm/mach-mmp/mmp2-dt.c +0
-0
arch/arm/mach-mmp/mmp2-dt.c line 21
Quoted 8 lines
arch/arm/mach-mmp/mmp2-dt.c +0
-2@@ -16,8 +16,6 @@#include "common.h" -extern void __init mmp_dt_init_timer (void ); -static void __init mmp_init_time (void ) {#ifdef CONFIG_CACHE_TAUROS2
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel