Skip to contentSkip to conversation

zx: make zx_smp_prepare_cpus static

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019 – Oct 28, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zx: make zx_smp_prepare_cpus static

The zx_smp_prepare_cpus is not declared and not directly exported outside of the file it is in. Make it static to remove the following sparse warning:

arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static?

---
Cc: Jun Nie <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-zx/platsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-zx/platsmp.c +1 -1
index d4e1d3792224..43a33eaff388 100644
@@ -38,7 +38,7 @@ static void __iomem *pcu_base;
 static void __iomem *matrix_base;
 static void __iomem *scu_base;
 
-void __init zx_smp_prepare_cpus(unsigned int max_cpus)
+static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
 {
 	struct device_node *np;
 	unsigned long base = 0;
Signature · 7 lines
2.23.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ben Dooks (Codethink)

The zx_smp_prepare_cpus is not declared and not directly exported outside of the file it is in. Make it static to remove the following sparse warning:

arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static?

@Arnd, please help apply it to arm-soc, thanks!

Shawn

Quoted 25 lines

---
Cc: Jun Nie <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]

---
 arch/arm/mach-zx/platsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-zx/platsmp.c +1 -1
index d4e1d3792224..43a33eaff388 100644
@@ -38,7 +38,7 @@ static void __iomem *pcu_base;
 static void __iomem *matrix_base;
 static void __iomem *scu_base;
 
-void __init zx_smp_prepare_cpus(unsigned int max_cpus)
+static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
 {
 	struct device_node *np;
 	unsigned long base = 0;
Signature · 1 line
2.23.0

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel