Skip to contentSkip to conversation

gpu: host1x: make 'host1x_cdma_wait_pushbuffer_space' static

PATCH Applied Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: make 'host1x_cdma_wait_pushbuffer_space' static

The host1x_cdma_wait_pushbuffer_space function is not declared or directly called from outside the file it is in, so make it static.

Fixes the following sparse warnign:
drivers/gpu/host1x/cdma.c:235:5: warning: symbol 'host1x_cdma_wait_pushbuffer_space' was not declared. Should it be static?

---
Cc: Thierry Reding <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 drivers/gpu/host1x/cdma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/host1x/cdma.c +3 -3
index 48c84c48299c..e8d3fda91d8a 100644
@@ -232,9 +232,9 @@ unsigned int host1x_cdma_wait_locked(struct host1x_cdma *cdma,
  *
  * Must be called with the cdma lock held.
  */
-int host1x_cdma_wait_pushbuffer_space(struct host1x *host1x,
-				      struct host1x_cdma *cdma,
-				      unsigned int needed)
+static int host1x_cdma_wait_pushbuffer_space(struct host1x *host1x,
+					     struct host1x_cdma *cdma,
+					     unsigned int needed)
 {
 	while (true) {
 		struct push_buffer *pb = &cdma->push_buffer;
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 7 lines · Ben Dooks (Codethink)

The host1x_cdma_wait_pushbuffer_space function is not declared or directly called from outside the file it is in, so make it static.

Fixes the following sparse warnign:
drivers/gpu/host1x/cdma.c:235:5: warning: symbol 'host1x_cdma_wait_pushbuffer_space' was not declared. Should it be static?

Quoted 8 lines

---
Cc: Thierry Reding <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 drivers/gpu/host1x/cdma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel