Skip to contentSkip to conversation

drm: include <drm/drm_cache.h> for 'drm_need_swiotlb'

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019 – Oct 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: include <drm/drm_cache.h> for 'drm_need_swiotlb'

The drm_need_swiotlb is declared in <drm/drm_cache.h> which should be included in drivers/gpu/drm/drm_memory.c to silence the following warning:

drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static?

---
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/drm_memory.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_memory.c +1 -0
index 0bec6dbb0142..2d8615baeadc 100644
@@ -41,6 +41,7 @@
 
 #include <drm/drm_agpsupport.h>
 #include <drm/drm_device.h>
+#include <drm/drm_cache.h>
 
 #include "drm_legacy.h"
 
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 5 lines · Ben Dooks (Codethink)

The drm_need_swiotlb is declared in <drm/drm_cache.h> which should be included in drivers/gpu/drm/drm_memory.c to silence the following warning:

drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static?

IIRC I silenced that already, so you're probably working on some old tree. For the latest stuff use:

git://anongit.freedesktop.org/drm-tip drm-tip

Quoted 32 lines

---
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]

---
 drivers/gpu/drm/drm_memory.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_memory.c +1 -0
index 0bec6dbb0142..2d8615baeadc 100644
@@ -41,6 +41,7 @@
 
 #include <drm/drm_agpsupport.h>
 #include <drm/drm_device.h>
+#include <drm/drm_cache.h>
 
 #include "drm_legacy.h"
 
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel