drm/arm: make undeclared items static
Subsystems (3)
PATCH 1/1 drm/arm: make undeclared items static
Make the following items static to avoid clashes with other parts of the kernel (dev_attr_core_id) or just silence the following sparse warning:
drivers/gpu/drm/arm/malidp_drv.c:371:24: warning: symbol 'malidp_fb_create' was not declared. Should it be static? drivers/gpu/drm/arm/malidp_drv.c:494:6: warning: symbol 'malidp_error_stats_dump' was not declared. Should it be static? drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was not declared. Should it be static?
---
Cc: Liviu Dudau <[email protected]>
Cc: Brian Starkey <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
.. (open list)
--- drivers/gpu/drm/arm/malidp_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/arm/malidp_drv.c +5 -5
@@ -368,7 +368,7 @@ malidp_verify_afbc_framebuffer(struct drm_device *dev, struct drm_file *file,return false; } -struct drm_framebuffer * +static struct drm_framebuffer *malidp_fb_create (struct drm_device *dev,struct drm_file *file,const struct drm_mode_fb_cmd2 *mode_cmd) {
@@ -491,9 +491,9 @@ void malidp_error(struct malidp_drm *malidp,spin_unlock_irqrestore (&malidp->errors_lock, irqflags); } -void malidp_error_stats_dump (const char *prefix, -struct malidp_error_stats error_stats, -struct seq_file *m) +static void malidp_error_stats_dump (const char *prefix, +struct malidp_error_stats error_stats, +struct seq_file *m) {seq_printf (m,"[%s] num_errors : %d\n" , prefix, error_stats.num_errors);
@@ -665,7 +665,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr,return snprintf (buf,PAGE_SIZE ,"%08x\n" , malidp->core_id); } -DEVICE_ATTR_RO (core_id); +static DEVICE_ATTR_RO (core_id);static int malidp_init_sysfs (struct device *dev) {
Signature · 1 line
2.23.0
Quoted 9 lines · Ben Dooks (Codethink)
Make the following items static to avoid clashes with other parts of the kernel (
dev_attr_core_id) or just silence the following sparse warning:
drivers/gpu/drm/arm/malidp_drv.c:371:24: warning: symbol 'malidp_fb_create' was not declared. Should it be static?drivers/gpu/drm/arm/malidp_drv.c:494:6: warning: symbol 'malidp_error_stats_dump' was not declared. Should it be static?drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>
Thanks for the patch! As a side note: the dim tool that we use in the DRM subsystem flags your S-o-b as being different from author, due to "(Codethink)" addition in the email name.
Best regards,
Liviu
Quoted 51 lines
---
Cc: Liviu Dudau <[email protected]>
Cc: Brian Starkey <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
.. (open list)--- drivers/gpu/drm/arm/malidp_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/arm/malidp_drv.c +5
-5@@ -368,7 +368,7 @@ malidp_verify_afbc_framebuffer(struct drm_device *dev, struct drm_file *file,return false; } -struct drm_framebuffer * +static struct drm_framebuffer *malidp_fb_create (struct drm_device *dev,struct drm_file *file,const struct drm_mode_fb_cmd2 *mode_cmd) {@@ -491,9 +491,9 @@ void malidp_error(struct malidp_drm *malidp,spin_unlock_irqrestore (&malidp->errors_lock, irqflags); } -void malidp_error_stats_dump (const char *prefix, -struct malidp_error_stats error_stats, -struct seq_file *m) +static void malidp_error_stats_dump (const char *prefix, +struct malidp_error_stats error_stats, +struct seq_file *m) {seq_printf (m,"[%s] num_errors : %d\n" , prefix, error_stats.num_errors);@@ -665,7 +665,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr,return snprintf (buf,PAGE_SIZE ,"%08x\n" , malidp->core_id); } -DEVICE_ATTR_RO (core_id); +static DEVICE_ATTR_RO (core_id);static int malidp_init_sysfs (struct device *dev) {Signature · 1 line
2.23.0
Signature · 12 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel