Skip to contentSkip to conversation

pcmcia: include cs_internal.h for missing declarations

PATCH Applied Ben Dooks (Codethink) 2 participants 2 messages Oct 17, 2019 – Nov 21, 2019 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcmcia: include cs_internal.h for missing declarations

Include cs_internal.h (and pcmcia/cistpl.h as required by cs_internal.h) for the declearions of cb_alloc and cb_free to silence the following sparse warnings;

drivers/pcmcia/cardbus.c:64:11: warning: symbol 'cb_alloc' was not declared. Should it be static? drivers/pcmcia/cardbus.c:103:6: warning: symbol 'cb_free' was not declared. Should it be static?

---
Cc: Dominik Brodowski <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]

---
 drivers/pcmcia/cardbus.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/pcmcia/cardbus.c +2 -0
index c502dfbf66e3..45c8252c8edc 100644
@@ -22,7 +22,9 @@
 #include <linux/pci.h>
 
 #include <pcmcia/ss.h>
+#include <pcmcia/cistpl.h>
 
+#include "cs_internal.h"
 
 static void cardbus_config_irq_and_cls(struct pci_bus *bus, int irq)
 {
Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Ben Dooks (Codethink)

Include cs_internal.h (and pcmcia/cistpl.h as required by cs_internal.h) for the declearions of cb_alloc and cb_free to silence the following sparse warnings;

drivers/pcmcia/cardbus.c:64:11: warning: symbol 'cb_alloc' was not declared. Should it be static? drivers/pcmcia/cardbus.c:103:6: warning: symbol 'cb_free' was not declared. Should it be static?

Applied to the pcmcia tree (but with ":" instead of ";")

Thanks,
Dominik