soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
PATCH 1/1 soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg declaration to fix the following sparse warning:
drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol 'owl_sps_set_pg' was not declared. Should it be static?
---
Cc: "Andreas Färber" <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]
--- drivers/soc/actions/owl-sps-helper.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/soc/actions/owl-sps-helper.c +2 -0
@@ -11,6 +11,8 @@#include <linux/delay.h> #include <linux/io.h> +#include <linux/soc/actions/owl-sps.h> +#define OWL_SPS_PG_CTL 0x0int owl_sps_set_pg (void __iomem *base,u32 pwr_mask,u32 ack_mask,bool enable)
Signature · 7 lines
2.23.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Andreas Färber
maintainerHello Ben,
Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks (Codethink):
Quoted 21 lines
Include <
linux/soc/actions/owl-sps.h> forowl_sps_set_pgdeclaration to fix the following sparse warning:
drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol 'owl_sps_set_pg' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: "Andreas Färber" <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]--- drivers/soc/actions/owl-sps-helper.c | 2 ++ 1 file changed, 2 insertions(+)drivers/soc/actions/owl-sps-helper.c +0
-0
drivers/soc/actions/owl-sps-helper.c line 14
Quoted 4 lines
drivers/soc/actions/owl-sps-helper.c +1
-0@@ -11,6 +11,8 @@#include <linux/delay.h> #include <linux/io.h> +#include <linux/soc/actions/owl-sps.h>
Any reason for the white line before?
Also, could you explain why we did not get that warning during earlier builds? Should there be a Fixes?
Thanks,
Andreas
Quoted 5 lines
drivers/soc/actions/owl-sps-helper.c +1
-0+#define OWL_SPS_PG_CTL 0x0 int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask,bool enable)
Signature · 10 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 28 lines · Andreas Färber
Hello Ben,
Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks (Codethink):
Quoted 24 lines
Include <
linux/soc/actions/owl-sps.h> forowl_sps_set_pgdeclaration to fix the following sparse warning:
drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol 'owl_sps_set_pg' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: "Andreas Färber" <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]--- drivers/soc/actions/owl-sps-helper.c | 2 ++ 1 file changed, 2 insertions(+)drivers/soc/actions/owl-sps-helper.c +0
-0@@ -11,6 +11,8 @@#include <linux/delay.h> #include <linux/io.h>
Quoted 3 lines
drivers/soc/actions/owl-sps-helper.c line 14
Quoted 1 line
drivers/soc/actions/owl-sps-helper.c +1
-0+#include <linux/soc/actions/owl-sps.h> Any reason for the white line before?
I added it as some people tend to when moving onto a new group of includes in a different directory.
Quoted 2 lines
Also, could you explain why we did not get that warning during earlier builds? Should there be a Fixes?
It is a warning from sparse, so not run as standard when building.
I've not been putting fixes on as it isn't really a bug.
Quoted 8 lines
Thanks,
AndreasQuoted 5 lines
drivers/soc/actions/owl-sps-helper.c +1
-0+#define OWL_SPS_PG_CTL 0x0 int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask,bool enable)
Signature · 9 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel