Skip to contentSkip to conversation

BZ#1751431:guest-get-memory-block-info is not supported

PATCH In review Basil Salman 2 participants 4 messages Oct 17, 2019 – Oct 31, 2019

lore
Share & tools
lore
#0 lore raw

cover BZ#1751431:guest-get-memory-block-info is not supported

From: Basil Salman <[email protected]>

"guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs.

"guest-get-memory-block-info" command was added to blacklist.

Basil Salman (1):
qga: Add "guest-get-memory-block-info" to blacklist

 qga/commands-posix.c | 3 ++-
 qga/commands-win32.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.2
#1 lore raw

PATCH 1/1 qga: Add "guest-get-memory-block-info" to blacklist

From: Basil Salman <[email protected]>

Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases.

Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431

---
 qga/commands-posix.c | 3 ++-
 qga/commands-win32.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
qga/commands-posix.c +2 -1
index dfc05f5b8a..1c1a165dae 100644
@@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist)
             "guest-suspend-hybrid", "guest-network-get-interfaces",
             "guest-get-vcpus", "guest-set-vcpus",
             "guest-get-memory-blocks", "guest-set-memory-blocks",
-            "guest-get-memory-block-size", NULL};
+            "guest-get-memory-block-size", "guest-get-memory-block-info",
+            NULL};
         char **p = (char **)list;
 
         while (*p) {
qga/commands-win32.c +1 -1
index 6b67f16faf..1c9ec9c094 100644
@@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
         "guest-suspend-hybrid",
         "guest-set-vcpus",
         "guest-get-memory-blocks", "guest-set-memory-blocks",
-        "guest-get-memory-block-size",
+        "guest-get-memory-block-size", "guest-get-memory-block-info",
         NULL};
     char **p = (char **)list_unsupported;
 
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist

Quoted 11 lines · Basil Salman

From: Basil Salman <[email protected]>

Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases.

Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431

Quoted 36 lines
---
 qga/commands-posix.c | 3 ++-
 qga/commands-win32.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
qga/commands-posix.c +2 -1
index dfc05f5b8a..1c1a165dae 100644
@@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist)
             "guest-suspend-hybrid", "guest-network-get-interfaces",
             "guest-get-vcpus", "guest-set-vcpus",
             "guest-get-memory-blocks", "guest-set-memory-blocks",
-            "guest-get-memory-block-size", NULL};
+            "guest-get-memory-block-size", "guest-get-memory-block-info",
+            NULL};
         char **p = (char **)list;
 
         while (*p) {
qga/commands-win32.c +1 -2
index 6b67f16faf..1c9ec9c094 100644
@@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
         "guest-suspend-hybrid",
         "guest-set-vcpus",
         "guest-get-memory-blocks", "guest-set-memory-blocks",
-        "guest-get-memory-block-size",
+        "guest-get-memory-block-size", "guest-get-memory-block-info",
         NULL};
     char **p = (char **)list_unsupported;
 
--

2.17.2

Signature · 1 line
Marc-André Lureau
#3 lore raw
In reply to Basil Salman

PING

Quoted 18 lines · Basil Salman

From: Basil Salman <[email protected]>

"guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs.

"guest-get-memory-block-info" command was added to blacklist.

Basil Salman (1):
qga: Add "guest-get-memory-block-info" to blacklist

 qga/commands-posix.c | 3 ++-
 qga/commands-win32.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

--
2.17.2