BZ#1751431:guest-get-memory-block-info is not supported
cover BZ#1751431:guest-get-memory-block-info is not supported
From: Basil Salman <[email protected]>
"guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs.
"guest-get-memory-block-info" command was added to blacklist.
Basil Salman (1):
qga: Add "guest-get-memory-block-info" to blacklist
qga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.2
PATCH 1/1 qga: Add "guest-get-memory-block-info" to blacklist
From: Basil Salman <[email protected]>
Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases.
Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431
--- qga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
qga/commands-posix.c +2 -1
@@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist)"guest-suspend-hybrid" ,"guest-network-get-interfaces" ,"guest-get-vcpus" ,"guest-set-vcpus" ,"guest-get-memory-blocks" ,"guest-set-memory-blocks" , - "guest-get-memory-block-size", NULL}; +"guest-get-memory-block-size" ,"guest-get-memory-block-info" , + NULL};char **p = (char **)list;while (*p) {
qga/commands-win32.c +1 -1
@@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist)"guest-suspend-hybrid" ,"guest-set-vcpus" ,"guest-get-memory-blocks" ,"guest-set-memory-blocks" , -"guest-get-memory-block-size" , +"guest-get-memory-block-size" ,"guest-get-memory-block-info" , NULL};char **p = (char **)list_unsupported;
Signature · 1 line
2.17.2
Re: [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist
Quoted 11 lines · Basil Salman
From: Basil Salman <[email protected]>
Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases.
Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431Signed-off-by Basil Salman <[email protected]>
Quoted 36 lines
--- qga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)qga/commands-posix.c +2
-1@@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist)"guest-suspend-hybrid" ,"guest-network-get-interfaces" ,"guest-get-vcpus" ,"guest-set-vcpus" ,"guest-get-memory-blocks" ,"guest-set-memory-blocks" , - "guest-get-memory-block-size", NULL}; +"guest-get-memory-block-size" ,"guest-get-memory-block-info" , + NULL};char **p = (char **)list;while (*p) {qga/commands-win32.c +1
-2@@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist)"guest-suspend-hybrid" ,"guest-set-vcpus" ,"guest-get-memory-blocks" ,"guest-set-memory-blocks" , -"guest-get-memory-block-size" , +"guest-get-memory-block-size" ,"guest-get-memory-block-info" , NULL};char **p = (char **)list_unsupported; --2.17.2
Signature · 1 line
Marc-André Lureau
PING
Quoted 18 lines · Basil Salman
From: Basil Salman <[email protected]>
"guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs.
"guest-get-memory-block-info" command was added to blacklist.
Basil Salman (1):
qga: Add "guest-get-memory-block-info" to blacklistqga/commands-posix.c | 3 ++- qga/commands-win32.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)--
2.17.2