Skip to contentSkip to conversation

iwlwifi: Don't IWL_WARN on FW reconfiguration

PATCH In review Chris Down 2 participants 4 messages Oct 17, 2019 – Jul 13, 2020 Intel wireless wifi link (iwlwifi)

lore
Share & tools
lore

Chris Down

author
#0 lore raw

PATCH 1/1 iwlwifi: Don't IWL_WARN on FW reconfiguration

IWL_WARN seems excessive here since this can happen during normal operation. Every time I connect to a new network with 8086:24fd I get this as KERN_WARNING on the console, which mildly distracts from other more pressing messages. For example:

% sudo journalctl _TRANSPORT=kernel | grep -c 'FW already configured' 403

---
 drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/fw/dbg.c +1 -1
index 5c8602de9168..ac7ecb76d964 100644
@@ -2264,7 +2264,7 @@ int iwl_fw_start_dbg_conf(struct iwl_fw_runtime *fwrt, u8 conf_id)
 		return -EINVAL;
 
 	if (fwrt->dump.conf != FW_DBG_INVALID)
-		IWL_WARN(fwrt, "FW already configured (%d) - re-configuring\n",
+		IWL_INFO(fwrt, "FW already configured (%d) - re-configuring\n",
 			 fwrt->dump.conf);
 
 	/* Send all HCMDs for configuring the FW debug */
Signature · 1 line
2.23.0
author
#1 lore raw

To be more clear in case this actually is representative of a real problem (although I doubt it since this seems present on every device like this I encountered), it's always FW_DBG_START_FROM_ALIVE:

% sudo journalctl _TRANSPORT=kernel -o cat | grep 'FW already configured' | sort | uniq -c

       403 iwlwifi 0000:3a:00.0: FW already configured (0) - re-configuring
author
#2 lore raw

Just to check in again since this is still happening: is this expected?

I expect that if this is IWL_WARN, it should indicate some unexpected or non-ideal state, but the card seems to operate just fine afterwards.

#3 lore raw
Quoted 4 lines · Chris Down

Just to check in again since this is still happening: is this expected?

I expect that if this is IWL_WARN, it should indicate some unexpected or non-ideal state, but the card seems to operate just fine afterwards.

I'm confused too, cause I'm seeing this on an AC 8260 now, whereas in the past there wasn't such a message. Is this something the user should be aware of? If not, I'm with Chris that this should be silenced.

Signature · 2 lines
Regards,
  Johannes Hirte