drm/i915/perf: Add helper macros for comparing with whitelisted registers
Subsystems (2)
PATCH v2 1/3 drm/i915/perf: Add helper macros for comparing with whitelisted registers
Add helper macros for range and equality comparisons and use them to check with whitelisted registers in oa configurations.
--- drivers/gpu/drm/i915/i915_perf.c | 54 +++++++++++++++++--------------- 1 file changed, 28 insertions(+), 26 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +28 -26
@@ -3514,56 +3514,58 @@ static bool gen8_is_valid_flex_addr(struct i915_perf *perf, u32 addr)return false; } +#define ADDR_IN_RANGE (addr, start, end) \ + ((addr) >= (start) && \ + (addr) <= (end)) + +#define REG_IN_RANGE (addr, start, end) \ + ((addr) >= i915_mmio_reg_offset(start) && \ + (addr) <= i915_mmio_reg_offset(end)) + +#define REG_EQUAL (addr, mmio) \ + ((addr) == i915_mmio_reg_offset(mmio)) +static bool gen7_is_valid_b_counter_addr (struct i915_perf *perf,u32 addr) { -return (addr >=i915_mmio_reg_offset (OASTARTTRIG1 ) && - addr <=i915_mmio_reg_offset (OASTARTTRIG8 )) || - (addr >=i915_mmio_reg_offset (OAREPORTTRIG1 ) && - addr <=i915_mmio_reg_offset (OAREPORTTRIG8 )) || - (addr >=i915_mmio_reg_offset (OACEC0_0 ) && - addr <=i915_mmio_reg_offset (OACEC7_1 )); +return REG_IN_RANGE (addr,OASTARTTRIG1 ,OASTARTTRIG8 ) || +REG_IN_RANGE (addr,OAREPORTTRIG1 ,OAREPORTTRIG8 ) || +REG_IN_RANGE (addr,OACEC0_0 ,OACEC7_1 ); }static bool gen7_is_valid_mux_addr (struct i915_perf *perf,u32 addr) { -return addr ==i915_mmio_reg_offset (HALF_SLICE_CHICKEN2 ) || - (addr >=i915_mmio_reg_offset (MICRO_BP0_0 ) && - addr <=i915_mmio_reg_offset (NOA_WRITE )) || - (addr >=i915_mmio_reg_offset (OA_PERFCNT1_LO ) && - addr <=i915_mmio_reg_offset (OA_PERFCNT2_HI )) || - (addr >=i915_mmio_reg_offset (OA_PERFMATRIX_LO ) && - addr <=i915_mmio_reg_offset (OA_PERFMATRIX_HI )); +return REG_EQUAL (addr,HALF_SLICE_CHICKEN2 ) || +REG_IN_RANGE (addr,MICRO_BP0_0 ,NOA_WRITE ) || +REG_IN_RANGE (addr,OA_PERFCNT1_LO ,OA_PERFCNT2_HI ) || +REG_IN_RANGE (addr,OA_PERFMATRIX_LO ,OA_PERFMATRIX_HI ); }static bool gen8_is_valid_mux_addr (struct i915_perf *perf,u32 addr) {return gen7_is_valid_mux_addr (perf, addr) || - addr ==i915_mmio_reg_offset (WAIT_FOR_RC6_EXIT ) || - (addr >=i915_mmio_reg_offset (RPM_CONFIG0 ) && - addr <=i915_mmio_reg_offset (NOA_CONFIG (8 ))); +REG_EQUAL (addr,WAIT_FOR_RC6_EXIT ) || +REG_IN_RANGE (addr,RPM_CONFIG0 ,NOA_CONFIG (8 )); }static bool gen10_is_valid_mux_addr (struct i915_perf *perf,u32 addr) {return gen8_is_valid_mux_addr (perf, addr) || - addr ==i915_mmio_reg_offset (GEN10_NOA_WRITE_HIGH ) || - (addr >=i915_mmio_reg_offset (OA_PERFCNT3_LO ) && - addr <=i915_mmio_reg_offset (OA_PERFCNT4_HI )); +REG_EQUAL (addr,GEN10_NOA_WRITE_HIGH ) || +REG_IN_RANGE (addr,OA_PERFCNT3_LO ,OA_PERFCNT4_HI ); }static bool hsw_is_valid_mux_addr (struct i915_perf *perf,u32 addr) {return gen7_is_valid_mux_addr (perf, addr) || - (addr >=0x25100 && addr <=0x2FF90 ) || - (addr >=i915_mmio_reg_offset (HSW_MBVID2_NOA0 ) && - addr <=i915_mmio_reg_offset (HSW_MBVID2_NOA9 )) || - addr ==i915_mmio_reg_offset (HSW_MBVID2_MISR0 ); +ADDR_IN_RANGE (addr,0x25100 ,0x2FF90 ) || +REG_IN_RANGE (addr,HSW_MBVID2_NOA0 ,HSW_MBVID2_NOA9 ) || +REG_EQUAL (addr,HSW_MBVID2_MISR0 ); }static bool chv_is_valid_mux_addr (struct i915_perf *perf,u32 addr) {return gen7_is_valid_mux_addr (perf, addr) || - (addr >=0x182300 && addr <=0x1823A4 ); +ADDR_IN_RANGE (addr,0x182300 ,0x1823A4 ); }static u32 mask_reg_value (u32 reg,u32 val)
@@ -3572,14 +3574,14 @@ static u32 mask_reg_value(u32 reg, u32 val)* WaDisableSTUnitPowerOptimization workaround. Make sure the value * programmed by userspace doesn't change this. */ -if (i915_mmio_reg_offset (HALF_SLICE_CHICKEN2 ) == reg) +if (REG_EQUAL (reg,HALF_SLICE_CHICKEN2 )) val = val & ~_MASKED_BIT_ENABLE (GEN8_ST_PO_DISABLE );/* WAIT_FOR_RC6_EXIT has only one bit fullfilling the function * indicated by its name and a bunch of selection fields used by OA * configs. */ -if (i915_mmio_reg_offset (WAIT_FOR_RC6_EXIT ) == reg) +if (REG_EQUAL (reg,WAIT_FOR_RC6_EXIT )) val = val & ~_MASKED_BIT_ENABLE (HSW_WAIT_FOR_RC6_EXIT_ENABLE );return val;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/3 drm/i915/perf: enable OAR context save/restore of performance counters
From: Lionel Landwerlin <[email protected]>
We want this so we can preempt performance queries and keep the system responsive even when long running queries are ongoing. We avoid doing it for all contexts.
v2: use LRI to modify context control (Chris)
v3: use MASKED_FIELD to program just the masked bits (Chris)
v4: reuse request created during emit_oa_config (Lionel)
--- drivers/gpu/drm/i915/gt/intel_lrc.h | 1 + drivers/gpu/drm/i915/i915_perf.c | 35 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_lrc.h +1 -0
@@ -43,6 +43,7 @@ struct intel_engine_cs;#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT (1 << 0)#define CTX_CTRL_RS_CTX_ENABLE (1 << 1)#define CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT (1 << 2) +#define GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE (1 << 8)#define RING_CONTEXT_STATUS_PTR (base) _MMIO((base) + 0x3a0)#define RING_EXECLIST_SQ_CONTENTS (base) _MMIO((base) + 0x510)#define RING_EXECLIST_CONTROL (base) _MMIO((base) + 0x550)
drivers/gpu/drm/i915/i915_perf.c +34 -1
@@ -1862,14 +1862,36 @@ get_oa_vma(struct i915_perf_stream *stream, struct i915_oa_config *oa_config)return i915_vma_get (oa_bo->vma); } +static int gen12_emit_oar_config (struct i915_request *rq, +struct intel_context *ce, +bool enable) +{ +u32 *cs; + + cs =intel_ring_begin (rq,4 ); +if (IS_ERR (cs)) +return PTR_ERR (cs); + + *cs++ =MI_LOAD_REGISTER_IMM (1 ); + *cs++ =i915_mmio_reg_offset (RING_CONTEXT_CONTROL (ce->engine->mmio_base)); + *cs++ =_MASKED_FIELD (GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE , + enable ?GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE :0 ); + *cs++ =MI_NOOP ; + +intel_ring_advance (rq, cs); + +return 0 ; +} +static int emit_oa_config (struct i915_perf_stream *stream,struct intel_context *ce) { +struct i915_oa_config *oa_config = stream->oa_config;struct i915_request *rq;struct i915_vma *vma;int err; - vma =get_oa_vma (stream, stream->oa_config); + vma =get_oa_vma (stream, oa_config);if (IS_ERR (vma))return PTR_ERR (vma);
@@ -1891,6 +1913,17 @@ static int emit_oa_config(struct i915_perf_stream *stream,if (err) goto err_add_request; +/* +* For Gen12, performance counters are context saved/restored. +* Only enable it for the context that requested this. +*/ +if (ce == stream->pinned_ctx &&IS_GEN (stream->perf->i915,12 )) { + err =gen12_emit_oar_config (rq, ce, oa_config !=NULL ); +if (err) + goto err_add_request; + + } + err = rq->engine->emit_bb_start (rq, vma->node.start,0 ,I915_DISPATCH_SECURE );
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 2/3] drm/i915/perf: enable OAR context save/restore of performance counters
Quoted 6 lines · Umesh Nerlige Ramappa
From: Lionel Landwerlin <[email protected]>
We want this so we can preempt performance queries and keep the system responsive even when long running queries are ongoing. We avoid doing it for all contexts.
Quoted 6 lines
v2: use LRI to modify context control (Chris)
v3: useMASKED_FIELDto program just the masked bits (Chris)
v4: reuse request created duringemit_oa_config(Lionel)Signed-off-by Lionel Landwerlin <[email protected]>Signed-off-by Umesh Nerlige Ramappa <[email protected]>
Looks good :
Quoted 67 lines
--- drivers/gpu/drm/i915/gt/intel_lrc.h | 1 + drivers/gpu/drm/i915/i915_perf.c | 35 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_lrc.h +1
-0@@ -43,6 +43,7 @@ struct intel_engine_cs;#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT (1 << 0)#define CTX_CTRL_RS_CTX_ENABLE (1 << 1)#define CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT (1 << 2) +#define GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE (1 << 8)#define RING_CONTEXT_STATUS_PTR (base) _MMIO((base) + 0x3a0)#define RING_EXECLIST_SQ_CONTENTS (base) _MMIO((base) + 0x510)#define RING_EXECLIST_CONTROL (base) _MMIO((base) + 0x550)drivers/gpu/drm/i915/i915_perf.c +27
-1@@ -1862,14 +1862,36 @@ get_oa_vma(struct i915_perf_stream *stream, struct i915_oa_config *oa_config)return i915_vma_get (oa_bo->vma); } +static int gen12_emit_oar_config (struct i915_request *rq, +struct intel_context *ce, +bool enable) +{ +u32 *cs; + + cs =intel_ring_begin (rq,4 ); +if (IS_ERR (cs)) +return PTR_ERR (cs); + + *cs++ =MI_LOAD_REGISTER_IMM (1 ); + *cs++ =i915_mmio_reg_offset (RING_CONTEXT_CONTROL (ce->engine->mmio_base)); + *cs++ =_MASKED_FIELD (GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE , + enable ?GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE :0 ); + *cs++ =MI_NOOP ; + +intel_ring_advance (rq, cs); + +return 0 ; +} +static int emit_oa_config (struct i915_perf_stream *stream,struct intel_context *ce) { +struct i915_oa_config *oa_config = stream->oa_config;struct i915_request *rq;struct i915_vma *vma;int err; - vma =get_oa_vma (stream, stream->oa_config); + vma =get_oa_vma (stream, oa_config);if (IS_ERR (vma))return PTR_ERR (vma);@@ -1891,6 +1913,17 @@ static int emit_oa_config(struct i915_perf_stream *stream,if (err) goto err_add_request; +/* +* For Gen12, performance counters are context saved/restored. +* Only enable it for the context that requested this. +*/
drivers/gpu/drm/i915/i915_perf.c static int emit_oa_config(struct i915_perf_stream *stream, · line 1929
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +7
-0+if (ce == stream->pinned_ctx &&IS_GEN (stream->perf->i915,12 )) { + err =gen12_emit_oar_config (rq, ce, oa_config !=NULL ); +if (err) + goto err_add_request; + + } + err = rq->engine->emit_bb_start (rq, vma->node.start,0 ,I915_DISPATCH_SECURE );
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 2/3] drm/i915/perf: enable OAR context save/restore of performance counters
In reply to Umesh Nerlige RamappaQuoting Umesh Nerlige Ramappa (2019-10-18 01:50:27)
Quoted 75 lines
From: Lionel Landwerlin <[email protected]>
We want this so we can preempt performance queries and keep the system responsive even when long running queries are ongoing. We avoid doing it for all contexts.
v2: use LRI to modify context control (Chris)
v3: useMASKED_FIELDto program just the masked bits (Chris)
v4: reuse request created duringemit_oa_config(Lionel)Signed-off-by Lionel Landwerlin <[email protected]>Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_lrc.h | 1 + drivers/gpu/drm/i915/i915_perf.c | 35 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_lrc.h +1
-0@@ -43,6 +43,7 @@ struct intel_engine_cs;#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT (1 << 0)#define CTX_CTRL_RS_CTX_ENABLE (1 << 1)#define CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT (1 << 2) +#define GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE (1 << 8)#define RING_CONTEXT_STATUS_PTR (base) _MMIO((base) + 0x3a0)#define RING_EXECLIST_SQ_CONTENTS (base) _MMIO((base) + 0x510)#define RING_EXECLIST_CONTROL (base) _MMIO((base) + 0x550)drivers/gpu/drm/i915/i915_perf.c +23
-1@@ -1862,14 +1862,36 @@ get_oa_vma(struct i915_perf_stream *stream, struct i915_oa_config *oa_config)return i915_vma_get (oa_bo->vma); } +static int gen12_emit_oar_config (struct i915_request *rq, +struct intel_context *ce, +bool enable) +{ +u32 *cs; + + cs =intel_ring_begin (rq,4 ); +if (IS_ERR (cs)) +return PTR_ERR (cs); + + *cs++ =MI_LOAD_REGISTER_IMM (1 ); + *cs++ =i915_mmio_reg_offset (RING_CONTEXT_CONTROL (ce->engine->mmio_base)); + *cs++ =_MASKED_FIELD (GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE , + enable ?GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE :0 ); + *cs++ =MI_NOOP ; + +intel_ring_advance (rq, cs); + +return 0 ; +} +static int emit_oa_config (struct i915_perf_stream *stream,struct intel_context *ce) { +struct i915_oa_config *oa_config = stream->oa_config;struct i915_request *rq;struct i915_vma *vma;int err; - vma =get_oa_vma (stream, stream->oa_config); + vma =get_oa_vma (stream, oa_config);if (IS_ERR (vma))return PTR_ERR (vma);@@ -1891,6 +1913,17 @@ static int emit_oa_config(struct i915_perf_stream *stream,if (err) goto err_add_request;
drivers/gpu/drm/i915/i915_perf.c static int emit_oa_config(struct i915_perf_stream *stream, · line 1925
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +10
-0+/* +* For Gen12, performance counters are context saved/restored. +* Only enable it for the context that requested this. +*/ +if (ce == stream->pinned_ctx &&IS_GEN (stream->perf->i915,12 )) { + err =gen12_emit_oar_config (rq, ce, oa_config !=NULL ); +if (err) + goto err_add_request; + + }
Do we need to do emit_oa_config(stream, NULL) ingen8_disable_metric_set()?
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 2/3] drm/i915/perf: enable OAR context save/restore of performance counters
Quoted 76 lines · Chris Wilson
Quoting Umesh Nerlige Ramappa (2019-10-18 01:50:27)
Quoted 75 lines
From: Lionel Landwerlin <[email protected]>
We want this so we can preempt performance queries and keep the system responsive even when long running queries are ongoing. We avoid doing it for all contexts.
v2: use LRI to modify context control (Chris)
v3: useMASKED_FIELDto program just the masked bits (Chris)
v4: reuse request created duringemit_oa_config(Lionel)Signed-off-by Lionel Landwerlin <[email protected]>Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_lrc.h | 1 + drivers/gpu/drm/i915/i915_perf.c | 35 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_lrc.h +1
-0@@ -43,6 +43,7 @@ struct intel_engine_cs;#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT (1 << 0)#define CTX_CTRL_RS_CTX_ENABLE (1 << 1)#define CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT (1 << 2) +#define GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE (1 << 8)#define RING_CONTEXT_STATUS_PTR (base) _MMIO((base) + 0x3a0)#define RING_EXECLIST_SQ_CONTENTS (base) _MMIO((base) + 0x510)#define RING_EXECLIST_CONTROL (base) _MMIO((base) + 0x550)drivers/gpu/drm/i915/i915_perf.c +23
-1@@ -1862,14 +1862,36 @@ get_oa_vma(struct i915_perf_stream *stream, struct i915_oa_config *oa_config)return i915_vma_get (oa_bo->vma); } +static int gen12_emit_oar_config (struct i915_request *rq, +struct intel_context *ce, +bool enable) +{ +u32 *cs; + + cs =intel_ring_begin (rq,4 ); +if (IS_ERR (cs)) +return PTR_ERR (cs); + + *cs++ =MI_LOAD_REGISTER_IMM (1 ); + *cs++ =i915_mmio_reg_offset (RING_CONTEXT_CONTROL (ce->engine->mmio_base)); + *cs++ =_MASKED_FIELD (GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE , + enable ?GEN12_CTX_CTRL_OAR_CONTEXT_ENABLE :0 ); + *cs++ =MI_NOOP ; + +intel_ring_advance (rq, cs); + +return 0 ; +} +static int emit_oa_config (struct i915_perf_stream *stream,struct intel_context *ce) { +struct i915_oa_config *oa_config = stream->oa_config;struct i915_request *rq;struct i915_vma *vma;int err; - vma =get_oa_vma (stream, stream->oa_config); + vma =get_oa_vma (stream, oa_config);if (IS_ERR (vma))return PTR_ERR (vma);@@ -1891,6 +1913,17 @@ static int emit_oa_config(struct i915_perf_stream *stream,if (err) goto err_add_request;
Quoted 14 lines
drivers/gpu/drm/i915/i915_perf.c static int emit_oa_config(struct i915_perf_stream *stream, · line 1925
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +10
-0+/* +* For Gen12, performance counters are context saved/restored. +* Only enable it for the context that requested this. +*/ +if (ce == stream->pinned_ctx &&IS_GEN (stream->perf->i915,12 )) { + err =gen12_emit_oar_config (rq, ce, oa_config !=NULL ); +if (err) + goto err_add_request; + + }Do we need to do
emit_oa_config(stream, NULL)ingen8_disable_metric_set()?
-Chris
Oh crap... I must have pointed to the wrong function then...
I thought this was called from enable/disable_metric_set().
I guess the best thing would be to call this from gen12_enable/disable_metric_set().
But then we would need to create a request for the pinned_ctx.
Sorry :(
-Lionel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/3 drm/i915/tgl: Add perf support on TGL
In reply to Umesh Nerlige RamappaFrom: Lionel Landwerlin <[email protected]>
The design of the OA unit has been split into several units. We now have a global unit (OAG) and a render specific unit (OAR). This leads to some changes on how we program things. Some details :
OAR:
- has its own set of counter registers, they are per-context saved/restored
- counters are not written to the circular OA buffer
- a snapshot of the counters can be acquired with MI_RECORD_PERF_COUNT, or a single counter can be read with MI_STORE_REGISTER_MEM.
OAG:
- has global counters that increment across context switches
- counters are written into the circular OA buffer (if requested)
v2: Fix checkpatch warnings on code style (Lucas)
v3: (Umesh)
- Update register from which tail, status and head are read
- Update logic to sample context reports
- Update whitelist mux and b counter regs
v4: Fix a bug when updating context image for new contexts (Umesh)
BSpec: 28727, 30021
--- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_perf.c | 292 +++++++++++++++++++++++--- drivers/gpu/drm/i915/i915_reg.h | 103 +++++++++ drivers/gpu/drm/i915/oa/i915_oa_tgl.c | 121 +++++++++++ drivers/gpu/drm/i915/oa/i915_oa_tgl.h | 16 ++ 5 files changed, 500 insertions(+), 35 deletions(-) create mode 100644 drivers/gpu/drm/i915/oa/i915_oa_tgl.c create mode 100644 drivers/gpu/drm/i915/oa/i915_oa_tgl.h
drivers/gpu/drm/i915/Makefile +2 -1
@@ -242,7 +242,8 @@ i915-y += \ oa/i915_oa_cflgt2.o \ oa/i915_oa_cflgt3.o \ oa/i915_oa_cnl.o \ - oa/i915_oa_icl.o + oa/i915_oa_icl.o \ + oa/i915_oa_tgl.o i915-y += i915_perf.o # Post-mortem debug and GPU hang state capture
drivers/gpu/drm/i915/i915_perf.c +258 -34
509 lines not on this page · raw message
drivers/gpu/drm/i915/i915_reg.h +103 -0
133 lines not on this page · raw message
drivers/gpu/drm/i915/oa/i915_oa_tgl.c new file +121 -0
121 lines not on this page · raw message
drivers/gpu/drm/i915/oa/i915_oa_tgl.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2018 Intel Corporation +* +* Autogenerated file by GPU Top : https://github.com/rib/gputop +* DO NOT EDIT manually! +*/ + +#ifndef __I915_OA_TGL_H__ +#define __I915_OA_TGL_H__ + +struct drm_i915_private ; + +void i915_perf_load_test_config_tgl (struct drm_i915_private *dev_priv); + +#endif
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
URL : https://patchwork.freedesktop.org/series/68180/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 8537fc751bda drm/i915/perf: Add helper macros for comparing with whitelisted registers -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_perf.c:3517: +#define ADDR_IN_RANGE(addr, start, end) \ + ((addr) >= (start) && \ + (addr) <= (end))
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/i915_perf.c:3521:
+#define REG_IN_RANGE(addr, start, end) \
+ ((addr) >= i915_mmio_reg_offset(start) && \
+ (addr) <= i915_mmio_reg_offset(end))
total: 0 errors, 0 warnings, 2 checks, 98 lines checked6dd750d75570 drm/i915/perf: enable OAR context save/restore of performance counters -:81: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "oa_config" #81: FILE: drivers/gpu/drm/i915/i915_perf.c:1921:
+ err = gen12_emit_oar_config(rq, ce, oa_config != NULL);
-:85: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #85: FILE: drivers/gpu/drm/i915/i915_perf.c:1925:
+
+ }
total: 0 errors, 0 warnings, 2 checks, 61 lines checkedd6c3a1a90470 drm/i915/tgl: Add perf support on TGL
-:737: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #737:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 788 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
URL : https://patchwork.freedesktop.org/series/68180/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/perf: Add helper macros for comparing with whitelisted registers Okay!
Commit: drm/i915/perf: enable OAR context save/restore of performance counters Okay!
Commit: drm/i915/tgl: Add perf support on TGL +drivers/gpu/drm/i915/i915_perf.c:2441:85: warning: dubious: x | !y
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [v2,1/3] drm/i915/perf: Add helper macros for comparing with whitelisted registers
URL : https://patchwork.freedesktop.org/series/68180/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7125 -> Patchwork_14871
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14871 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_14871, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14871:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_execlists:
- fi-glk-dsi: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-glk-dsi/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-glk-dsi/igt@i915_selftest@live_execlists.html
#### Warnings ####
* igt@i915_selftest@live_execlists:
- fi-icl-u2: [INCOMPLETE][3] ([fdo#107713]) -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-icl-u2/igt@i915_selftest@live_execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-icl-u2/igt@i915_selftest@live_execlists.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live_execlists:
- {fi-cml-s}: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-cml-s/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-cml-s/igt@i915_selftest@live_execlists.html
Known issues
------------
Here are the changes found in Patchwork_14871 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-read-write:
- fi-icl-u3: [PASS][7] -> [DMESG-WARN][8] ([fdo#107724])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: [DMESG-FAIL][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-apl-guc/igt@i915_selftest@live_execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-apl-guc/igt@i915_selftest@live_execlists.html
- fi-skl-6260u: [DMESG-FAIL][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-skl-6260u/igt@i915_selftest@live_execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-skl-6260u/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [INCOMPLETE][15] ([fdo#107713] / [fdo#108569]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
- {fi-icl-u4}: [INCOMPLETE][17] ([fdo#107713] / [fdo#108569]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][19] ([fdo#111407]) -> [FAIL][20] ([fdo#111045] / [fdo#111096])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7125/fi-kbl-7500u/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/fi-kbl-7500u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111608]: https://bugs.freedesktop.org/show_bug.cgi?id=111608
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7125 -> Patchwork_14871
CI-20190529: 20190529
CI_DRM_7125: f1ac92f5feb18678a3191a45be0ee4a4d255fc61 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5232: bb5735423eaf6fdbf6b2f94ef0b8520e74eab993 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14871: d6c3a1a90470ff7c6840d9e626451d76d5027329 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d6c3a1a90470 drm/i915/tgl: Add perf support on TGL6dd750d75570 drm/i915/perf: enable OAR context save/restore of performance counters 8537fc751bda drm/i915/perf: Add helper macros for comparing with whitelisted registers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14871/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx