Skip to contentSkip to conversation

board, zynqmp: Fix for wrong AMS setting by ROM

PATCH New Mike Looijmans 1 participant 1 message Oct 18, 2019 Arm/Zynq architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board, zynqmp: Fix for wrong AMS setting by ROM

A bug in the ZynqMP bootrom sets the PS_SYSMON_ANALOG_BUS register at 0xFFA50914 to the wrong value 0x3201. This causes the AMS to exchange the PS supply voltages 0 and 1. On Xilinx boards this is not noticable since these are tied together, it's only really noticable if banks 500 and 501 have different supplies. Xilinx' tech support reported this undocumented register to be the cause, and this patch applies a fix for all boards by programming the correct value.

---
 board/xilinx/zynqmp/zynqmp.c | 6 ++++++
 1 file changed, 6 insertions(+)
board/xilinx/zynqmp/zynqmp.c +6 -0
index b94936474d..8d926c803b 100644
@@ -326,6 +326,9 @@ int board_early_init_f(void)
 	return ret;
 }
 
+#define PS_SYSMON_ANALOG_BUS_VAL	0x3210
+#define PS_SYSMON_ANALOG_BUS_REG	0xFFA50914
+
 int board_init(void)
 {
 	struct udevice *dev;
@@ -343,6 +346,9 @@ int board_init(void)
 
 	printf("EL Level:\tEL%d\n", current_el());
 
+	/* Bug in ROM sets wrong value in this register */
+	writel(PS_SYSMON_ANALOG_BUS_VAL, PS_SYSMON_ANALOG_BUS_REG);
+
 #if defined(CONFIG_FPGA) && defined(CONFIG_FPGA_ZYNQMPPL) && \
     !defined(CONFIG_SPL_BUILD) || (defined(CONFIG_SPL_FPGA_SUPPORT) && \
     defined(CONFIG_SPL_BUILD))
Signature · 1 line
2.17.1