Skip to contentSkip to conversation

net/null: add empty promiscuous mode functions

RFC In review Ciara Power 4 participants 16 messages Oct 16, 2019 – Oct 18, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

RFC 1/1 net/null: add empty promiscuous mode functions

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

---
 drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
 	return 0;
 }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
 static const struct eth_dev_ops ops = {
 	.dev_start = eth_dev_start,
 	.dev_stop = eth_dev_stop,
 	.dev_configure = eth_dev_configure,
 	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
 	.rx_queue_setup = eth_rx_queue_setup,
 	.tx_queue_setup = eth_tx_queue_setup,
 	.rx_queue_release = eth_queue_release,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 37 lines
---
 drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
 	return 0;
 }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
 static const struct eth_dev_ops ops = {
 	.dev_start = eth_dev_start,
 	.dev_stop = eth_dev_stop,
 	.dev_configure = eth_dev_configure,
 	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
 	.rx_queue_setup = eth_rx_queue_setup,
 	.tx_queue_setup = eth_tx_queue_setup,
 	.rx_queue_release = eth_queue_release,
#2 lore raw
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 36 lines
Quoted 36 lines
---
  drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
  	return 0;
  }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
  static const struct eth_dev_ops ops = {
  	.dev_start = eth_dev_start,
  	.dev_stop = eth_dev_stop,
  	.dev_configure = eth_dev_configure,
  	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
  	.rx_queue_setup = eth_rx_queue_setup,
  	.tx_queue_setup = eth_tx_queue_setup,
  	.rx_queue_release = eth_queue_release,
#3 lore raw
Quoted 25 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 7 lines

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

Quoted 38 lines
Quoted 37 lines
Quoted 37 lines
---
  drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
  	return 0;
  }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
  static const struct eth_dev_ops ops = {
  	.dev_start = eth_dev_start,
  	.dev_stop = eth_dev_stop,
  	.dev_configure = eth_dev_configure,
  	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
  	.rx_queue_setup = eth_rx_queue_setup,
  	.tx_queue_setup = eth_tx_queue_setup,
  	.rx_queue_release = eth_queue_release,
#4 lore raw
Quoted 32 lines · Ferruh Yigit
Quoted 24 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 7 lines

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 36 lines
Quoted 36 lines
Quoted 36 lines
Quoted 36 lines
---
   drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
   1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
   	return 0;
   }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
   static const struct eth_dev_ops ops = {
   	.dev_start = eth_dev_start,
   	.dev_stop = eth_dev_stop,
   	.dev_configure = eth_dev_configure,
   	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
   	.rx_queue_setup = eth_rx_queue_setup,
   	.tx_queue_setup = eth_tx_queue_setup,
   	.rx_queue_release = eth_queue_release,
#5 lore raw
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 38 lines
Quoted 37 lines
Quoted 37 lines
Quoted 37 lines
Quoted 37 lines
---
   drivers/net/null/rte_eth_null.c | 14 ++++++++++++++
   1 file changed, 14 insertions(+)
drivers/net/null/rte_eth_null.c +14 -0
index e2ff41a22..b8472a0cf 100644
@@ -441,11 +441,25 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
   	return 0;
   }
 
+static int
+eth_dev_promiscuous_enable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
+static int
+eth_dev_promiscuous_disable(__rte_unused struct rte_eth_dev *dev)
+{
+	return 0;
+}
+
   static const struct eth_dev_ops ops = {
   	.dev_start = eth_dev_start,
   	.dev_stop = eth_dev_stop,
   	.dev_configure = eth_dev_configure,
   	.dev_infos_get = eth_dev_info,
+	.promiscuous_enable = eth_dev_promiscuous_enable,
+	.promiscuous_disable = eth_dev_promiscuous_disable,
   	.rx_queue_setup = eth_rx_queue_setup,
   	.tx_queue_setup = eth_tx_queue_setup,
   	.rx_queue_release = eth_queue_release,
#6 lore raw
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

/Bruce

#7 lore raw
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

#8 lore raw
Quoted 64 lines · Ferruh Yigit
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Quoted 6 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

btw, initialize promiscuous as enabled at PMD init won't help with current APIs because in API dev_ops check is earlier and will still cause -ENOTSUP.

rte_eth_promiscuous_enable
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->promiscuous_enable, -ENOTSUP); if (dev->data->promiscuous == 0)

     diag = (*dev->dev_ops->promiscuous_enable)(dev);
     dev->data->promiscuous = (diag == 0) ? 1 : 0;

return

#9 lore raw
Quoted 62 lines · Ferruh Yigit
Quoted 61 lines · Ferruh Yigit
Quoted 50 lines · Bruce Richardson
Quoted 40 lines · Ferruh Yigit
Quoted 39 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 24 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 7 lines

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:

        eth_dev->data->promiscuous = 1;

If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

Quoted 9 lines
Quoted 1 line

If application really does not care, it should be in the application code.

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Quoted 8 lines
Quoted 6 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

btw, initialize promiscuous as enabled at PMD init won't help with current APIs because in API dev_ops check is earlier and will still cause -ENOTSUP.

My bad, I think it should be fixed.

Quoted 7 lines

rte_eth_promiscuous_enable

   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->promiscuous_enable, -ENOTSUP);
   if (dev->data->promiscuous == 0)
      diag = (*dev->dev_ops->promiscuous_enable)(dev);
      dev->data->promiscuous = (diag == 0) ? 1 : 0;
   return
#10 lore raw
In reply to Ferruh Yigit
Quoted 60 lines · Ferruh Yigit
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 4 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

Quoted 2 lines

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

#11 lore raw
Quoted 70 lines · Bruce Richardson
Quoted 60 lines · Ferruh Yigit
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

My thinking is, application "cares" about the ethdev API return values, but to check/test quickly with null/ring PMD perhaps not really care that much abut promisc/allmuticast support of these PMDs and let's relax these support of virtual PMDs to make life easy.

But eventually the main target is to fix sample applications to run with virtual PMDs which has been broken in this release.
Both approach works,
a) Implement dummy dev_ops to virtual PMDs to report success
b) Update ethdev APIs to not call dev_ops if the requested configuration is already satisfied and change virtual PMDs to report promisc & allmulticast enabled by default. (disable still will have same issue)

Is the consensus option (b)?

btw, the problem exists in high level for the offload support, if the application is requesting a specific offload support it fails to run with the virtual PMDs since virtual PMDs doesn't support any offloads. Indeed I have same suggestion for this case too, relax the virtual PMD by claiming it supports all offloads. Because at least for me when I use those virtual PMDs I don't really would like to test offloads or the procmisc/allmulticast features ...

Quoted 3 lines
Quoted 3 lines

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

#12 lore raw
Quoted 85 lines · Ferruh Yigit
Quoted 65 lines · Bruce Richardson
Quoted 57 lines · Ferruh Yigit
Quoted 50 lines · Bruce Richardson
Quoted 40 lines · Ferruh Yigit
Quoted 39 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 24 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 7 lines

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:

        eth_dev->data->promiscuous = 1;

If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

Quoted 9 lines
Quoted 1 line

If application really does not care, it should be in the application code.

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 6 lines
Quoted 3 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

My thinking is, application "cares" about the ethdev API return values, but to check/test quickly with null/ring PMD perhaps not really care that much abut promisc/allmuticast support of these PMDs and let's relax these support of virtual PMDs to make life easy.

But eventually the main target is to fix sample applications to run with virtual PMDs which has been broken in this release.
Both approach works,
a) Implement dummy dev_ops to virtual PMDs to report success
b) Update ethdev APIs to not call dev_ops if the requested configuration is already satisfied and change virtual PMDs to report promisc & allmulticast enabled by default. (disable still will have same issue)

Quoted 1 line

Is the consensus option (b)?

Yes.

Quoted 6 lines

btw, the problem exists in high level for the offload support, if the application is requesting a specific offload support it fails to run with the virtual PMDs since virtual PMDs doesn't support any offloads. Indeed I have same suggestion for this case too, relax the virtual PMD by claiming it supports all offloads. Because at least for me when I use those virtual PMDs I don't really would like to test offloads or the procmisc/allmulticast features ...

It looks like I simply don't understand virtual PMDs usacase.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

#13 lore raw
Quoted 90 lines · Andrew Rybchenko
Quoted 85 lines · Ferruh Yigit
Quoted 65 lines · Bruce Richardson
Quoted 57 lines · Ferruh Yigit
Quoted 50 lines · Bruce Richardson
Quoted 40 lines · Ferruh Yigit
Quoted 39 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 24 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

Quoted 7 lines

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:

        eth_dev->data->promiscuous = 1;

If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

Quoted 9 lines
Quoted 1 line

If application really does not care, it should be in the application code.

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 6 lines
Quoted 3 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

My thinking is, application "cares" about the ethdev API return values, but to check/test quickly with null/ring PMD perhaps not really care that much abut promisc/allmuticast support of these PMDs and let's relax these support of virtual PMDs to make life easy.

But eventually the main target is to fix sample applications to run with virtual PMDs which has been broken in this release.
Both approach works,
a) Implement dummy dev_ops to virtual PMDs to report success
b) Update ethdev APIs to not call dev_ops if the requested configuration is already satisfied and change virtual PMDs to report promisc & allmulticast enabled by default. (disable still will have same issue)

Quoted 1 line

Is the consensus option (b)?

Yes.

Quoted 8 lines
Quoted 6 lines

btw, the problem exists in high level for the offload support, if the application is requesting a specific offload support it fails to run with the virtual PMDs since virtual PMDs doesn't support any offloads. Indeed I have same suggestion for this case too, relax the virtual PMD by claiming it supports all offloads. Because at least for me when I use those virtual PMDs I don't really would like to test offloads or the procmisc/allmulticast features ...

It looks like I simply don't understand virtual PMDs usacase.

I guess it changes for virtual PMD, bonding, failsafe, vhost, etc has more production use cases, null I would assume mostly used for debugging.

Quoted 4 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

With a common function shared by all PMDs for both promisc and allmuticast will add a little code and an easier solution.

#14 lore raw
In reply to Ferruh Yigit
Quoted 95 lines · Ferruh Yigit
Quoted 70 lines · Bruce Richardson
Quoted 60 lines · Ferruh Yigit
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

My thinking is, application "cares" about the ethdev API return values, but to check/test quickly with null/ring PMD perhaps not really care that much abut promisc/allmuticast support of these PMDs and let's relax these support of virtual PMDs to make life easy.

But eventually the main target is to fix sample applications to run with virtual PMDs which has been broken in this release.
Both approach works,
a) Implement dummy dev_ops to virtual PMDs to report success
b) Update ethdev APIs to not call dev_ops if the requested configuration is already satisfied and change virtual PMDs to report promisc & allmulticast enabled by default. (disable still will have same issue)

Is the consensus option (b)?

Quoted 7 lines

btw, the problem exists in high level for the offload support, if the application is requesting a specific offload support it fails to run with the virtual PMDs since virtual PMDs doesn't support any offloads. Indeed I have same suggestion for this case too, relax the virtual PMD by claiming it supports all offloads. Because at least for me when I use those virtual PMDs I don't really would like to test offloads or the procmisc/allmulticast features ...

I really dislike having the drivers lying. It may work in some cases, but eventually you will hit a problem where an app really does need a feature and then breaks for the user in mysterious ways when run with a virtual PMD. Much better to have the vPMD always report the truth to the app, and let the app worry about whether the app can continue on error or not.

Final option I'd throw out there, is to allow a vdev parameter to tell the vpmd it's allowed to lie. That gives an override in case of an app that can't handle a non-fatal failure.

/Bruce

#15 lore raw
Quoted 109 lines · Bruce Richardson
Quoted 95 lines · Ferruh Yigit
Quoted 70 lines · Bruce Richardson
Quoted 60 lines · Ferruh Yigit
Quoted 52 lines · Bruce Richardson
Quoted 43 lines · Ferruh Yigit
Quoted 33 lines · Andrew Rybchenko
Quoted 32 lines · Ferruh Yigit
Quoted 31 lines · Andrew Rybchenko
Quoted 18 lines · Ferruh Yigit
Quoted 8 lines · Ciara Power

Adding promiscuous functions prevents sample applications failing when run on this virtual PMD. The sample applications call promiscuous functions, and fail if this function call returns an error, which occurs when the virtual PMD does not support the promiscuous function being called.

This change will be implemented for all virtual PMDs that currently do not have existing promiscuous functions. Multicast functions will also be added for virtual PMDs to prevent sample application breakages here also.

+Andrew

With the some ethdev APIs returning error code, some sample applications stop working with virtual interfaces,

We can,
1- update sample applications to ignore the errors
2- Add dummy dev_ops support to (almost all) virtual PMDs (what this RFC suggests)

Quoted 5 lines

(1) puts us back to before the ethdev APIs updated status, and this may be wrong for the physical devices case, so I am for this RFC.

Only perhaps we can have some common empty function and keep assigning that one to reduce the dummy code, what do you think?

I don't like the idea to have common empty/dummy functions. If virtual PMD behaves in accordance with enabled promiscuous mode, it should initialize it properly on init:
     eth_dev->data->promiscuous = 1;
If so, if application requires promiscuous mode, attempt to enable will do nothing. If application requires non-promiscuous mode, disable will fail and it is good.

Quoted 8 lines
Quoted 3 lines

It is technically correct that we can't disable promiscuous mode in virtual PMDs but I think mainly we don't really care so it returning error may make the applications fail/exit unnecessarily with virtual PMDs.

If I test virtual PMD promiscuous mode, I would prefer enable/disable callback to say me truth.

If application really does not care, it should be in the application code.

Quoted 8 lines

Application can't change this because they may be caring return result for the physical devices.

Up until this release these missing dev_ops in virtual PMDs were silently ignored, now APIs are more strict on this (which is good) but to get close the previous behavior for virtual PMDs we need to relax on these features (like saying success on promiscuous disable although it didn't).

Quoted 6 lines

The other variable here is how often an app is going to request promiscuous disabling? Given that most ports generally come up in that state anyway, and one needs to request enabling it, surely the disable case is relatively rare? In that case I'd tend to agree with having disabling it returning error for vpmds.

Quoted 3 lines

Yes disabling most probably rare, but still it will generate an error and application is failing because of ring PMD promiscuous disable doesn't look right to me.

Well, if an app needs promiscuous mode disabled then having it fail is the right thing to do. If the app doesn't care about promiscuous mode failing, why is it checking the return value at all?

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

Perhaps application should differentiate between -ENOTSUP error and operation fail error, but that looks to me adding unnecessary complexity to the app.

Again, does the app care or not? It's probably still better to return correct info to the app in all cases, and then let the app decide how best to handle it.

My thinking is, application "cares" about the ethdev API return values, but to check/test quickly with null/ring PMD perhaps not really care that much abut promisc/allmuticast support of these PMDs and let's relax these support of virtual PMDs to make life easy.

But eventually the main target is to fix sample applications to run with virtual PMDs which has been broken in this release.
Both approach works,
a) Implement dummy dev_ops to virtual PMDs to report success
b) Update ethdev APIs to not call dev_ops if the requested configuration is already satisfied and change virtual PMDs to report promisc & allmulticast enabled by default. (disable still will have same issue)

Is the consensus option (b)?

Quoted 7 lines

btw, the problem exists in high level for the offload support, if the application is requesting a specific offload support it fails to run with the virtual PMDs since virtual PMDs doesn't support any offloads. Indeed I have same suggestion for this case too, relax the virtual PMD by claiming it supports all offloads. Because at least for me when I use those virtual PMDs I don't really would like to test offloads or the procmisc/allmulticast features ...

I really dislike having the drivers lying. It may work in some cases, but eventually you will hit a problem where an app really does need a feature and then breaks for the user in mysterious ways when run with a virtual PMD. Much better to have the vPMD always report the truth to the app, and let the app worry about whether the app can continue on error or not.

Quoted 3 lines

Final option I'd throw out there, is to allow a vdev parameter to tell the vpmd it's allowed to lie. That gives an override in case of an app that can't handle a non-fatal failure.

vdev devarg can work for the offload case, only issue I can see at first glance is code duplication among the PMDs but perhaps that can be solved when issue checked in-dept.