a2dp: Remove experimental flag for remote MediaEndpoint
Luiz Augusto von Dentz
maintainerPATCH 1/1 a2dp: Remove experimental flag for remote MediaEndpoint
From: Luiz Augusto von Dentz <[email protected]>
This makes the MediaEndpoint and stable API for remote endpoints which aligns with RegisterApplication API which is already stable.
--- profiles/audio/a2dp.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)
profiles/audio/a2dp.c +5 -12
@@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg, }static const GDBusMethodTable sep_methods[] = { - {GDBUS_EXPERIMENTAL_ASYNC_METHOD ("SetConfiguration" , + {GDBUS_ASYNC_METHOD ("SetConfiguration" , GDBUS_ARGS({ "endpoint", "o" }, { "properties", "a{sv}" } ),NULL , set_configuration) },
@@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property, }static const GDBusPropertyTable sep_properties[] = { - {"UUID" ,"s" , get_uuid,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Codec" ,"y" , get_codec,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Device" ,"o" , get_device,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, + {"UUID" ,"s" , get_uuid,NULL ,NULL }, + {"Codec" ,"y" , get_codec,NULL ,NULL }, + {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL }, + {"Device" ,"o" , get_device,NULL ,NULL }, { } };
@@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data) sep->chan = chan; sep->sep = rsep; -if (!(g_dbus_get_flags () &G_DBUS_FLAG_ENABLE_EXPERIMENTAL )) - goto done; -if (asprintf (&sep->path,"%s/sep%d" ,device_get_path (chan->device),avdtp_get_seid (rsep)) <0 ) {
Signature · 1 line
2.21.0
Luiz Augusto von Dentz
maintainerHi,
Quoted 52 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
This makes the MediaEndpoint and stable API for remote endpoints which aligns with RegisterApplication API which is already stable.
--- profiles/audio/a2dp.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)profiles/audio/a2dp.c +5
-13@@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg, }static const GDBusMethodTable sep_methods[] = { - {GDBUS_EXPERIMENTAL_ASYNC_METHOD ("SetConfiguration" , + {GDBUS_ASYNC_METHOD ("SetConfiguration" , GDBUS_ARGS({ "endpoint", "o" }, { "properties", "a{sv}" } ),NULL , set_configuration) },@@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property, }static const GDBusPropertyTable sep_properties[] = { - {"UUID" ,"s" , get_uuid,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Codec" ,"y" , get_codec,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Device" ,"o" , get_device,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, + {"UUID" ,"s" , get_uuid,NULL ,NULL }, + {"Codec" ,"y" , get_codec,NULL ,NULL }, + {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL }, + {"Device" ,"o" , get_device,NULL ,NULL }, { } };@@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data) sep->chan = chan; sep->sep = rsep; -if (!(g_dbus_get_flags () &G_DBUS_FLAG_ENABLE_EXPERIMENTAL )) - goto done; -if (asprintf (&sep->path,"%s/sep%d" ,device_get_path (chan->device),avdtp_get_seid (rsep)) <0 ) { --
Quoted 2 lines
2.21.0
Pushed.
Signature · 1 line
Luiz Augusto von Dentz
Hi Luiz,
Now that A2DP codec switching related APIs are declared stable in bluez git, I'd like to request bluez 5.52 release soon.
This is because feature freeze for PulseAudio 14.0 is scheduled for 2019-12-13, so It'd be nice to have a bluez release before that.. Also to try to avoid distros shipping bluez 5.51, where MediaEndpoint API isn't stable yet..
Thanks a lot,
-- Pasi
Quoted 63 lines · Luiz Augusto von Dentz
Hi,
Quoted 52 lines · Luiz Augusto von Dentz
From: Luiz Augusto von Dentz <[email protected]>
This makes the MediaEndpoint and stable API for remote endpoints which aligns with RegisterApplication API which is already stable.
--- profiles/audio/a2dp.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)profiles/audio/a2dp.c +5
-13@@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg, }static const GDBusMethodTable sep_methods[] = { - {GDBUS_EXPERIMENTAL_ASYNC_METHOD ("SetConfiguration" , + {GDBUS_ASYNC_METHOD ("SetConfiguration" , GDBUS_ARGS({ "endpoint", "o" }, { "properties", "a{sv}" } ),NULL , set_configuration) },@@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property, }static const GDBusPropertyTable sep_properties[] = { - {"UUID" ,"s" , get_uuid,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Codec" ,"y" , get_codec,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Device" ,"o" , get_device,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, + {"UUID" ,"s" , get_uuid,NULL ,NULL }, + {"Codec" ,"y" , get_codec,NULL ,NULL }, + {"Capabilities" ,"ay" , get_capabilities,NULL ,NULL }, + {"Device" ,"o" , get_device,NULL ,NULL }, { } };@@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data) sep->chan = chan; sep->sep = rsep; -if (!(g_dbus_get_flags () &G_DBUS_FLAG_ENABLE_EXPERIMENTAL )) - goto done; -if (asprintf (&sep->path,"%s/sep%d" ,device_get_path (chan->device),avdtp_get_seid (rsep)) <0 ) { --Quoted 2 lines
2.21.0
Pushed.
Signature · 1 line
Luiz Augusto von Dentz