package/libopenssl: set no-asm with generic architectures
PATCH v4 1/1 package/libopenssl: set no-asm with generic architectures
Use no-asm when building statically with a generic architecture such as gcc or linux-generic32, see
https://github.com/openssl/openssl/issues/9839
This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by
https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491
Fixes:
- http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185
---
Changes v3 -> v4 (after review of Thomas Petazzoni):
- Fix copy/paste error and remove the second assignation
Changes v2 -> v3 (after review of Thomas Petazzoni):
- Set no-asm with linux-generic32
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Set no-asm with all static builds and not only x86_64
package/libopenssl/libopenssl.mk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
package/libopenssl/libopenssl.mk +6 -2
@@ -12,7 +12,9 @@ LIBOPENSSL_LICENSE_FILES = LICENSE LIBOPENSSL_INSTALL_STAGING = YES LIBOPENSSL_DEPENDENCIES = zlib HOST_LIBOPENSSL_DEPENDENCIES = host-zlib -LIBOPENSSL_TARGET_ARCH = linux-generic32 +# no-asm is needed with generic architectures such as linux-generic32, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = linux-generic32 no-asm LIBOPENSSL_CFLAGS = $(TARGET_CFLAGS) LIBOPENSSL_PROVIDES = openssl
@@ -55,7 +57,9 @@ endif ifeq ($(BR2_STATIC_LIBS),y) # Use "gcc" minimalistic target to disable DSO -LIBOPENSSL_TARGET_ARCH = gcc +# no-asm is needed with generic architectures such as gcc, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = gcc no-asm else # Some architectures are optimized in OpenSSL # Doesn't work for thumb-only (Cortex-M?)
Signature · 1 line
2.23.0
PATCH v4 1/1 package/libopenssl: set no-asm with generic architectures
Quoted 3 lines · On Fri, 18 Oct 2019 18:56:44 +0200 Fabrice Fontaine…
Use no-asm when building statically with a generic architecture such as gcc or linux-generic32, see
https://github.com/openssl/openssl/issues/9839
This doesn't match what you are doing in the code. In the commit log you say that you're passing no-asm when building statically with gcc or linux-generic32.
In the code, you are *always* passing no-asm with linux-generic32, even for non-static builds. Is this intended ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com