net: ethernet: dwmac-sun8i: show message only when switching to promisc
Subsystems (5)
PATCH v2 1/1 net: ethernet: dwmac-sun8i: show message only when switching to promisc
Printing the info message every time more than the max number of mac addresses are requested generates unnecessary log spam. Showing it only when the hw is not already in promiscous mode is equally informative without being annoying.
Signed-off-by Mans Rullgard <[email protected]>
---
Changed in v2:
- test only RXALL bit
--- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +2 -1
@@ -646,7 +646,8 @@ static void sun8i_dwmac_set_filter(struct mac_device_info *hw, } } }else { -netdev_info (dev,"Too many address, switching to promiscuous\n" ); +if (!(readl (ioaddr +EMAC_RX_FRM_FLT ) &EMAC_FRM_FLT_RXALL )) +netdev_info (dev,"Too many address, switching to promiscuous\n" ); v =EMAC_FRM_FLT_RXALL ; }
Signature · 1 line
2.23.0
From: Mans Rullgard <[email protected]>
Date: Fri, 18 Oct 2019 17:56:58 +0100
Quoted 9 lines
Printing the info message every time more than the max number of mac addresses are requested generates unnecessary log spam. Showing it only when the hw is not already in promiscous mode is equally informative without being annoying.
Signed-off-by Mans Rullgard <[email protected]>---
Changed in v2:
- test only RXALL bit
Applied, thanks.