Skip to contentSkip to conversation

dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

PATCH Superseded Patrick Delaunay 3 participants 6 messages Oct 18, 2019 – Oct 21, 2019 Pin control

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

Correct the name of the define used in CONFIG_IS_ENABLED():
it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.

This correct a regression introduced by
commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")

---

 drivers/pinctrl/pinctrl-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-uclass.c +1 -1
index 0b1eb7fab4..dc2340b779 100644
@@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice *dev)
 
 UCLASS_DRIVER(pinconfig) = {
 	.id = UCLASS_PINCONFIG,
-#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE)
+#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE)
 	.post_bind = pinconfig_post_bind,
 #endif
 	.name = "pinconfig",
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

Quoted 18 lines · On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay <[email protected]>…

Correct the name of the define used in CONFIG_IS_ENABLED():
it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.

This correct a regression introduced by
commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")

---

 drivers/pinctrl/pinctrl-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/pinctrl/pinctrl-uclass.c index 0b1eb7fab4..dc2340b779 100644

drivers/pinctrl/pinctrl-uclass.c static int pinconfig_post_bind(struct udevice · line 163

Quoted 8 lines
drivers/pinctrl/pinctrl-uclass.c +1 -1
@@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice
 *dev) 
 UCLASS_DRIVER(pinconfig) = {
 	.id = UCLASS_PINCONFIG,
-#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE)
+#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE)
 	.post_bind = pinconfig_post_bind,
 #endif
 	.name = "pinconfig",

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191018/823560ad/attachment.sig>

#2 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

In reply to Patrick Delaunay
Quoted 8 lines · On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay patrick.delaunay at st.com…

Correct the name of the define used in CONFIG_IS_ENABLED():
it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.

This correct a regression introduced by
commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")

#3 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

In reply to Patrick Delaunay

Hi Tom,

On Fri, 18 Oct 2019 20:29:22 +0200
Patrick Delaunay patrick.delaunay at st.com wrote:
...

Quoted 3 lines

This correct a regression introduced by
commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")

Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet, I2C, GPIO, etc. on i.MX8QXP MEK board.

Many other boards are affected, too.

Thanks!

--
Anatolij

#4 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

Hi Anatolij and Tom,

Quoted 12 lines

From: Anatolij Gustschin <[email protected]>
Sent: samedi 19 octobre 2019 22:02

Hi Tom,

On Fri, 18 Oct 2019 20:29:22 +0200
Patrick Delaunay patrick.delaunay at st.com wrote:
...

Quoted 3 lines

This correct a regression introduced by commit c20851b3d850 ("dm:
pinctrl: introduce PINCONF_RECURSIVE
option")

Quoted 6 lines

Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet, I2C, GPIO, etc. on i.MX8QXP MEK board.

Many other boards are affected, too.

Thanks!

I check deeper today the root cause of the issue and I have a clean solution with v2 patch: http://patchwork.ozlabs.org/patch/1180575/

The friday patch wasn't enough at least for my board, but ok for sandbox.

And a minor correction of the Kconfig (not blocking)
http://patchwork.ozlabs.org/patch/1180576/

Quoted 2 lines

--
Anatolij

Sorry for disturbance.

Patrick

#5 lore raw

PATCH 1/1 dm: pinctrl: fix for introduce PINCONF_RECURSIVE option

Hi Patrick,

On Mon, 21 Oct 2019 17:10:21 +0000
Patrick DELAUNAY patrick.delaunay at st.com wrote:
...

Quoted 4 lines

I check deeper today the root cause of the issue and I have a clean solution with v2 patch: http://patchwork.ozlabs.org/patch/1180575/

The friday patch wasn't enough at least for my board, but ok for sandbox.

OK, thanks for fixing it!

--
Anatolij