ARM: dt: add fxos8700 on gateworks boards
Subsystems (2)
PATCH 1/1 ARM: dt: add fxos8700 on gateworks boards
Add fxos8700 iio imu entries for Gateworks SBCs.
Signed-off-by Robert Jones <[email protected]>
--- arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 5 +++++ arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 5 +++++ arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 5 +++++ 3 files changed, 15 insertions(+)
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +5 -0
@@ -306,6 +306,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700"; + reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;
arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +5 -0
@@ -297,6 +297,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700"; + reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +5 -0
@@ -354,6 +354,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700"; + reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;
Signature · 1 line
2.9.2
Hi Robert,
please don't use 'ARM: dt: ..' instead you should name it 'ARM: dts:
imx6qdl-gw5x:'.
Quoted 14 lines · Robert Jones
Add fxos8700 iio imu entries for Gateworks SBCs.
Signed-off-by Robert Jones <[email protected]>--- arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 5 +++++ arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 5 +++++ arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 5 +++++ 3 files changed, 15 insertions(+)arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +0
-0
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi line 310
Quoted 5 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +2
-0@@ -306,6 +306,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700";
I grep'd the whole tree and found no such compatible. I don't know the rule but IMHO if there isn't a driver we shouldn't add the compatible here.
Regards,
Marco
Quoted 43 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +3
-0+ reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +5
-0@@ -297,6 +297,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700"; + reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +5
-0@@ -354,6 +354,11 @@ VDDIO-supply = <®_3p3v>; }; + fxos8700@1e { + compatible = "nxp,fxos8700"; + reg = <0x1e>; + }; + touchscreen: egalax_ts@4 { compatible = "eeti,egalax_ts"; reg = <0x04>;Signature · 1 line
2.9.2
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |