ARM: dt: add lsm9ds1 iio imu/magn support to gw553x
Subsystems (2)
PATCH 1/1 ARM: dt: add lsm9ds1 iio imu/magn support to gw553x
Add one node for the accel/gyro i2c device and another for the separate magnetometer device in the lsm9ds1.
--- arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +31 -0
@@ -173,6 +173,25 @@ pinctrl-0 = <&pinctrl_i2c2>; status = "okay"; + lsm9ds1_ag@6a { + compatible = "st,lsm9ds1-imu"; + reg = <0x6a>; + st,drdy-int-pin = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_acc_gyro>; + interrupt-parent = <&gpio7>; + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>; + }; + + lsm9ds1_m@1c { + compatible = "st,lsm9ds1-magn"; + reg = <0x1c>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_mag>; + interrupt-parent = <&gpio1>; + interrupts = <2 IRQ_TYPE_EDGE_RISING>; + }; + ltc3676: pmic@3c { compatible = "lltc,ltc3676"; reg = <0x3c>;
@@ -462,6 +481,18 @@ >; }; + pinctrl_acc_gyro: acc_gyrogrp { + fsl,pins = < + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b0b0 + >; + }; + + pinctrl_mag: maggrp { + fsl,pins = < + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 + >; + }; + pinctrl_pps: ppsgrp { fsl,pins = < MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b1
Signature · 1 line
2.9.2
Hi Robert,
same here, don't name it 'ARM: dt: ...' instead name it 'ARM: dts: imx:
ventana: ..' or 'ARM: dts: imx: imx6qdl-gw553x: ..'.
Quoted 13 lines · Robert Jones
Add one node for the accel/gyro i2c device and another for the separate magnetometer device in the lsm9ds1.
Signed-off-by Robert Jones <[email protected]>--- arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)arch/arm/boot/dts/imx6qdl-gw553x.dtsi +0
-0
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 177
Quoted 5 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +2
-0@@ -173,6 +173,25 @@ pinctrl-0 = <&pinctrl_i2c2>; status = "okay"; + lsm9ds1_ag@6a { + compatible = "st,lsm9ds1-imu";
Didn't found this compatible string.
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 188
Quoted 11 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +11
-0+ reg = <0x6a>; + st,drdy-int-pin = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_acc_gyro>; + interrupt-parent = <&gpio7>; + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>; + }; + + lsm9ds1_m@1c { + compatible = "st,lsm9ds1-magn"; + reg = <0x1c>;
Nodes are sorted according their i2c-addresses.
Regards,
Marco
Quoted 33 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +18
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_mag>; + interrupt-parent = <&gpio1>; + interrupts = <2 IRQ_TYPE_EDGE_RISING>; + }; + ltc3676: pmic@3c { compatible = "lltc,ltc3676"; reg = <0x3c>;@@ -462,6 +481,18 @@ >; }; + pinctrl_acc_gyro: acc_gyrogrp { + fsl,pins = < + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b0b0 + >; + }; + + pinctrl_mag: maggrp { + fsl,pins = < + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 + >; + }; + pinctrl_pps: ppsgrp { fsl,pins = < MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b1Signature · 1 line
2.9.2
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 5 lines · Marco Felsch
Hi Robert,
same here, don't name it 'ARM: dt: ...' instead name it 'ARM: dts: imx:
ventana: ..' or 'ARM: dts: imx: imx6qdl-gw553x: ..'.
Sorry about that, I'll follow that format from now on.
Quoted 18 lines · Robert Jones
Quoted 16 lines
Add one node for the accel/gyro i2c device and another for the separate magnetometer device in the lsm9ds1.
Signed-off-by Robert Jones <[email protected]>--- arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)arch/arm/boot/dts/imx6qdl-gw553x.dtsi +0
-0@@ -173,6 +173,25 @@ pinctrl-0 = <&pinctrl_i2c2>; status = "okay";
Quoted 4 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 177
Quoted 2 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +2
-0+ lsm9ds1_ag@6a { + compatible = "st,lsm9ds1-imu";Didn't found this compatible string.
So this is a compatible string for a driver that's being mainlined now. The devicetree bindings for which has already been reviewed-by Rob Herring as seen here:
https://www.spinics.net/lists/linux-iio/msg47297.html. If possible I'd prefer to get this in the same kernel release so let me know if there's anything else I can do to make that happen.
Quoted 13 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 188
Quoted 12 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +11
-0+ reg = <0x6a>; + st,drdy-int-pin = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_acc_gyro>; + interrupt-parent = <&gpio7>; + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>; + }; + + lsm9ds1_m@1c { + compatible = "st,lsm9ds1-magn"; + reg = <0x1c>;
Quoted 2 lines
Nodes are sorted according their i2c-addresses.
I'll resubmit with that change, thanks!
- Bobby
Quoted 42 lines
Regards,
MarcoQuoted 29 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +18
-1+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_mag>; + interrupt-parent = <&gpio1>; + interrupts = <2 IRQ_TYPE_EDGE_RISING>; + }; + ltc3676: pmic@3c { compatible = "lltc,ltc3676"; reg = <0x3c>;@@ -462,6 +481,18 @@ >; }; + pinctrl_acc_gyro: acc_gyrogrp { + fsl,pins = < + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b0b0 + >; + }; + + pinctrl_mag: maggrp { + fsl,pins = < + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 + >; + }; + pinctrl_pps: ppsgrp { fsl,pins = < MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b1 --Quoted 4 lines
2.9.2
--
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 31 lines · Bobby Jones
Quoted 5 lines · Marco Felsch
Hi Robert,
same here, don't name it 'ARM: dt: ...' instead name it 'ARM: dts: imx:
ventana: ..' or 'ARM: dts: imx: imx6qdl-gw553x: ..'.Sorry about that, I'll follow that format from now on.
Quoted 18 lines · Robert Jones
Quoted 16 lines
Add one node for the accel/gyro i2c device and another for the separate magnetometer device in the lsm9ds1.
Signed-off-by Robert Jones <[email protected]>--- arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)arch/arm/boot/dts/imx6qdl-gw553x.dtsi +0
-0@@ -173,6 +173,25 @@ pinctrl-0 = <&pinctrl_i2c2>; status = "okay";Quoted 4 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 177
Quoted 2 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +2
-0+ lsm9ds1_ag@6a { + compatible = "st,lsm9ds1-imu";Didn't found this compatible string.
Quoted 7 lines
So this is a compatible string for a driver that's being mainlined now. The devicetree bindings for which has already been reviewed-by Rob Herring as seen here:
https://www.spinics.net/lists/linux-iio/msg47297.html. If possible I'd prefer to get this in the same kernel release so let me know if there's anything else I can do to make that happen.
I mixed up my replies here. That link points to the "nxp,fxos8700" compatible string that you brought up in your other response. The "st,lsm9ds1-imu" compatible string is described in Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt which was an August commit that made it into the imx/dt branch.
Quoted 60 lines
Quoted 13 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi line 188
Quoted 12 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +11
-0+ reg = <0x6a>; + st,drdy-int-pin = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_acc_gyro>; + interrupt-parent = <&gpio7>; + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>; + }; + + lsm9ds1_m@1c { + compatible = "st,lsm9ds1-magn"; + reg = <0x1c>;Quoted 2 lines
Nodes are sorted according their i2c-addresses.
I'll resubmit with that change, thanks!
- BobbyQuoted 42 lines
Regards,
MarcoQuoted 29 lines
arch/arm/boot/dts/imx6qdl-gw553x.dtsi +18
-1+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_mag>; + interrupt-parent = <&gpio1>; + interrupts = <2 IRQ_TYPE_EDGE_RISING>; + }; + ltc3676: pmic@3c { compatible = "lltc,ltc3676"; reg = <0x3c>;@@ -462,6 +481,18 @@ >; }; + pinctrl_acc_gyro: acc_gyrogrp { + fsl,pins = < + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b0b0 + >; + }; + + pinctrl_mag: maggrp { + fsl,pins = < + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0 + >; + }; + pinctrl_pps: ppsgrp { fsl,pins = < MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b1 --Quoted 4 lines
2.9.2
--
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |