kernel: dma: contigous: Make CMA parameters __initdata/__initconst
Subsystems (2)
PATCH v2 1/1 kernel: dma: contigous: Make CMA parameters __initdata/__initconst
These parameters are only referenced by __init routine calls during early boot so they should be marked as __initdata and __initconst accordingly.
---V1->V2:
mark cma parameters as __initdata/__initconst instead of __ro_after_init. As these parameters are only used by __init calls and never used afterwards which contrast the __ro_after_init usage.
--- kernel/dma/contiguous.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/dma/contiguous.c +4 -4
@@ -42,10 +42,10 @@ struct cma *dma_contiguous_default_area;* Users, who want to set the size of global CMA area for their system * should use cma= kernel parameter. */ -static const phys_addr_t size_bytes = (phys_addr_t )CMA_SIZE_MBYTES *SZ_1M ; -static phys_addr_t size_cmdline =-1 ; -static phys_addr_t base_cmdline; -static phys_addr_t limit_cmdline; +static const phys_addr_t size_bytes__initconst = (phys_addr_t )CMA_SIZE_MBYTES *SZ_1M ; +static phys_addr_t size_cmdline__initdata =-1 ; +static phys_addr_t base_cmdline__initdata ; +static phys_addr_t limit_cmdline__initdata ;static int __init early_cma (char *p) {
Signature · 1 line
2.20.1
Quoted 2 lines · Shyam Saini
These parameters are only referenced by
__initroutine calls during early boot so they should be marked as__initdataand__initconstaccordingly.
Quoted 27 lines
Cc Christoph Hellwig <[email protected]>Cc Marek Szyprowski <[email protected]>Cc Robin Murphy <[email protected]>Cc Matthew Wilcox <[email protected]>Cc Christopher Lameter <[email protected]>Cc Kees Cook <[email protected]>Signed-off-by Shyam Saini <[email protected]>---
V1->V2:
mark cma parameters as __initdata/__initconst instead of__ro_after_init. As these parameters are only used by__initcalls and never used afterwards which contrast the__ro_after_initusage.--- kernel/dma/contiguous.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)kernel/dma/contiguous.c +0
-1@@ -42,10 +42,10 @@ struct cma *dma_contiguous_default_area;* Users, who want to set the size of global CMA area for their system * should use cma= kernel parameter. */ -static const phys_addr_t size_bytes = (phys_addr_t )CMA_SIZE_MBYTES *SZ_1M ;
kernel/dma/contiguous.c struct cma *dma_contiguous_default_area; · line 51
Quoted 10 lines
kernel/dma/contiguous.c +4
-3-static phys_addr_t size_cmdline =-1 ; -static phys_addr_t base_cmdline; -static phys_addr_t limit_cmdline; +static const phys_addr_t size_bytes__initconst = (phys_addr_t )CMA_SIZE_MBYTES *SZ_1M ; +static phys_addr_t size_cmdline__initdata =-1 ; +static phys_addr_t base_cmdline__initdata ; +static phys_addr_t limit_cmdline__initdata ;static int __init early_cma (char *p) {
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Applied to the dma-mapping for-next branch after fixing up the commit message and an overly long line.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu