kdb: Avoid array subscript warnings on non-SMP builds
PATCH v2 1/1 kdb: Avoid array subscript warnings on non-SMP builds
Recent versions of gcc (reported on gcc-7.4) issue array subscript warnings for builds where SMP is not enabled.
kernel/debug/debug_core.c: In function 'kdb_dump_stack_on_cpu':kernel/debug/debug_core.c:452:17: warning: array subscript is outside array +bounds [-Warray-bounds]
if (!(kgdb_info[cpu].exception_state & DCPU_IS_SLAVE)) {
~~~~~~~~~^~~~~
kernel/debug/debug_core.c:469:33: warning: array subscript is outside array
+bounds [-Warray-bounds]
kgdb_info[cpu].exception_state |= DCPU_WANT_BT; kernel/debug/debug_core.c:470:18: warning: array subscript is outside array
+bounds [-Warray-bounds]
while (kgdb_info[cpu].exception_state & DCPU_WANT_BT)
There is no bug here but there is scope to improve the code generation for non-SMP systems (whilst also silencing the warning).
---
Notes:
Changes in v2:
- Moved the IS_ENABLED(CONFIG_SMP) test to the first (slightly easier to read the code, improves code generation a little)
- Sent out as a proper patch e-mail ;-)
kernel/debug/debug_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/debug_core.c +1 -1
@@ -444,7 +444,7 @@ int dbg_remove_all_break(void)#ifdef CONFIG_KGDB_KDB void kdb_dump_stack_on_cpu (int cpu) { -if (cpu ==raw_smp_processor_id ()) { +if (cpu ==raw_smp_processor_id () || !IS_ENABLED (CONFIG_SMP )) {dump_stack ();return ; }
--
2.21.0
Hi,
Quoted 39 lines · Daniel Thompson
Recent versions of gcc (reported on gcc-7.4) issue array subscript warnings for builds where SMP is not enabled.
kernel/debug/debug_core.c: In function 'kdb_dump_stack_on_cpu':kernel/debug/debug_core.c:452:17: warning: array subscript is outside array(quoted diff) +3
-0+bounds [-Warray-bounds] if (!(kgdb_info[cpu].exception_state & DCPU_IS_SLAVE)) { ~~~~~~~~~^~~~~ kernel/debug/debug_core.c:469:33: warning: array subscript is outside array +bounds [-Warray-bounds] kgdb_info[cpu].exception_state |= DCPU_WANT_BT; kernel/debug/debug_core.c:470:18: warning: array subscript is outside array +bounds [-Warray-bounds] while (kgdb_info[cpu].exception_state & DCPU_WANT_BT)There is no bug here but there is scope to improve the code generation for non-SMP systems (whilst also silencing the warning).
Reported-by kbuild test robot <[email protected]>Fixes 2277b492582d ("kdb: Fix stack crawling on 'running' CPUs that aren't the master")Signed-off-by Daniel Thompson <[email protected]>---
Notes:
Changes in v2:- Moved the
IS_ENABLED(CONFIG_SMP)test to the first (slightly easier to read the code, improves code generation a little)
- Sent out as a proper patch e-mail ;-)kernel/debug/debug_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/debug/debug_core.c +0
-0
kernel/debug/debug_core.c int dbg_remove_all_break(void) · line 447
Quoted 5 lines
kernel/debug/debug_core.c +1
-1@@ -444,7 +444,7 @@ int dbg_remove_all_break(void)#ifdef CONFIG_KGDB_KDB void kdb_dump_stack_on_cpu (int cpu) { -if (cpu ==raw_smp_processor_id ()) { +if (cpu ==raw_smp_processor_id () || !IS_ENABLED (CONFIG_SMP )) {
At first I thought maybe your code would be less efficient than:
if (!IS_ENABLED(CONFIG_SMP) || cpu == raw_smp_processor_id())
...since the compiler would be still be required to "call" raw_smp_processor_id() in the non-SMP case. ...but then I realized that seems to be a macro in the non-SMP case and just resolves to 0. ...so while the compiler would still be "required" to execute the first part of the if test, it should be able to realize that it's a no-op.
-Doug
Quoted 6 lines
kernel/debug/debug_core.c +0
-1dump_stack ();return ; } --2.21.0