RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
PATCH 1/1 RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
The parse_acpi_topology() is not declared anywhere which causes the following sparse warning:
drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
RFC: is this the best place to put it?
---
Cc: Sudeep Holla <[email protected]>
Cc: [email protected]
--- include/linux/arch_topology.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/arch_topology.h +2 -0
@@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);void reset_cpu_topology (void );#endif +extern int parse_acpi_topology (void ); +#endif /* _LINUX_ARCH_TOPOLOGY_H_ */
Signature · 1 line
2.23.0
Quoted 20 lines · Ben Dooks (Codethink)
The
parse_acpi_topology()is not declared anywhere which causes the following sparse warning:
drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?RFC: is this the best place to put it?
Signed-off-by Ben Dooks (Codethink) <[email protected]>---
Cc: Sudeep Holla <[email protected]>
Cc: [email protected]--- include/linux/arch_topology.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/arch_topology.h +0
-0
include/linux/arch_topology.h void remove_cpu_topology(unsigned int cpuid); · line 63
Quoted 5 lines
include/linux/arch_topology.h +2
-0@@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);void reset_cpu_topology (void );#endif +extern int parse_acpi_topology (void ); +
Can we drop extern like other declarations here ? Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?
Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.
--
Regards,
Sudeep
Quoted 24 lines · Sudeep Holla
Quoted 23 lines · Ben Dooks (Codethink)
The
parse_acpi_topology()is not declared anywhere which causes the following sparse warning:
drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?RFC: is this the best place to put it?
Signed-off-by Ben Dooks (Codethink) <[email protected]>---
Cc: Sudeep Holla <[email protected]>
Cc: [email protected]--- include/linux/arch_topology.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/arch_topology.h +0
-0@@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);void reset_cpu_topology (void );#endif
Quoted 7 lines
include/linux/arch_topology.h void remove_cpu_topology(unsigned int cpuid); · line 63
Quoted 2 lines
include/linux/arch_topology.h +2
-0+extern int parse_acpi_topology (void ); +Can we drop extern like other declarations here ? Also move this inside
CONFIG_GENERIC_ARCH_TOPOLOGY?Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.
Ok, thank you for the input.
Signature · 4 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html