Skip to contentSkip to conversation

armv8: layerscape: set HWCONFIG_BUFFER_SIZE

PATCH New Michael Walle 2 participants 5 messages Oct 21, 2019 – Nov 13, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE are not set.

Taken from arch/powerpc/include/asm/config.h.

---
 arch/arm/include/asm/arch-fsl-layerscape/config.h | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/include/asm/arch-fsl-layerscape/config.h +4 -0
index a83c70ece2..24bf854cbe 100644
@@ -12,6 +12,10 @@
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
 
+#ifndef HWCONFIG_BUFFER_SIZE
+  #define HWCONFIG_BUFFER_SIZE 256
+#endif
+
 /*
  * Reserve secure memory
  * To be aligned with MMU block size
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Quoted 26 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Michael Walle
Sent: Monday, October 21, 2019 11:04 PM
To: u-boot at lists.denx.de
Cc: Tom Rini <[email protected]>
Subject: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE are not set.

Taken from arch/powerpc/include/asm/config.h.

---
arch/arm/include/asm/arch-fsl-layerscape/config.h | 4 ++++

1 file changed, 4 insertions(+)
arch/arm/include/asm/arch-fsl-layerscape/config.h +0 -0
index a83c70ece2..24bf854cbe 100644

arch/arm/include/asm/arch-fsl-layerscape/config.h line 18

Quoted 7 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h +4 -0
@@ -12,6 +12,10 @@
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
 
+#ifndef HWCONFIG_BUFFER_SIZE
+  #define HWCONFIG_BUFFER_SIZE 256
+#endif
+

This breaks compilation for platform like lx2160ardb. Error snippet:

include/configs/lx2160a_common.h:173: warning: "HWCONFIG_BUFFER_SIZE" redefined
#define HWCONFIG_BUFFER_SIZE 128

In file included from include/configs/lx2160a_common.h:10,

                 from include/configs/lx2160ardb.h:9,
                 from include/config.h:5,
                 from include/common.h:23,
                 from common/malloc_simple.c:10:

./arch/arm/include/asm/arch/config.h:16: note: this is the location of the previous definition
#define HWCONFIG_BUFFER_SIZE 256

--priyankajain

#2 lore raw

PATCH 1/1 armv8: layerscape: set HWCONFIG_BUFFER_SIZE

In reply to Michael Walle
Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Michael Walle
Sent: Monday, October 21, 2019 11:04 PM
To: u-boot at lists.denx.de
Cc: Tom Rini <[email protected]>
Subject: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Quoted 8 lines

Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE are not set.

Taken from arch/powerpc/include/asm/config.h.

---

Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain

#3 lore raw

PATCH 1/1 armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Am 2019-11-11 16:20, schrieb Priyanka Jain:

Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Michael Walle
Sent: Monday, October 21, 2019 11:04 PM
To: u-boot at lists.denx.de
Cc: Tom Rini <[email protected]>
Subject: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE are not set.

Quoted 6 lines
Quoted 4 lines

Taken from arch/powerpc/include/asm/config.h.

---

Applied to fsl-qoriq master, awaiting upstream.

That one wasn't applied, was it? You said this patch breaks other boards. For now, I just had time to had a brief look at it. Seems like the culprit is that the configs/bla_common.h for the these boards include <asm/arch/config.h>, although will be included later in include/config.h. So it is not possible to provide "defaults" for any macros. Do you think it is possible to remove the "#include <asm/arch/config.h>" in your _common.h config files?

-michael

#4 lore raw

PATCH 1/1 armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Quoted 30 lines

-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Tuesday, November 12, 2019 2:20 PM
To: Priyanka Jain <[email protected]>
Cc: u-boot at lists.denx.de; Tom Rini <[email protected]>
Subject: Re: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Am 2019-11-11 16:20, schrieb Priyanka Jain:

Quoted 10 lines
Quoted 10 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Michael Walle
Sent: Monday, October 21, 2019 11:04 PM
To: u-boot at lists.denx.de
Cc: Tom Rini <[email protected]>
Subject: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE

are

Quoted 8 lines
Quoted 6 lines

not set.

Taken from arch/powerpc/include/asm/config.h.

---

Applied to fsl-qoriq master, awaiting upstream.

Quoted 8 lines

That one wasn't applied, was it? You said this patch breaks other boards. For now, I just had time to had a brief look at it. Seems like the culprit is that the configs/bla_common.h for the these boards include <asm/arch/config.h>, although will be included later in include/config.h. So it is not possible to provide "defaults" for any macros. Do you think it is possible to remove the "#include <asm/arch/config.h>" in your _common.h config files?

-michael

Yes you are right. I dropped this patch at the last moment.
Sorry for confusion.
Regarding dropping "#include <asm/arch/config.h>" in your _common.h config files This wont be simple. Can you please think of alternative way.

-priyankajain