power: supply: ab8500_charger: Fix inconsistent IS_ERR and PTR_ERR
Subsystems (2)
PATCH 1/1 power: supply: ab8500_charger: Fix inconsistent IS_ERR and PTR_ERR
Fix inconsistent IS_ERR and PTR_ERR in ab8500_charger_probe().
The proper pointer to be passed as argument is di->adc_main_charger_c
This bug was detected with the help of Coccinelle.
Fixes 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/power/supply/ab8500_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/ab8500_charger.c +1 -1
@@ -3393,7 +3393,7 @@ static int ab8500_charger_probe(struct platform_device *pdev)if (PTR_ERR (di->adc_main_charger_c) == -ENODEV )return -EPROBE_DEFER ;dev_err (&pdev->dev,"failed to get ADC main charger current\n" ); -return PTR_ERR (di->adc_main_charger_v); +return PTR_ERR (di->adc_main_charger_c); } di->adc_vbus_v =devm_iio_channel_get (&pdev->dev,"vbus_v" );if (IS_ERR (di->adc_vbus_v)) {
Signature · 1 line
2.23.0
Sebastian Reichel
maintainerHi,
Quoted 9 lines · Gustavo A. R. Silva
Fix inconsistent
IS_ERRandPTR_ERRinab8500_charger_probe().The proper pointer to be passed as argument is
di->adc_main_charger_cThis bug was detected with the help of Coccinelle.
Fixes 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")Signed-off-by Gustavo A. R. Silva <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 19 lines
drivers/power/supply/ab8500_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/power/supply/ab8500_charger.c +1
-1@@ -3393,7 +3393,7 @@ static int ab8500_charger_probe(struct platform_device *pdev)if (PTR_ERR (di->adc_main_charger_c) == -ENODEV )return -EPROBE_DEFER ;dev_err (&pdev->dev,"failed to get ADC main charger current\n" ); -return PTR_ERR (di->adc_main_charger_v); +return PTR_ERR (di->adc_main_charger_c); } di->adc_vbus_v =devm_iio_channel_get (&pdev->dev,"vbus_v" );if (IS_ERR (di->adc_vbus_v)) {Signature · 1 line
2.23.0
Hey Sebastian,
Quoted 7 lines · Sebastian Reichel
Hi,
Quoted 4 lines · Gustavo A. R. Silva
Fix inconsistent
IS_ERRandPTR_ERRinab8500_charger_probe().The proper pointer to be passed as argument is
di->adc_main_charger_c
Quoted 8 lines
Quoted 5 lines
This bug was detected with the help of Coccinelle.
Fixes 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")Signed-off-by Gustavo A. R. Silva <[email protected]>---
Thanks, queued.
Awesome.
Thank you!
--
Gustavo