drm/amdgpu: Fix memory leak in amdgpu_fence_emit
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix memory leak in amdgpu_fence_emit
In the impelementation of amdgpu_fence_emit() if dma_fence_wait() fails and returns an errno, before returning the allocated memory for fence should be released.
Fixes 3d2aca8c8620 ("drm/amdgpu: fix old fence check in amdgpu_fence_emit")
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +3 -1
@@ -166,8 +166,10 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct dma_fence **f,if (old) { r =dma_fence_wait (old, false);dma_fence_put (old); -if (r) +if (r) { +dma_fence_put (fence);return r; + } } }
Signature · 1 line
2.17.1
Am 21.10.19 um 20:09 schrieb Navid Emamdoost:
Quoted 6 lines
In the impelementation of
amdgpu_fence_emit()ifdma_fence_wait()fails and returns an errno, before returning the allocated memory for fence should be released.Fixes 3d2aca8c8620 ("drm/amdgpu: fix old fence check in amdgpu_fence_emit")Signed-off-by Navid Emamdoost <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +3
-1@@ -166,8 +166,10 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct dma_fence **f,if (old) { r =dma_fence_wait (old, false);dma_fence_put (old); -if (r) +if (r) { +dma_fence_put (fence);return r; + } } }