Skip to contentSkip to conversation

package/valijson: bump version to 0.2

PATCH New Santosh Multhalli 3 participants 3 messages Oct 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/valijson: bump version to 0.2

---
 package/valijson/Config.in     | 3 ++-
 package/valijson/valijson.hash | 2 +-
 package/valijson/valijson.mk   | 6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)
package/valijson/Config.in +2 -1
index 10721b3..cf9954c 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_VALIJSON
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_REGEX
+        select BR2_PACKAGE_CURLPP 
 	help
 	  Valijson is a header-only JSON Schema Validation library for
 	  C++. Valijson provides a simple validation API that allows
@@ -15,4 +16,4 @@ config BR2_PACKAGE_VALIJSON
 	  https://github.com/tristanpenman/valijson
 
 comment "valijson needs a toolchain w/ C++, threads, wchar  support"
-	depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+	depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR 
package/valijson/valijson.hash +1 -1
index cd34ecb..f245750 100644
@@ -1,2 +1,2 @@
 # Locally Computed:
-sha256  d22c1f8fe27d43e5a27aad1d3cbe9f1318ec28ccfa913e615663ed2bd6a5d063  valijson-0.1.tar.gz
+sha256  77dbebb40dab2e834557c2fcc39122cdb2d0fe26bf591c2b3e0df5a316a45592  valijson-0.2.tar.gz
package/valijson/valijson.mk +3 -3
index a804334..24e720e 100644
@@ -4,13 +4,13 @@
 #
 ################################################################################
 
-VALIJSON_VERSION = 0.1
+VALIJSON_VERSION = 0.2
 VALIJSON_SITE = $(call github,tristanpenman,valijson,v$(VALIJSON_VERSION))
 VALIJSON_LICENSE = BSD-2-Clause
 VALIJSON_LICENSE_FILES = LICENSE
 VALIJSON_INSTALL_STAGING = YES
 VALIJSON_INSTALL_TARGET = NO
-VALIJSON_DEPENDENCIES = boost
-VALIJSON_CONF_OPTS = -DINSTALL_HEADERS=TRUE
+VALIJSON_DEPENDENCIES = boost curlpp
+VALIJSON_CONF_OPTS = -Dvalijson_INSTALL_HEADERS=TRUE
 
 $(eval $(cmake-package))
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 package/valijson: bump version to 0.2

Santosh,

Quoted 1 line · Santosh Multhalli

Could you add some notes here describing the new curlpp dependency and make file change?

Quoted 12 lines
---
 package/valijson/Config.in     | 3 ++-
 package/valijson/valijson.hash | 2 +-
 package/valijson/valijson.mk   | 6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)
package/valijson/Config.in +0 -0
index 10721b3..cf9954c 100644

package/valijson/Config.in config BR2_PACKAGE_VALIJSON · line 8

Quoted 4 lines
package/valijson/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_VALIJSON
        depends on BR2_TOOLCHAIN_HAS_THREADS
        select BR2_PACKAGE_BOOST
        select BR2_PACKAGE_BOOST_REGEX
+        select BR2_PACKAGE_CURLPP

See above, probably need to describe this in the commit description.

package/valijson/Config.in config BR2_PACKAGE_VALIJSON · line 19

Quoted 9 lines
package/valijson/Config.in +1 -1
        help
          Valijson is a header-only JSON Schema Validation library for
          C++. Valijson provides a simple validation API that allows
@@ -15,4 +16,4 @@ config BR2_PACKAGE_VALIJSON
          https://github.com/tristanpenman/valijson
 
 comment "valijson needs a toolchain w/ C++, threads, wchar  support"
-       depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+       depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Was this formatting change found manually? If so, could you run ./utils/check-package package/valijson/* to validate against the schema?

package/valijson/valijson.hash line 2

Quoted 8 lines
package/valijson/valijson.hash +1 -1
index cd34ecb..f245750 100644
@@ -1,2 +1,2 @@
 # Locally Computed:
-sha256  d22c1f8fe27d43e5a27aad1d3cbe9f1318ec28ccfa913e615663ed2bd6a5d063  valijson-0.1.tar.gz
+sha256  77dbebb40dab2e834557c2fcc39122cdb2d0fe26bf591c2b3e0df5a316a45592  valijson-0.2.tar.gz

Suggest adding a license file hash (for example, see package/libcurl/libcurl.hash)

Quoted 9 lines
package/valijson/valijson.mk +0 -1
index a804334..24e720e 100644
@@ -4,13 +4,13 @@
 #
 ################################################################################
 
-VALIJSON_VERSION = 0.1

package/valijson/valijson.mk line 14

Quoted 10 lines
package/valijson/valijson.mk +3 -2
+VALIJSON_VERSION = 0.2
 VALIJSON_SITE = $(call github,tristanpenman,valijson,v$(VALIJSON_VERSION))
 VALIJSON_LICENSE = BSD-2-Clause
 VALIJSON_LICENSE_FILES = LICENSE
 VALIJSON_INSTALL_STAGING = YES
 VALIJSON_INSTALL_TARGET = NO
-VALIJSON_DEPENDENCIES = boost
-VALIJSON_CONF_OPTS = -DINSTALL_HEADERS=TRUE
+VALIJSON_DEPENDENCIES = boost curlpp
+VALIJSON_CONF_OPTS = -Dvalijson_INSTALL_HEADERS=TRUE

See above, probably need to describe this in the commit description.

Thanks for the bump!

#2 lore raw

PATCH 1/1 package/valijson: bump version to 0.2

In reply to Santosh Multhalli

Hello Santosh,

Quoted 12 lines · Santosh Multhalli
---
 package/valijson/Config.in     | 3 ++-
 package/valijson/valijson.hash | 2 +-
 package/valijson/valijson.mk   | 6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)
package/valijson/Config.in +0 -0
index 10721b3..cf9954c 100644

package/valijson/Config.in config BR2_PACKAGE_VALIJSON · line 8

Quoted 4 lines
package/valijson/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_VALIJSON
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_REGEX
+        select BR2_PACKAGE_CURLPP

Indent should be done with one tab (instead of spaces) and the line contains a trailing space...

package/valijson/Config.in config BR2_PACKAGE_VALIJSON · line 19

Quoted 9 lines
package/valijson/Config.in +1 -1
 	help
 	  Valijson is a header-only JSON Schema Validation library for
 	  C++. Valijson provides a simple validation API that allows
@@ -15,4 +16,4 @@ config BR2_PACKAGE_VALIJSON
 	  https://github.com/tristanpenman/valijson
 
 comment "valijson needs a toolchain w/ C++, threads, wchar  support"
-	depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+	depends on !BR2_INSTALL_LIBSTDCPP  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Unneeded change (adding trailing space)...

Maybe try to run ./utils/check-package ;-)

Regards,
Peter

Quoted 29 lines
package/valijson/valijson.hash +1 -1
index cd34ecb..f245750 100644
@@ -1,2 +1,2 @@
 # Locally Computed:
-sha256  d22c1f8fe27d43e5a27aad1d3cbe9f1318ec28ccfa913e615663ed2bd6a5d063  valijson-0.1.tar.gz
+sha256  77dbebb40dab2e834557c2fcc39122cdb2d0fe26bf591c2b3e0df5a316a45592  valijson-0.2.tar.gz
package/valijson/valijson.mk +3 -3
index a804334..24e720e 100644
@@ -4,13 +4,13 @@
 #
 ################################################################################
 
-VALIJSON_VERSION = 0.1
+VALIJSON_VERSION = 0.2
 VALIJSON_SITE = $(call github,tristanpenman,valijson,v$(VALIJSON_VERSION))
 VALIJSON_LICENSE = BSD-2-Clause
 VALIJSON_LICENSE_FILES = LICENSE
 VALIJSON_INSTALL_STAGING = YES
 VALIJSON_INSTALL_TARGET = NO
-VALIJSON_DEPENDENCIES = boost
-VALIJSON_CONF_OPTS = -DINSTALL_HEADERS=TRUE
+VALIJSON_DEPENDENCIES = boost curlpp
+VALIJSON_CONF_OPTS = -Dvalijson_INSTALL_HEADERS=TRUE
 
 $(eval $(cmake-package))