Skip to contentSkip to conversation

cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

PATCH In review Ben Dooks (Codethink) 3 participants 3 messages Oct 22, 2019 Generic architecture topology

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

The parse_acpi_topology() is not declared anywhere which causes the following sparse warning:

drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?

---
Cc: Sudeep Holla <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 include/linux/arch_topology.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/arch_topology.h +1 -0
index 42f2b5126094..3015ecbb90b1 100644
@@ -57,6 +57,7 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
 void update_siblings_masks(unsigned int cpu);
 void remove_cpu_topology(unsigned int cpuid);
 void reset_cpu_topology(void);
+int parse_acpi_topology(void);
 #endif
 
 #endif /* _LINUX_ARCH_TOPOLOGY_H_ */
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ben Dooks (Codethink)

The parse_acpi_topology() is not declared anywhere which causes the following sparse warning:

drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?

---
Cc: Sudeep Holla <[email protected]>

Hi Greg,

Can you pick this up ? Thanks.

--
Regards,
Sudeep

#2 lore raw
Quoted 10 lines · Sudeep Holla
Quoted 8 lines · Ben Dooks (Codethink)

The parse_acpi_topology() is not declared anywhere which causes the following sparse warning:

drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?

---
Cc: Sudeep Holla <[email protected]>

Quoted 5 lines

Hi Greg,

Can you pick this up ? Thanks.

Ok, I'll add it to the queue, give me a week to get to it, thanks.

greg k-h