Skip to contentSkip to conversation

mm: fix comments based on per-node memcg

PATCH In review Hao Lee 3 participants 3 messages Oct 22, 2019 memcg

lore
Share & tools
lore

Hao Lee

author
#0 lore raw

PATCH 1/1 mm: fix comments based on per-node memcg

These comments should be updated as memcg limit enforcement has been moved from zones to nodes.

---
 include/linux/memcontrol.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
include/linux/memcontrol.h +2 -3
index ae703ea3ef48..12c29f74c02a 100644
@@ -112,7 +112,7 @@ struct memcg_shrinker_map {
 };
 
 /*
- * per-zone information in memory controller.
+ * per-node information in memory controller.
  */
 struct mem_cgroup_per_node {
 	struct lruvec		lruvec;
@@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
  * @memcg: memcg of the wanted lruvec
  *
  * Returns the lru list vector holding pages for a given @node or a given
- * @memcg and @zone. This can be the node lruvec, if the memory controller
- * is disabled.
+ * @memcg. This can be the node lruvec, if the memory controller is disabled.
  */
 static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
 				struct mem_cgroup *memcg)
Signature · 1 line
2.14.5
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Hao Lee

These comments should be updated as memcg limit enforcement has been moved from zones to nodes.

Thanks!

Quoted 30 lines
---
 include/linux/memcontrol.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
include/linux/memcontrol.h +2 -3
index ae703ea3ef48..12c29f74c02a 100644
@@ -112,7 +112,7 @@ struct memcg_shrinker_map {
 };
 
 /*
- * per-zone information in memory controller.
+ * per-node information in memory controller.
  */
 struct mem_cgroup_per_node {
 	struct lruvec		lruvec;
@@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
  * @memcg: memcg of the wanted lruvec
  *
  * Returns the lru list vector holding pages for a given @node or a given
- * @memcg and @zone. This can be the node lruvec, if the memory controller
- * is disabled.
+ * @memcg. This can be the node lruvec, if the memory controller is disabled.
  */
 static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
 				struct mem_cgroup *memcg)
Signature · 1 line
2.14.5
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Hao Lee
Quoted 4 lines · Hao Lee

These comments should be updated as memcg limit enforcement has been moved from zones to nodes.

Quoted 29 lines
---
 include/linux/memcontrol.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
include/linux/memcontrol.h +2 -3
index ae703ea3ef48..12c29f74c02a 100644
@@ -112,7 +112,7 @@ struct memcg_shrinker_map {
 };
 
 /*
- * per-zone information in memory controller.
+ * per-node information in memory controller.
  */
 struct mem_cgroup_per_node {
 	struct lruvec		lruvec;
@@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
  * @memcg: memcg of the wanted lruvec
  *
  * Returns the lru list vector holding pages for a given @node or a given
- * @memcg and @zone. This can be the node lruvec, if the memory controller
- * is disabled.
+ * @memcg. This can be the node lruvec, if the memory controller is disabled.
  */
 static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
 				struct mem_cgroup *memcg)
Signature · 1 line
2.14.5
Signature · 2 lines
Michal Hocko
SUSE Labs