Skip to contentSkip to conversation

package/ofono: use target ell library if enabled

PATCH New Nicolas Serafini 2 participants 3 messages Oct 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ofono: use target ell library if enabled

---
 package/ofono/ofono.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/ofono/ofono.mk +3 -1
index ce05dfcadf..85e249a233 100644
@@ -49,7 +49,9 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
-# required by 0003-build-Add-check-for-explicit_bzero-support.patch
+ifeq ($(BR2_PACKAGE_ELL),y)
 OFONO_AUTORECONF = YES
+OFONO_CONF_OPTS += --enable-external-ell
+endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/ofono: use target ell library if enabled

Quoted 10 lines · On Tue, 22 Oct 2019 10:48:31 +0000 Nicolas Serafini…
---
 package/ofono/ofono.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/ofono/ofono.mk +0 -0
index ce05dfcadf..85e249a233 100644

package/ofono/ofono.mk else · line 52

Quoted 4 lines
package/ofono/ofono.mk +0 -1
@@ -49,7 +49,9 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
-# required by 0003-build-Add-check-for-explicit_bzero-support.patch

Dropping this comment is correct, because indeed this patch no longer exists.

package/ofono/ofono.mk else · line 53

Quoted 2 lines
package/ofono/ofono.mk +1 -0
+ifeq ($(BR2_PACKAGE_ELL),y)
 OFONO_AUTORECONF = YES

But why are you keeping AUTORECONF = YES here ?

Also, dropping autoreconf should be in a separate patch.

package/ofono/ofono.mk else · line 54

Quoted 1 line
package/ofono/ofono.mk +1 -0
+OFONO_CONF_OPTS += --enable-external-ell

You forgot:

OFONO_DEPENDENCIES += ell
else
OFONO_CONF_OPTS += --disable-external-ell

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/ofono: use target ell library if enabled

Hello Thomas,

Quoted 21 lines · On Tue, 22 Oct 2019 13:59:39 +0200 Thomas Petazzoni…
Quoted 10 lines · On Tue, 22 Oct 2019 10:48:31 +0000 Nicolas Serafini…
---
 package/ofono/ofono.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/ofono/ofono.mk +0 -0
index ce05dfcadf..85e249a233 100644

package/ofono/ofono.mk else · line 52

Quoted 4 lines
package/ofono/ofono.mk +0 -1
@@ -49,7 +49,9 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
-# required by 0003-build-Add-check-for-explicit_bzero-support.patch

Dropping this comment is correct, because indeed this patch no longer exists.

Quoted 6 lines

package/ofono/ofono.mk else · line 53

Quoted 2 lines
package/ofono/ofono.mk +1 -0
+ifeq ($(BR2_PACKAGE_ELL),y)
 OFONO_AUTORECONF = YES

But why are you keeping AUTORECONF = YES here ?

Also, dropping autoreconf should be in a separate patch.

Yeah, you're absolutely right, I don't know why I left that.

Quoted 8 lines

package/ofono/ofono.mk else · line 54

Quoted 2 lines
package/ofono/ofono.mk +1 -0
+OFONO_CONF_OPTS += --enable-external-ell

You forgot:

OFONO_DEPENDENCIES += ell
else
OFONO_CONF_OPTS += --disable-external-ell

I'm going to fix it in a new patch.

Thank you for your review.

Nicolas

Quoted 4 lines

Thanks,

Thomas