ipmi: Fix memory leak in __ipmi_bmc_register
PATCH 1/1 ipmi: Fix memory leak in __ipmi_bmc_register
In the impelementation of __ipmi_bmc_register() the allocated memory for bmc should be released in case ida_simple_get() fails.
Fixes 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/char/ipmi/ipmi_msghandler.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/char/ipmi/ipmi_msghandler.c +4 -1
@@ -3031,8 +3031,11 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, bmc->pdev.name ="ipmi_bmc" ; rv =ida_simple_get (&ipmi_bmc_ida,0 ,0 ,GFP_KERNEL ); -if (rv <0 ) +if (rv <0 ) { +kfree (bmc); goto out; + } + bmc->pdev.dev.driver = &ipmidriver.driver; bmc->pdev.id = rv; bmc->pdev.dev.release = release_bmc_device;
Signature · 1 line
2.17.1
Quoted 2 lines · Navid Emamdoost
In the impelementation of
__ipmi_bmc_register()the allocated memory for bmc should be released in caseida_simple_get()fails.
Thanks, queued for next merge window.
-corey
Quoted 27 lines
Fixes 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")Signed-off-by Navid Emamdoost <[email protected]>--- drivers/char/ipmi/ipmi_msghandler.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/char/ipmi/ipmi_msghandler.c +4
-1@@ -3031,8 +3031,11 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, bmc->pdev.name ="ipmi_bmc" ; rv =ida_simple_get (&ipmi_bmc_ida,0 ,0 ,GFP_KERNEL ); -if (rv <0 ) +if (rv <0 ) { +kfree (bmc); goto out; + } + bmc->pdev.dev.driver = &ipmidriver.driver; bmc->pdev.id = rv; bmc->pdev.dev.release = release_bmc_device;Signature · 1 line
2.17.1