Skip to contentSkip to conversation

ARM: dts: dra7: add vpe nodes

PATCH In review Benoit Parrot 3 participants 13 messages Oct 9, 2019 – Oct 22, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: dra7: add vpe nodes

This patch series adds the needed clkctrl and ty-sysc nodes for VPE module. We also document the VPE DT bindings.

Benoit Parrot (3):
dt-bindings: media: ti-vpe: Document VPE driver
ARM: dts: dra7: add vpe clkctrl node
ARM: dts: dra7: Add ti-sysc node for VPE

 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 arch/arm/boot/dts/dra7-l4.dtsi                | 30 ++++++++++--
 arch/arm/boot/dts/dra7xx-clocks.dtsi          | 18 ++++++-
 drivers/clk/ti/clk-7xx.c                      |  6 +++
 include/dt-bindings/clock/dra7.h              | 10 ++++
 6 files changed, 108 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 dt-bindings: media: ti-vpe: Document VPE driver

Device Tree bindings for the Video Processing Engine (VPE) driver.

---
 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt
Documentation/devicetree/bindings/media/ti-vpe.txt new file +48 -0
new file mode 100644
index 000000000000..b2942fa8c3ea
@@ -0,0 +1,48 @@
+Texas Instruments DRA7x VIDEO PROCESSING ENGINE (VPE)
+------------------------------------------------------
+
+The Video Processing Engine (VPE) is a key component for image post
+processing applications. VPE consist of a single memory to memory
+path which can perform chroma up/down sampling, deinterlacing,
+scaling and color space conversion.
+
+Required properties:
+- compatible: must be "ti,vpe"
+- reg:	physical base address and length of the registers set for the 4
+	memory regions required;
+- reg-names: name associated with the memory regions described is <reg>;
+- interrupts: should contain IRQ line for VPE;
+
+Example:
+
+	target-module@1d0010 {                  /* 0x489d0000, ap 27 30.0 */
+		compatible = "ti,sysc-omap4", "ti,sysc";
+		reg = <0x1d0010 0x4>;
+		reg-names = "sysc";
+		ti,sysc-midle = <SYSC_IDLE_FORCE>,
+				<SYSC_IDLE_NO>,
+				<SYSC_IDLE_SMART>;
+		ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+				<SYSC_IDLE_NO>,
+				<SYSC_IDLE_SMART>;
+		clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>;
+		clock-names = "fck";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x0 0x1d0000 0x10000>;
+
+		vpe: vpe@0 {
+			compatible = "ti,vpe";
+			reg = <0x0000 0x120>,
+			      <0x0700 0x80>,
+			      <0x5700 0x18>,
+			      <0xd000 0x400>;
+			reg-names = "vpe_top",
+				    "sc",
+				    "csc",
+				    "vpdma";
+			interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+	};
MAINTAINERS +1 -0
index 8598f49fa2c8..63dcda51f8ae 100644
@@ -16299,6 +16299,7 @@ W:	http://linuxtv.org/
 Q:	http://patchwork.linuxtv.org/project/linux-media/list/
 S:	Maintained
 F:	drivers/media/platform/ti-vpe/
+F:	Documentation/devicetree/bindings/media/ti-vpe.txt
 
 TI WILINK WIRELESS DRIVERS
 L:	[email protected]
Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [Patch 1/3] dt-bindings: media: ti-vpe: Document VPE driver

Quoted 8 lines · Benoit Parrot

Device Tree bindings for the Video Processing Engine (VPE) driver.

---
 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt

Please convert to DT schema format.

Quoted 7 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +0 -0
new file mode 100644
index 000000000000..b2942fa8c3ea

Documentation/devicetree/bindings/media/ti-vpe.txt line 10

Quoted 10 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +10 -0
@@ -0,0 +1,48 @@
+Texas Instruments DRA7x VIDEO PROCESSING ENGINE (VPE)
+------------------------------------------------------
+
+The Video Processing Engine (VPE) is a key component for image post
+processing applications. VPE consist of a single memory to memory
+path which can perform chroma up/down sampling, deinterlacing,
+scaling and color space conversion.
+
+Required properties:
+- compatible: must be "ti,vpe"

Needs to have SoC specific compatibles.

Documentation/devicetree/bindings/media/ti-vpe.txt line 13

Quoted 3 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +3 -0
+- reg:	physical base address and length of the registers set for the 4
+	memory regions required;
+- reg-names: name associated with the memory regions described is <reg>;

The names need to be documented.

Quoted 9 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +9 -0
+- interrupts: should contain IRQ line for VPE;
+
+Example:
+
+	target-module@1d0010 {                  /* 0x489d0000, ap 27 30.0 */
+		compatible = "ti,sysc-omap4", "ti,sysc";
+		reg = <0x1d0010 0x4>;
+		reg-names = "sysc";
+		ti,sysc-midle = <SYSC_IDLE_FORCE>,

Documentation/devicetree/bindings/media/ti-vpe.txt line 32

Quoted 10 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +10 -0
+				<SYSC_IDLE_NO>,
+				<SYSC_IDLE_SMART>;
+		ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+				<SYSC_IDLE_NO>,
+				<SYSC_IDLE_SMART>;
+		clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>;
+		clock-names = "fck";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x0 0x1d0000 0x10000>;

All this is outside the scope of this binding.

Quoted 5 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +5 -0
+
+		vpe: vpe@0 {
+			compatible = "ti,vpe";
+			reg = <0x0000 0x120>,
+			      <0x0700 0x80>,

Documentation/devicetree/bindings/media/ti-vpe.txt line 46

Quoted 10 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +9 -0
+			      <0x5700 0x18>,
+			      <0xd000 0x400>;
+			reg-names = "vpe_top",
+				    "sc",
+				    "csc",
+				    "vpdma";
+			interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
 
+			#address-cells = <1>;
+			#size-cells = <0>;

Not documented, nor needed as there are no child nodes.

Quoted 17 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +2 -0
+		};
+	};
MAINTAINERS +1 -0
index 8598f49fa2c8..63dcda51f8ae 100644
@@ -16299,6 +16299,7 @@ W:	http://linuxtv.org/
 Q:	http://patchwork.linuxtv.org/project/linux-media/list/
 S:	Maintained
 F:	drivers/media/platform/ti-vpe/
+F:	Documentation/devicetree/bindings/media/ti-vpe.txt
 
 TI WILINK WIRELESS DRIVERS
 L:	[email protected]
Signature · 1 line
2.17.1
#3 lore raw

Re: [Patch 1/3] dt-bindings: media: ti-vpe: Document VPE driver

Rob Herring <[email protected]> wrote on Tue [2019-Oct-15 17:29:47 -0500]:

Quoted 11 lines · Benoit Parrot
Quoted 8 lines

Device Tree bindings for the Video Processing Engine (VPE) driver.

---
 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt

Please convert to DT schema format.

I can do that.
Before posting/merging a .yaml, are we supposed to be able to pass these?

# make dt_binding_check
# make dtbs_check

Because currently with 5.4-rc3 these fails.

Is there a way to run these "test command" target a specific .yaml and not the whole set?

Quoted 12 lines
Quoted 12 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +4 -0
new file mode 100644
index 000000000000..b2942fa8c3ea
@@ -0,0 +1,48 @@
+Texas Instruments DRA7x VIDEO PROCESSING ENGINE (VPE)
+------------------------------------------------------
+
+The Video Processing Engine (VPE) is a key component for image post
Quoted 8 lines

Documentation/devicetree/bindings/media/ti-vpe.txt line 10

Quoted 6 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +6 -0
+processing applications. VPE consist of a single memory to memory
+path which can perform chroma up/down sampling, deinterlacing,
+scaling and color space conversion.
+
+Required properties:
+- compatible: must be "ti,vpe"

Needs to have SoC specific compatibles.

Yes, I'll fix that.

Quoted 6 lines

Documentation/devicetree/bindings/media/ti-vpe.txt line 13

Quoted 4 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +3 -0
+- reg:	physical base address and length of the registers set for the 4
+	memory regions required;
+- reg-names: name associated with the memory regions described is <reg>;

The names need to be documented.

Ok.

Quoted 14 lines
Quoted 14 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +13 -0
+- interrupts: should contain IRQ line for VPE;
+
+Example:
+
+	target-module@1d0010 {                  /* 0x489d0000, ap 27 30.0 */
+		compatible = "ti,sysc-omap4", "ti,sysc";
+		reg = <0x1d0010 0x4>;
+		reg-names = "sysc";
+		ti,sysc-midle = <SYSC_IDLE_FORCE>,
+				<SYSC_IDLE_NO>,
+				<SYSC_IDLE_SMART>;
+		ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+				<SYSC_IDLE_NO>,
Quoted 8 lines

Documentation/devicetree/bindings/media/ti-vpe.txt line 32

Quoted 6 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +6 -0
+				<SYSC_IDLE_SMART>;
+		clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>;
+		clock-names = "fck";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x0 0x1d0000 0x10000>;

All this is outside the scope of this binding.

OK I was not sure if the whole interconnect thing was needed in the example or not.

Quoted 14 lines
Quoted 13 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +12 -0
+
+		vpe: vpe@0 {
+			compatible = "ti,vpe";
+			reg = <0x0000 0x120>,
+			      <0x0700 0x80>,
+			      <0x5700 0x18>,
+			      <0xd000 0x400>;
+			reg-names = "vpe_top",
+				    "sc",
+				    "csc",
+				    "vpdma";
+			interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
Quoted 4 lines

Documentation/devicetree/bindings/media/ti-vpe.txt line 46

Quoted 2 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +2 -0
+			#address-cells = <1>;
+			#size-cells = <0>;

Not documented, nor needed as there are no child nodes.

Yeah, I'll remove that.

Quoted 12 lines

MAINTAINERS W: http://linuxtv.org/ · line 16302

Quoted 12 lines
Documentation/devicetree/bindings/media/ti-vpe.txt new file +2 -0
+		};
+	};
MAINTAINERS +1 -0
index 8598f49fa2c8..63dcda51f8ae 100644
@@ -16299,6 +16299,7 @@ W:	http://linuxtv.org/
 Q:	http://patchwork.linuxtv.org/project/linux-media/list/
 S:	Maintained
 F:	drivers/media/platform/ti-vpe/
+F:	Documentation/devicetree/bindings/media/ti-vpe.txt

Now with the dt_schemas, I noticed that the maintainer's name is part of the yaml file. Do we still need to add this to the MAINTAINERS file as well?

Benoit

Quoted 6 lines
Quoted 6 lines
MAINTAINERS +0 -0
 TI WILINK WIRELESS DRIVERS
 L:	[email protected]
Signature · 1 line
2.17.1
maintainer
#4 lore raw

Re: [Patch 1/3] dt-bindings: media: ti-vpe: Document VPE driver

Quoted 12 lines · Benoit Parrot

Rob Herring <[email protected]> wrote on Tue [2019-Oct-15 17:29:47 -0500]:

Quoted 10 lines · Benoit Parrot
Quoted 8 lines

Device Tree bindings for the Video Processing Engine (VPE) driver.

---
 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt
Quoted 6 lines
Quoted 1 line

Please convert to DT schema format.

I can do that.
Before posting/merging a .yaml, are we supposed to be able to pass these?

# make dt_binding_check
# make dtbs_check

Only dt_binding_check needs to be warning free. It is good to test your schema with dtbs_check and make sure any warnings seem valid.

Quoted 1 line

Because currently with 5.4-rc3 these fails.

Yeah, still waiting on regulator and media fixes. :( linux-next is fixed.

Quoted 2 lines

Is there a way to run these "test command" target a specific .yaml and not the whole set?

Yes, it's documented in writing-schema.rst. Use DT_SCHEMA_FILES to test just your schema file.

[...]

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
MAINTAINERS +0 -0
index 8598f49fa2c8..63dcda51f8ae 100644
@@ -16299,6 +16299,7 @@ W:  http://linuxtv.org/
Quoted 8 lines
Quoted 4 lines

MAINTAINERS W: http://linuxtv.org/ · line 16302

Quoted 4 lines
MAINTAINERS +1 -0
 Q: http://patchwork.linuxtv.org/project/linux-media/list/
 S: Maintained
 F: drivers/media/platform/ti-vpe/
+F: Documentation/devicetree/bindings/media/ti-vpe.txt

Now with the dt_schemas, I noticed that the maintainer's name is part of the yaml file. Do we still need to add this to the MAINTAINERS file as well?

Within the schema is really preparation for having schema outside of the kernel tree and because lots of bindings don't have a MAINTAINERS entry. So yes, you can still have both.

Rob

#5 lore raw

PATCH 2/3 ARM: dts: dra7: add vpe clkctrl node

In reply to Benoit Parrot

Add clkctrl nodes for VPE module.

---
 arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
 drivers/clk/ti/clk-7xx.c             |  6 ++++++
 include/dt-bindings/clock/dra7.h     | 10 ++++++++++
 3 files changed, 32 insertions(+), 2 deletions(-)
arch/arm/boot/dts/dra7xx-clocks.dtsi +16 -2
index 93e1eb83bed9..d1c2406ec71c 100644
@@ -1591,10 +1591,10 @@
 
 	rtc_cm: rtc-cm@700 {
 		compatible = "ti,omap4-cm";
-		reg = <0x700 0x100>;
+		reg = <0x700 0x60>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0 0x700 0x100>;
+		ranges = <0 0x700 0x60>;
 
 		rtc_clkctrl: rtc-clkctrl@20 {
 			compatible = "ti,clkctrl";
@@ -1603,6 +1603,20 @@
 		};
 	};
 
+	vpe_cm: vpe-cm@760 {
+		compatible = "ti,omap4-cm";
+		reg = <0x760 0xc>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x760 0xc>;
+
+		vpe_clkctrl: vpe-clkctrl@0 {
+			compatible = "ti,clkctrl";
+			reg = <0x0 0xc>;
+			#clock-cells = <2>;
+		};
+	};
+
 };
 
 &cm_core {
drivers/clk/ti/clk-7xx.c +6 -0
index b57fe09b428b..5dd9cad07542 100644
@@ -146,6 +146,11 @@ static const struct omap_clkctrl_reg_data dra7_rtc_clkctrl_regs[] __initconst =
 	{ 0 },
 };
 
+static const struct omap_clkctrl_reg_data dra7_vpe_clkctrl_regs[] __initconst = {
+	{ DRA7_VPE_VPE_CLKCTRL, NULL, CLKF_HW_SUP, "dpll_core_h23x2_ck" },
+	{ 0 },
+};
+
 static const struct omap_clkctrl_reg_data dra7_coreaon_clkctrl_regs[] __initconst = {
 	{ DRA7_COREAON_SMARTREFLEX_MPU_CLKCTRL, NULL, CLKF_SW_SUP, "wkupaon_iclk_mux" },
 	{ DRA7_COREAON_SMARTREFLEX_CORE_CLKCTRL, NULL, CLKF_SW_SUP, "wkupaon_iclk_mux" },
@@ -769,6 +774,7 @@ const struct omap_clkctrl_data dra7_clkctrl_data[] __initconst = {
 	{ 0x4a005550, dra7_ipu_clkctrl_regs },
 	{ 0x4a005620, dra7_dsp2_clkctrl_regs },
 	{ 0x4a005720, dra7_rtc_clkctrl_regs },
+	{ 0x4a005760, dra7_vpe_clkctrl_regs },
 	{ 0x4a008620, dra7_coreaon_clkctrl_regs },
 	{ 0x4a008720, dra7_l3main1_clkctrl_regs },
 	{ 0x4a008920, dra7_ipu2_clkctrl_regs },
include/dt-bindings/clock/dra7.h +10 -0
index 72f2e8411523..2b765e579b2a 100644
@@ -29,6 +29,11 @@
 #define DRA7_RTC_CLKCTRL_INDEX(offset)	((offset) - DRA7_RTC_CLKCTRL_OFFSET)
 #define DRA7_RTCSS_CLKCTRL	DRA7_RTC_CLKCTRL_INDEX(0x44)
 
+/* vpe clocks */
+#define DRA7_VPE_CLKCTRL_OFFSET	0x60
+#define DRA7_VPE_CLKCTRL_INDEX(offset)	((offset) - DRA7_VPE_CLKCTRL_OFFSET)
+#define DRA7_VPE_CLKCTRL	DRA7_VPE_CLKCTRL_INDEX(0x64)
+
 /* coreaon clocks */
 #define DRA7_SMARTREFLEX_MPU_CLKCTRL	DRA7_CLKCTRL_INDEX(0x28)
 #define DRA7_SMARTREFLEX_CORE_CLKCTRL	DRA7_CLKCTRL_INDEX(0x38)
@@ -192,6 +197,11 @@
 /* rtc clocks */
 #define DRA7_RTC_RTCSS_CLKCTRL	DRA7_CLKCTRL_INDEX(0x44)
 
+/* vpe clocks */
+#define DRA7_VPE_CLKCTRL_OFFSET	0x60
+#define DRA7_VPE_CLKCTRL_INDEX(offset)	((offset) - DRA7_VPE_CLKCTRL_OFFSET)
+#define DRA7_VPE_VPE_CLKCTRL	DRA7_VPE_CLKCTRL_INDEX(0x64)
+
 /* coreaon clocks */
 #define DRA7_COREAON_SMARTREFLEX_MPU_CLKCTRL	DRA7_CLKCTRL_INDEX(0x28)
 #define DRA7_COREAON_SMARTREFLEX_CORE_CLKCTRL	DRA7_CLKCTRL_INDEX(0x38)
Signature · 1 line
2.17.1
#6 lore raw

PATCH 3/3 ARM: dts: dra7: Add ti-sysc node for VPE

In reply to Benoit Parrot

Add VPE node as a child of l4 interconnect in order for it to probe using ti-sysc.

---
 arch/arm/boot/dts/dra7-l4.dtsi | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)
arch/arm/boot/dts/dra7-l4.dtsi +27 -3
index ea0e7c19eb4e..d876c1754f33 100644
@@ -4158,12 +4158,36 @@
 			ranges = <0x0 0x1b0000 0x10000>;
 		};
 
-		target-module@1d0000 {			/* 0x489d0000, ap 27 30.0 */
-			compatible = "ti,sysc";
-			status = "disabled";
+		target-module@1d0010 {			/* 0x489d0000, ap 27 30.0 */
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0x1d0010 0x4>;
+			reg-names = "sysc";
+			ti,sysc-midle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>;
+			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>;
+			clocks = <&vpe_clkctrl DRA7_VPE_VPE_CLKCTRL 0>;
+			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0x0 0x1d0000 0x10000>;
+
+			vpe: vpe@0 {
+				compatible = "ti,vpe";
+				reg = <0x0000 0x120>,
+				      <0x0700 0x80>,
+				      <0x5700 0x18>,
+				      <0xd000 0x400>;
+				reg-names = "vpe_top",
+					    "sc",
+					    "csc",
+					    "vpdma";
+				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+			};
 		};
 	};
 };
Signature · 1 line
2.17.1
#7 lore raw
In reply to Benoit Parrot

Tony,

Ping,

I already had comments from Rob but i would like your feedback before sending a v2.

Regards,
Benoit

Benoit Parrot <[email protected]> wrote on Wed [2019-Oct-09 12:56:25 -0500]:

Quoted 20 lines

This patch series adds the needed clkctrl and ty-sysc nodes for VPE module. We also document the VPE DT bindings.

Benoit Parrot (3):
dt-bindings: media: ti-vpe: Document VPE driver
ARM: dts: dra7: add vpe clkctrl node
ARM: dts: dra7: Add ti-sysc node for VPE

 .../devicetree/bindings/media/ti-vpe.txt      | 48 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 arch/arm/boot/dts/dra7-l4.dtsi                | 30 ++++++++++--
 arch/arm/boot/dts/dra7xx-clocks.dtsi          | 18 ++++++-
 drivers/clk/ti/clk-7xx.c                      |  6 +++
 include/dt-bindings/clock/dra7.h              | 10 ++++
 6 files changed, 108 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt
Signature · 1 line
2.17.1
#8 lore raw
Quoted 6 lines · Benoit Parrot

Tony,

Ping,

I already had comments from Rob but i would like your feedback before sending a v2.

Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :)

Regards,

Tony

#9 lore raw

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:30:48 -0700]:

Quoted 10 lines · Benoit Parrot
Quoted 6 lines

Tony,

Ping,

I already had comments from Rob but i would like your feedback before sending a v2.

Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :)

Would I need to split off the clk*.c/.h as well here though?

Benoit

Quoted 4 lines

Regards,

Tony

#10 lore raw
Quoted 6 lines · Benoit Parrot

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:30:48 -0700]:

Quoted 5 lines · Benoit Parrot
Quoted 4 lines

Tony,

Ping,

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I already had comments from Rob but i would like your feedback before sending a v2.

Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :)

Would I need to split off the clk*.c/.h as well here though?

Yeah please do patches with just drivers/clk/ti and include/dt-bindings/clock changes in them. then Tero can queue them into an immutable branch that I can merge in too and use as a base for the dts changes.

Regards,

Tony

#11 lore raw

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:37:54 -0700]:

Quoted 13 lines · Benoit Parrot
Quoted 12 lines

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:30:48 -0700]:

Quoted 10 lines · Benoit Parrot
Quoted 6 lines

Tony,

Ping,

I already had comments from Rob but i would like your feedback before sending a v2.

Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :)

Quoted 6 lines
Quoted 1 line

Would I need to split off the clk*.c/.h as well here though?

Yeah please do patches with just drivers/clk/ti and include/dt-bindings/clock changes in them. then Tero can queue them into an immutable branch that I can merge in too and use as a base for the dts changes.

Although the .h is in include/dt-binding. Does it still belong in the same patch as drivers/clk/ti/clk-7xx.c then?

Just making sure....

Quoted 4 lines

Regards,

Tony

#12 lore raw
Quoted 21 lines · Benoit Parrot

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:37:54 -0700]:

Quoted 13 lines · Benoit Parrot
Quoted 12 lines

Tony Lindgren <[email protected]> wrote on Tue [2019-Oct-22 09:30:48 -0700]:

Quoted 10 lines · Benoit Parrot
Quoted 6 lines

Tony,

Ping,

I already had comments from Rob but i would like your feedback before sending a v2.

Looks good to me in general other than what Rob commented on. Did not spot any node naming issues here :)

Quoted 6 lines
Quoted 1 line

Would I need to split off the clk*.c/.h as well here though?

Yeah please do patches with just drivers/clk/ti and include/dt-bindings/clock changes in them. then Tero can queue them into an immutable branch that I can merge in too and use as a base for the dts changes.

Quoted 4 lines

Although the .h is in include/dt-binding. Does it still belong in the same patch as drivers/clk/ti/clk-7xx.c then?

Just making sure....

Yes if it's needed to compile the drivers/clk/ti patch. Otherwise it can stay with the dts changes.

Regards,

Tony