Skip to contentSkip to conversation

package/ofono: remove forced autoreconf

PATCH New Nicolas Serafini 2 participants 5 messages Oct 22, 2019 – Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 package/ofono: remove forced autoreconf

The patch that required an autoreconf is no longer there.

---
 package/ofono/ofono.mk | 2 --
 1 file changed, 2 deletions(-)
package/ofono/ofono.mk +0 -2
index ce05dfcadf..756998687b 100644
@@ -49,7 +49,5 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
-# required by 0003-build-Add-check-for-explicit_bzero-support.patch
-OFONO_AUTORECONF = YES
 
 $(eval $(autotools-package))
Signature · 1 line
2.23.0
#1 lore raw

PATCH v2 2/2 package/ofono: use target ell library if enabled

---
Changes v1 -> v2:
- Remove forced autoreconf into another patch
- Add missing OFONO_DEPENDENCIES
- Add disable option if ell is not selected

---
 package/ofono/ofono.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/ofono/ofono.mk +6 -0
index 756998687b..00c5ffbbe4 100644
@@ -49,5 +49,11 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
+ifeq ($(BR2_PACKAGE_ELL),y)
+OFONO_DEPENDENCIES += ell
+OFONO_CONF_OPTS += --enable-external-ell
+else
+OFONO_CONF_OPTS += --disable-external-ell
+endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.23.0
#2 lore raw

PATCH v2 2/2 package/ofono: use target ell library if enabled

Hello Nicolas,

package/ofono/ofono.mk else · line 57

Quoted 6 lines · On Tue, 22 Oct 2019 13:44:08 +0000 Nicolas Serafini…
package/ofono/ofono.mk +6 -0
+ifeq ($(BR2_PACKAGE_ELL),y)
+OFONO_DEPENDENCIES += ell
+OFONO_CONF_OPTS += --enable-external-ell
+else
+OFONO_CONF_OPTS += --disable-external-ell
+endif

If I understand correctly the code, ell is in fact always needed by ofono. If ell is not available externally, it uses a bundled version of ell.

In this case, Buildroot prefers to always use the external library, so could you turn ell into a mandatory dependency of ofono, and pass --enable-external-ell unconditionally?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 2/2 package/ofono: use target ell library if enabled

Hello Thomas,

Quoted 5 lines · On Tue, 22 Oct 2019 22:18:00 +0200 Thomas Petazzoni…

Hello Nicolas,

On Tue, 22 Oct 2019 13:44:08 +0000
Nicolas Serafini <[email protected]> wrote:

Quoted 10 lines

package/ofono/ofono.mk else · line 57

Quoted 6 lines
package/ofono/ofono.mk +6 -0
+ifeq ($(BR2_PACKAGE_ELL),y)
+OFONO_DEPENDENCIES += ell
+OFONO_CONF_OPTS += --enable-external-ell
+else
+OFONO_CONF_OPTS += --disable-external-ell
+endif

If I understand correctly the code, ell is in fact always needed by ofono. If ell is not available externally, it uses a bundled version of ell.

Yes, that's right.

Quoted 4 lines

In this case, Buildroot prefers to always use the external library, so could you turn ell into a mandatory dependency of ofono, and pass --enable-external-ell unconditionally?

I also prefer to use only the external library.
In case of a bug it avoids maintaining a patch in two different packages. I'm preparing a v3.

Thanks

Nicolas

Quoted 4 lines

Thanks!

Thomas

#4 lore raw

PATCH v2 1/2 package/ofono: remove forced autoreconf

In reply to Nicolas Serafini
Quoted 6 lines · On Tue, 22 Oct 2019 13:44:07 +0000 Nicolas Serafini…

The patch that required an autoreconf is no longer there.

---
 package/ofono/ofono.mk | 2 --
 1 file changed, 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com