dmaengine: fsl-dpaa2-qdma: export the symbols
PATCH v2 1/1 dmaengine: fsl-dpaa2-qdma: export the symbols
The symbols were not exported leading to error:
WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-dpaa2-qdma/dpdmai.o see include/linux/module.h for more information
GZIP arch/arm64/boot/Image.gz
ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_set_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_tx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_attributes" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2
So export it.
---
Changed for v2:
- Rewrite the title and subject
drivers/dma/fsl-dpaa2-qdma/dpdmai.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/dma/fsl-dpaa2-qdma/dpdmai.c +12 -0
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 // Copyright 2019 NXP +#include <linux/module.h> #include <linux/types.h> #include <linux/io.h> #include <linux/fsl/mc.h>
@@ -90,6 +91,7 @@ int dpdmai_open(struct fsl_mc_io *mc_io, u32 cmd_flags,return 0 ; } +EXPORT_SYMBOL_GPL (dpdmai_open);/** * dpdmai_close() - Close the control session of the object
@@ -113,6 +115,7 @@ int dpdmai_close(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token)/* send command to mc*/ return mc_send_command (mc_io, &cmd); } +EXPORT_SYMBOL_GPL (dpdmai_close);/** * dpdmai_create() - Create the DPDMAI object
@@ -177,6 +180,7 @@ int dpdmai_enable(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token)/* send command to mc*/ return mc_send_command (mc_io, &cmd); } +EXPORT_SYMBOL_GPL (dpdmai_enable);/** * dpdmai_disable() - Disable the DPDMAI, stop sending and receiving frames.
@@ -197,6 +201,7 @@ int dpdmai_disable(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token)/* send command to mc*/ return mc_send_command (mc_io, &cmd); } +EXPORT_SYMBOL_GPL (dpdmai_disable);/** * dpdmai_reset() - Reset the DPDMAI, returns the object to initial state.
@@ -217,6 +222,7 @@ int dpdmai_reset(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token)/* send command to mc*/ return mc_send_command (mc_io, &cmd); } +EXPORT_SYMBOL_GPL (dpdmai_reset);/** * dpdmai_get_attributes() - Retrieve DPDMAI attributes.
@@ -252,6 +258,7 @@ int dpdmai_get_attributes(struct fsl_mc_io *mc_io, u32 cmd_flags,return 0 ; } +EXPORT_SYMBOL_GPL (dpdmai_get_attributes);/** * dpdmai_set_rx_queue() - Set Rx queue configuration
@@ -285,6 +292,7 @@ int dpdmai_set_rx_queue(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token,/* send command to mc*/ return mc_send_command (mc_io, &cmd); } +EXPORT_SYMBOL_GPL (dpdmai_set_rx_queue);/** * dpdmai_get_rx_queue() - Retrieve Rx queue attributes.
@@ -325,6 +333,7 @@ int dpdmai_get_rx_queue(struct fsl_mc_io *mc_io, u32 cmd_flags, u16 token,return 0 ; } +EXPORT_SYMBOL_GPL (dpdmai_get_rx_queue);/** * dpdmai_get_tx_queue() - Retrieve Tx queue attributes.
@@ -364,3 +373,6 @@ int dpdmai_get_tx_queue(struct fsl_mc_io *mc_io, u32 cmd_flags,return 0 ; } +EXPORT_SYMBOL_GPL (dpdmai_get_tx_queue); + +MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.9.5
Quoted 20 lines · Peng Ma
The symbols were not exported leading to error:
WARNING: modpost: missing
MODULE_LICENSE()indrivers/dma/fsl-dpaa2-qdma/dpdmai.oseeinclude/linux/module.hfor more information
GZIParch/arm64/boot/Image.gz
ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_set_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_tx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_get_attributes" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
ERROR: "dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
WARNING: "HYPERVISOR_platform_op" [vmlinux] is a staticEXPORT_SYMBOL_GPLmake[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2
Quoted 1 line
So export it.
Applied, thanks
Signature · 1 line
~Vinod
Quoted 40 lines
-----Original Message-----
From: Vinod Koul <[email protected]>
Sent: 2019年10月23日 13:09
To: Peng Ma <[email protected]>
Cc: [email protected]; Leo Li <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [next, v2] dmaengine: fsl-dpaa2-qdma: export the symbolsCaution: EXT Email
Quoted 3 lines · Peng Ma
The symbols were not exported leading to error:
WARNING: modpost: missing
MODULE_LICENSE()in
drivers/dma/fsl-dpaa2-qdma/dpdmai.oQuoted 3 lines
see
include/linux/module.hfor more information
GZIParch/arm64/boot/Image.gz
ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]undefined!
Quoted 1 line
ERROR: "
dpdmai_set_rx_queue"[
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!Quoted 1 line
ERROR: "
dpdmai_get_tx_queue"[
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!Quoted 1 line
ERROR: "
dpdmai_get_rx_queue"[
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!Quoted 1 line
ERROR: "
dpdmai_get_attributes"[
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!Quoted 1 line
ERROR: "
dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]undefined!
Quoted 1 line
ERROR: "
dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]undefined!
Quoted 1 line
ERROR: "
dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]undefined!
Quoted 1 line
ERROR: "
dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]undefined!
Quoted 1 line
WARNING: "
HYPERVISOR_platform_op" [vmlinux] is a static
EXPORT_SYMBOL_GPL
Quoted 8 lines
Quoted 6 lines
make[2]: *** [
__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2So export it.
Applied, thanks
[Peng Ma] Got it.
Thanks,
Peng
Quoted 3 lines
--
~Vinod