Skip to contentSkip to conversation

package/runc: add an option to build a non-static runc

PATCH New James Peach 2 participants 4 messages Oct 23, 2019 – Oct 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/runc: add an option to build a non-static runc

From: James Peach <[email protected]>

The systemd cgroup driver is compiled out of static builds of runc so some users will need a non-static build. Add an option to control whether the runc should be static or not, and default it to true for compatibility with existing configurations.

---
 package/runc/Config.in | 11 +++++++++++
 package/runc/runc.mk   |  6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
runc/Config.in +11 -0
index f181ee334f..ea932120b8 100644
@@ -10,6 +10,17 @@ config BR2_PACKAGE_RUNC
 
 	  https://github.com/opencontainers/runc
 
+if BR2_PACKAGE_RUNC
+
+config BR2_PACKAGE_RUNC_STATIC
+	bool "static runc binary"
+	default y
+	help
+	  Whether to make a static build of runc. This must be false
+	  for runc to be able to use the systemd cgroups driver.
+
+endif
+
 comment "runc needs a glibc or musl toolchain w/ threads"
 	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS && \
 		BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
runc/runc.mk +5 -1
index b858742905..4128afd53a 100644
@@ -13,7 +13,11 @@ RUNC_WORKSPACE = Godeps/_workspace
 
 RUNC_LDFLAGS = -X main.gitCommit=$(RUNC_VERSION)
 
-RUNC_TAGS = cgo static_build
+RUNC_TAGS = cgo
+
+ifeq ($(BR2_PACKAGE_RUNC_STATIC),y)
+RUNC_TAGS += static_build
+endif
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
 RUNC_TAGS += seccomp
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/runc: add an option to build a non-static runc

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"James" == James Peach <[email protected]> writes:

From: James Peach <[email protected]>
The systemd cgroup driver is compiled out of static builds of runc so some users will need a non-static build.

What does that driver exactly do? What distributions enable this?

Quoted 3 lines

Add an option to control whether the runc should be static or not, and default it to true for compatibility with existing configurations.

Does this then work when running a different libc inside/outside the containers?

If yes, what is the advantage of linking runc statically?

Quoted 52 lines
---
 package/runc/Config.in | 11 +++++++++++
 package/runc/runc.mk   |  6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
runc/Config.in +11 -0
index f181ee334f..ea932120b8 100644
@@ -10,6 +10,17 @@ config BR2_PACKAGE_RUNC
 
 	  https://github.com/opencontainers/runc
 
+if BR2_PACKAGE_RUNC
+
+config BR2_PACKAGE_RUNC_STATIC
+	bool "static runc binary"
+	default y
+	help
+	  Whether to make a static build of runc. This must be false
+	  for runc to be able to use the systemd cgroups driver.
+
+endif
+
 comment "runc needs a glibc or musl toolchain w/ threads"
 	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS && \
 		BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
runc/runc.mk +5 -1
index b858742905..4128afd53a 100644
@@ -13,7 +13,11 @@ RUNC_WORKSPACE = Godeps/_workspace
 
 RUNC_LDFLAGS = -X main.gitCommit=$(RUNC_VERSION)
 
-RUNC_TAGS = cgo static_build
+RUNC_TAGS = cgo
+
+ifeq ($(BR2_PACKAGE_RUNC_STATIC),y)
+RUNC_TAGS += static_build
+endif
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
 RUNC_TAGS += seccomp
Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/runc: add an option to build a non-static runc

Quoted 11 lines · Peter Korsgaard
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"James" == James Peach <[email protected]> writes:

From: James Peach <[email protected]>
The systemd cgroup driver is compiled out of static builds of runc so some users will need a non-static build.

What does that driver exactly do?

Instead of setting up the container by directly manipulating cgroupfs files, runc will call systemd DBUS APIs

Quoted 1 line

What distributions enable this?

I see that runc is linked dynamically on Fedora. Using the systemd cgroups driver is a pretty common recommendation for Kuberneted clusters (the option is plumbed through Kubelet, cri-o and containerd).

Quoted 8 lines
Quoted 3 lines

Add an option to control whether the runc should be static or not, and default it to true for compatibility with existing configurations.

Does this then work when running a different libc inside/outside the containers?

If yes, what is the advantage of linking runc statically?

I don?t know why this package was originally linking statically, which was why I kept the default. I didn?t want to break someone?s use case that I didn?t know about :)

Your question make we go check upstream, and the build tag was introduced to fix a build warning about a dependency on dlopen:

https://github.com/opencontainers/runc/commit/e9944d0f4cebd26f27fdb7407740c32a9194c386

However, I don?t think that upstream needs this any more so maybe I can remove the build tag from the systemd integration.

Quoted 57 lines
Quoted 54 lines

---
package/runc/Config.in | 11 +++++++++++
package/runc/runc.mk | 6 +++++-

2 files changed, 16 insertions(+), 1 deletion(-)
runc/Config.in +11 -0
index f181ee334f..ea932120b8 100644
@@ -10,6 +10,17 @@ config BR2_PACKAGE_RUNC
 
 	  https://github.com/opencontainers/runc
 
+if BR2_PACKAGE_RUNC
+
+config BR2_PACKAGE_RUNC_STATIC
+	bool "static runc binary"
+	default y
+	help
+	  Whether to make a static build of runc. This must be false
+	  for runc to be able to use the systemd cgroups driver.
+
+endif
+

comment "runc needs a glibc or musl toolchain w/ threads"

	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS && \
		BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
runc/runc.mk +5 -1
index b858742905..4128afd53a 100644
@@ -13,7 +13,11 @@ RUNC_WORKSPACE = Godeps/_workspace
 
 RUNC_LDFLAGS = -X main.gitCommit=$(RUNC_VERSION)
 
-RUNC_TAGS = cgo static_build
+RUNC_TAGS = cgo
+
+ifeq ($(BR2_PACKAGE_RUNC_STATIC),y)
+RUNC_TAGS += static_build
+endif
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)

RUNC_TAGS += seccomp

Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/runc: add an option to build a non-static runc

Quoted 7 lines · James Peach
Quoted 4 lines · Peter Korsgaard

[snip]

Quoted 9 lines
Quoted 1 line

If yes, what is the advantage of linking runc statically?

I don?t know why this package was originally linking statically, which was why I kept the default. I didn?t want to break someone?s use case that I didn?t know about :)

Your question make we go check upstream, and the build tag was introduced to fix a build warning about a dependency on dlopen:

https://github.com/opencontainers/runc/commit/e9944d0f4cebd26f27fdb7407740c32a9194c386

However, I don?t think that upstream needs this any more so maybe I can remove the build tag from the systemd integration.

I experimented a bit more with this. IIUC the Go builder for runc doesn?t actually build a static binary and the systemd driver build no longer fails when you do force a static binary, so I submitted a PR to upstream to remove the static_build build tag.

I think that we can just drop this patch. I?m just filtering out the bad build tag before I run buildroot. If upstream take my PR, this will be fixed when buildroot updates runc.

J