Skip to contentSkip to conversation

Revert "main: Fix for misleading error with negative chain priority"

PATCH New Phil Sutter 1 participant 1 message Oct 23, 2019 netfilter

lore
Share & tools
lore

Phil Sutter

author reviewer
#0 lore raw

PATCH 1/1 Revert "main: Fix for misleading error with negative chain priority"

This reverts commit 9fc71bc6b602c8706d1214e0100bcd7638c257e3.

Given that this change breaks typical commands like
'nft list ruleset -a' while on the other hand escaping of semicolons and (depending on shell) curly braces is still required, decision was made to not go with this solution.

---
 src/main.c                                           | 2 +-
 tests/shell/testcases/chains/0039negative_priority_0 | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100755 tests/shell/testcases/chains/0039negative_priority_0
src/main.c +1 -1
index 577850e54f68c..f77d8a820a028 100644
@@ -45,7 +45,7 @@ enum opt_vals {
 	OPT_NUMERIC_TIME	= 't',
 	OPT_INVALID		= '?',
 };
-#define OPTSTRING	"+hvcf:iI:jvnsNaeSupypt"
+#define OPTSTRING	"hvcf:iI:jvnsNaeSupypt"
 
 static const struct option options[] = {
 	{
tests/shell/testcases/chains/0039negative_priority_0 deleted +0 -8
deleted file mode 100755
index ba17b8cc19eda..0000000000000
@@ -1,8 +0,0 @@
-#!/bin/bash
-
-# Test parsing of negative priority values
-
-set -e
-
-$NFT add table t
-$NFT add chain t c { type filter hook input priority -30\; }
Signature · 1 line
2.23.0