mx7ulp_evk: Disable CONFIG_NET
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/3 mx7ulp_evk: Disable CONFIG_NET
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info.
===================================================
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
--- configs/mx7ulp_evk_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/mx7ulp_evk_defconfig +1 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_FAT=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk" CONFIG_ENV_IS_IN_MMC=y +# CONFIG_NET is not set CONFIG_DM=y CONFIG_DM_GPIO=y CONFIG_IMX_RGPIO2P=y
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH 1/3 mx7ulp_evk: Disable CONFIG_NET
Hi Stefano,
Quoted 11 lines · Fabio Estevam
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use
CONFIG_DM_ETH(Driver Model for Ethernet drivers). Please update the board to useCONFIG_DM_ETHbefore the v2020.07 release. Failure to update by the deadline may result in board removal. Seedoc/driver-model/migration.rstfor more info.
===================================================
Quoted 4 lines
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by Fabio Estevam <[email protected]>
It seems that this series has been forgotten. Would you like me to resend it?
PATCH 1/3 mx7ulp_evk: Disable CONFIG_NET
Hi Fabio,
Quoted 14 lines · Fabio Estevam
Hi Stefano,
Quoted 11 lines · Fabio Estevam
Currently the following build warning is seen:
===================== WARNING ====================== This board does not use
CONFIG_DM_ETH(Driver Model for Ethernet drivers). Please update the board to useCONFIG_DM_ETHbefore the v2020.07 release. Failure to update by the deadline may result in board removal. Seedoc/driver-model/migration.rstfor more info.
===================================================
Quoted 6 lines
Quoted 4 lines
Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by Fabio Estevam <[email protected]>It seems that this series has been forgotten.
..I will say lost...
Quoted 1 line
Would you like me to resend it?
I found the series in patchwork, I rebased 1/3 and applied the whole series to -next branch. It flows into -master at my next PR.
Thanks for pointing to this,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH 2/3 mx7ulp_evk: Remove unneeded SDHC definitions
In reply to Fabio EstevamAs we use the driver model for ESDHC there is no need
for defining CONFIG_SYS_FSL_USDHC_NUM and CONFIG_SYS_FSL_ESDHC_ADDR, so simply remove them.
--- include/configs/mx7ulp_evk.h | 3 --- 1 file changed, 3 deletions(-)
include/configs/mx7ulp_evk.h +0 -3
@@ -18,9 +18,6 @@#define IRAM_BASE_ADDR OCRAM_0_BASE#define IOMUXC_BASE_ADDR IOMUXC1_RBASE -#define CONFIG_SYS_FSL_USDHC_NUM 1 - -#define CONFIG_SYS_FSL_ESDHC_ADDR 0#define CONFIG_SYS_MMC_ENV_DEV 0/* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0/* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2"/* USDHC1 */
Signature · 1 line
2.17.1
PATCH 2/3 mx7ulp_evk: Remove unneeded SDHC definitions
Quoted 25 lines
Subject: [PATCH 2/3]
mx7ulp_evk: Remove unneeded SDHC definitionsAs we use the driver model for ESDHC there is no need for defining
CONFIG_SYS_FSL_USDHC_NUMandCONFIG_SYS_FSL_ESDHC_ADDR, so simply remove them.Signed-off-by Fabio Estevam <[email protected]>--- include/configs/mx7ulp_evk.h | 3 --- 1 file changed, 3 deletions(-)include/configs/mx7ulp_evk.h +0
-3@@ -18,9 +18,6 @@#define IRAM_BASE_ADDR OCRAM_0_BASE#define IOMUXC_BASE_ADDR IOMUXC1_RBASE -#define CONFIG_SYS_FSL_USDHC_NUM 1 - -#define CONFIG_SYS_FSL_ESDHC_ADDR 0#define CONFIG_SYS_MMC_ENV_DEV 0/* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0/* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2"/*
Quoted 1 line
USDHC1 */
Quoted 2 lines
--
2.17.1
PATCH 1/3 mx7ulp_evk: Disable CONFIG_NET
In reply to Fabio EstevamQuoted 24 lines
Subject: [PATCH 1/3]
mx7ulp_evk: DisableCONFIG_NETCurrently the following build warning is seen:
===================== WARNING ====================== This board does not use
CONFIG_DM_ETH(Driver Model for Ethernet drivers). Please update the board to useCONFIG_DM_ETHbefore the v2020.07 release. Failure to update by the deadline may result in board removal. Seedoc/driver-model/migration.rstfor more info.
===================================================Since the mx7ulp-evk board does not have networking support, explicitly disable networking.
Signed-off-by Fabio Estevam <[email protected]>--- configs/mx7ulp_evk_defconfig | 1 + 1 file changed, 1 insertion(+)configs/mx7ulp_evk_defconfig +0
-0
configs/mx7ulp_evk_defconfig CONFIG_CMD_FAT=y · line 23
Quoted 7 lines
configs/mx7ulp_evk_defconfig +1
-0@@ -17,6 +17,7 @@ CONFIG_CMD_FAT=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-evk" CONFIG_ENV_IS_IN_MMC=y +# CONFIG_NET is not set CONFIG_DM=y CONFIG_DM_GPIO=y CONFIG_IMX_RGPIO2P=y
Quoted 2 lines
--
2.17.1
Fabio Estevam
reviewerPATCH 3/3 mx7ulp: Move SoC base address to a common file
In reply to Fabio EstevamSoC base addresses should better go into a common SoC file instead of repeating the definition in each board file.
--- arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++ include/configs/mx7ulp_evk.h | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/include/asm/arch-mx7ulp/imx-regs.h +4 -0
@@ -946,6 +946,10 @@#define SNVS_LPCR_DPEN (0x20)#define SNVS_LPCR_SRTC_ENV (0x1) +#define SRC_BASE_ADDR CMC1_RBASE +#define IRAM_BASE_ADDR OCRAM_0_BASE +#define IOMUXC_BASE_ADDR IOMUXC1_RBASE +#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))#include <asm/types.h>
include/configs/mx7ulp_evk.h +0 -4
@@ -14,10 +14,6 @@#define CONFIG_BOARD_POSTCLK_INIT #define CONFIG_SYS_BOOTM_LEN 0x1000000 -#define SRC_BASE_ADDR CMC1_RBASE -#define IRAM_BASE_ADDR OCRAM_0_BASE -#define IOMUXC_BASE_ADDR IOMUXC1_RBASE -#define CONFIG_SYS_MMC_ENV_DEV 0/* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0/* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2"/* USDHC1 */
Signature · 1 line
2.17.1
PATCH 3/3 mx7ulp: Move SoC base address to a common file
Quoted 42 lines
Subject: [PATCH 3/3] mx7ulp: Move SoC base address to a common file
SoC base addresses should better go into a common SoC file instead of repeating the definition in each board file.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++ include/configs/mx7ulp_evk.h | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)arch/arm/include/asm/arch-mx7ulp/imx-regs.h +4
-0@@ -946,6 +946,10 @@#define SNVS_LPCR_DPEN (0x20)#define SNVS_LPCR_SRTC_ENV (0x1) +#define SRC_BASE_ADDR CMC1_RBASE +#define IRAM_BASE_ADDR OCRAM_0_BASE +#define IOMUXC_BASE_ADDR IOMUXC1_RBASE +#if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))#include <asm/types.h> include/configs/mx7ulp_evk.h +0
-4@@ -14,10 +14,6 @@#define CONFIG_BOARD_POSTCLK_INIT #define CONFIG_SYS_BOOTM_LEN 0x1000000 -#define SRC_BASE_ADDR CMC1_RBASE -#define IRAM_BASE_ADDR OCRAM_0_BASE -#define IOMUXC_BASE_ADDR IOMUXC1_RBASE -#define CONFIG_SYS_MMC_ENV_DEV 0/* USDHC1 */ #define CONFIG_SYS_MMC_ENV_PART 0/* user area */ #define CONFIG_MMCROOT "/dev/mmcblk0p2"/*
Quoted 1 line
USDHC1 */
Quoted 2 lines
--
2.17.1